From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH V4] sdl2: new package
Date: Wed, 21 Oct 2015 22:56:00 +0200 [thread overview]
Message-ID: <5627FBE0.5010004@openwide.fr> (raw)
In-Reply-To: <20151019134532.GA12643@laptop-vstehle>
Hi Vincent, All,
Le 19/10/2015 15:45, Vincent Stehl? a ?crit :
> Hi Guillaume and Romain,
>
> Thank you for your effort on this nice sdl2 buildroot patch. I hope you
> are still working on it.
Actually no, I only reviewed it after the Buildroot summer camp and sent an
updated version. Since then it's waiting for a reviewer or tester ;-)
>
> While trying v5 of the path recently, as found in buildroot patchwork, I
> needed to add the following line to sdl2.mk:
>
> SDL2_CONFIG_SCRIPTS = sdl2-config
>
> Without this line, the include path returned by `sdl2-config --cflags`
> will be something like /usr/include/SDL2, instead of pointing to the
> buildroot staging dir.
>
> You might want to add it to a v6, maybe?
Thanks for the feedback ! You're probably right, I need to rebuild it locally to
check.
I used it to enable the sdl2 support during the development of my efl patches
series, I didn't see any build issue even with the paranoid toolchain wrapper
enabled... (but the sdl2-config is probably not used)
>
> Apart from that, it works fine for me, thanks!
Great!
I'll send an updated version with your fix, can you send your tested and/or
reviewed tag ;-)
Best regards,
Romain
>
> Best regards,
>
> V.
>
next prev parent reply other threads:[~2015-10-21 20:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 9:47 [Buildroot] [PATCH] sdl2: new package Guillaume GARDET
2015-03-13 10:39 ` Guillaume GARDET - Oliséo
2015-03-13 16:14 ` Thomas Petazzoni
2015-03-30 9:33 ` Guillaume GARDET - Oliséo
2015-03-30 12:50 ` Guillaume GARDET - Oliséo
2015-03-30 12:59 ` Thomas Petazzoni
2015-03-30 13:14 ` [Buildroot] [PATCH V2] " Guillaume GARDET
2015-04-22 8:35 ` Guillaume GARDET - Oliséo
2015-04-22 22:11 ` Romain Naour
2015-06-29 20:30 ` [Buildroot] [PATCH V3] " Guillaume GARDET
2015-06-29 22:22 ` Yann E. MORIN
2015-07-02 8:16 ` [Buildroot] [PATCH V4] " Guillaume GARDET
2015-07-05 18:21 ` Romain Naour
2015-07-06 12:17 ` Guillaume GARDET - Oliséo
2015-07-06 12:26 ` Thomas Petazzoni
2015-07-06 13:23 ` Guillaume GARDET - Oliséo
2015-07-06 13:34 ` Thomas Petazzoni
2015-07-07 22:19 ` Arnout Vandecappelle
2015-07-18 18:57 ` Romain Naour
2015-10-19 13:45 ` Vincent Stehlé
2015-10-21 20:56 ` Romain Naour [this message]
2015-10-21 21:09 ` Romain Naour
2015-10-21 21:22 ` Thomas Petazzoni
2015-10-21 21:25 ` Romain Naour
2015-07-07 22:22 ` Arnout Vandecappelle
2015-05-03 15:03 ` [Buildroot] [PATCH V2] " Bernd Kuhls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5627FBE0.5010004@openwide.fr \
--to=romain.naour@openwide.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox