Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] package/git: Used curl-config program for target
Date: Wed, 28 Oct 2015 09:32:06 +0100	[thread overview]
Message-ID: <56308806.5040403@mind.be> (raw)
In-Reply-To: <20151028082327.GC13534@cruxbox>



On 28-10-15 09:23, Remi Pommarel wrote:
> On Wed, Oct 28, 2015 at 12:07:45AM +0100, Arnout Vandecappelle wrote:
>> On 26-10-15 22:12, Remi Pommarel wrote:
>>> Fix cross compilation by using curl-config script for target instead of the
>>> one from host.
>>>
>>> Signed-off-by: Remi Pommarel <repk@triplefau.lt>
>>
>>  Again, please patch configure.ac instead of configure. Otherwise, looks good to
>> me. Though I didn't immediately understand why it wasn't necessary to add
>> CURL_CONFIG to config.mak.in
> 
> Ok I will use configure.ac patch instead. Git can be configured using
> two ways, either using configure or using config.mak.in. I could have set
> CURL_CONFIG in config.mak.in also but using the two methods at the same
> time is redundant.

 Er, I'm pretty sure that configure will convert config.mak.in into
config.mak.autogen. But it will append all the GIT_CONFIG_SUBST variables, which
is not usual autotools idiom, that's why I was confused.

 Regards,
 Arnout

-- 
Arnout Vandecappelle      arnout dot vandecappelle at essensium dot com
Senior Embedded Software Architect . . . . . . +32-478-010353 (mobile)
Essensium, Mind division . . . . . . . . . . . . . . http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium . . . . . BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2015-10-28  8:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-26 21:12 [Buildroot] [PATCH 0/3] package/git: Fix static compilation Remi Pommarel
2015-10-26 21:12 ` [Buildroot] [PATCH 1/3] package/git: Add needed library for " Remi Pommarel
2015-10-27  5:32   ` Baruch Siach
2015-10-28  8:16     ` Remi Pommarel
2015-10-28  8:27       ` Baruch Siach
2015-10-26 21:12 ` [Buildroot] [PATCH 2/3] package/git: Add git patch " Remi Pommarel
2015-10-27 22:48   ` Arnout Vandecappelle
2015-10-26 21:12 ` [Buildroot] [PATCH 3/3] package/git: Used curl-config program for target Remi Pommarel
2015-10-27 23:07   ` Arnout Vandecappelle
2015-10-28  8:23     ` Remi Pommarel
2015-10-28  8:32       ` Arnout Vandecappelle [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-10-26 21:06 [Buildroot] [PATCH 0/3] package/git: Fix static compilation Remi Pommarel
2015-10-26 21:06 ` [Buildroot] [PATCH 3/3] package/git: Used curl-config program for target Remi Pommarel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56308806.5040403@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox