[Buildroot] [PATCH] pkg-download: support file:// in BR2_PRIMARY_SITE

[Buildroot] [PATCH] pkg-download: support file:// in BR2_PRIMARY_SITE

[Jérôme Pouiller]

This feature was already discuted here:

  http://lists.busybox.net/pipermail/buildroot/2015-April/125419.html

Personally, I have a big central directory with all tarballs I have
ever downloaded. I use this feature to isolate tarballs necessary to
build a configuration:

  make project_defconfig
  make BR2_DL_DIR=/tmp/mirror-project BR2_PRIMARY_SITE=file:///home/user/dl source
  tar -C /tmp -czvf mirror-project.tgz mirror-project

Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
---
 package/pkg-download.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/pkg-download.mk b/package/pkg-download.mk
index c86b9ab..f08f616 100644
--- a/package/pkg-download.mk
+++ b/package/pkg-download.mk
@@ -214,6 +214,7 @@ endef
 define DOWNLOAD_INNER
 	$(Q)if test -n "$(call qstrip,$(BR2_PRIMARY_SITE))" ; then \
 		case "$(call geturischeme,$(BR2_PRIMARY_SITE))" in \
+			file) $(call $(3)_LOCALFILES,$(BR2_PRIMARY_SITE)/$(2),$(2)) && exit ;; \
 			scp) $(call $(3)_SCP,$(BR2_PRIMARY_SITE)/$(2),$(2)) && exit ;; \
 			*) $(call $(3)_WGET,$(BR2_PRIMARY_SITE)/$(2),$(2)) && exit ;; \
 		esac ; \
-- 
2.1.4

[Buildroot] [PATCH] pkg-download: support file:// in BR2_PRIMARY_SITE

[Thomas Petazzoni]

Dear J?r?me Pouiller,

On Tue, 17 Nov 2015 17:07:58 +0100, J?r?me Pouiller wrote:
> This feature was already discuted here:
> 
>   http://lists.busybox.net/pipermail/buildroot/2015-April/125419.html
> 
> Personally, I have a big central directory with all tarballs I have
> ever downloaded. I use this feature to isolate tarballs necessary to
> build a configuration:
> 
>   make project_defconfig
>   make BR2_DL_DIR=/tmp/mirror-project BR2_PRIMARY_SITE=file:///home/user/dl source
>   tar -C /tmp -czvf mirror-project.tgz mirror-project

You have a much simpler option:

	make external-deps

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] pkg-download: support file:// in BR2_PRIMARY_SITE

[Arnout Vandecappelle]

On 17-11-15 17:07, J?r?me Pouiller wrote:
> This feature was already discuted here:
> 
>   http://lists.busybox.net/pipermail/buildroot/2015-April/125419.html
> 
> Personally, I have a big central directory with all tarballs I have
> ever downloaded. I use this feature to isolate tarballs necessary to
> build a configuration:
> 
>   make project_defconfig
>   make BR2_DL_DIR=/tmp/mirror-project BR2_PRIMARY_SITE=file:///home/user/dl source
>   tar -C /tmp -czvf mirror-project.tgz mirror-project
> 
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 for next

 Regards,
 Arnout

> ---
>  package/pkg-download.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/pkg-download.mk b/package/pkg-download.mk
> index c86b9ab..f08f616 100644
> --- a/package/pkg-download.mk
> +++ b/package/pkg-download.mk
> @@ -214,6 +214,7 @@ endef
>  define DOWNLOAD_INNER
>  	$(Q)if test -n "$(call qstrip,$(BR2_PRIMARY_SITE))" ; then \
>  		case "$(call geturischeme,$(BR2_PRIMARY_SITE))" in \
> +			file) $(call $(3)_LOCALFILES,$(BR2_PRIMARY_SITE)/$(2),$(2)) && exit ;; \
>  			scp) $(call $(3)_SCP,$(BR2_PRIMARY_SITE)/$(2),$(2)) && exit ;; \
>  			*) $(call $(3)_WGET,$(BR2_PRIMARY_SITE)/$(2),$(2)) && exit ;; \
>  		esac ; \
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH] pkg-download: support file:// in BR2_PRIMARY_SITE

[Arnout Vandecappelle]

On 17-11-15 17:55, Thomas Petazzoni wrote:
> Dear J?r?me Pouiller,
> 
> On Tue, 17 Nov 2015 17:07:58 +0100, J?r?me Pouiller wrote:
>> This feature was already discuted here:
>>
>>   http://lists.busybox.net/pipermail/buildroot/2015-April/125419.html
>>
>> Personally, I have a big central directory with all tarballs I have
>> ever downloaded. I use this feature to isolate tarballs necessary to
>> build a configuration:
>>
>>   make project_defconfig
>>   make BR2_DL_DIR=/tmp/mirror-project BR2_PRIMARY_SITE=file:///home/user/dl source
>>   tar -C /tmp -czvf mirror-project.tgz mirror-project
> 
> You have a much simpler option:
> 
> 	make external-deps

 You probably mean:

for file in $(make external-deps); cp dl/$file /tmp/mirror-project; done


 I think a local file PRIMARY_SITE can be useful for other situations as well,
e.g. a slow CIFS-mounted shared download location that is too slow to use as
DL_DIR, so I think the feature has merit.

 Regards,
 Arnout


> 
> Thomas
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH] pkg-download: support file:// in BR2_PRIMARY_SITE

[Thomas Petazzoni]

Arnout, J?r?me,

On Tue, 17 Nov 2015 23:54:12 +0100, Arnout Vandecappelle wrote:

> >>   make project_defconfig
> >>   make BR2_DL_DIR=/tmp/mirror-project BR2_PRIMARY_SITE=file:///home/user/dl source
> >>   tar -C /tmp -czvf mirror-project.tgz mirror-project
> > 
> > You have a much simpler option:
> > 
> > 	make external-deps
> 
>  You probably mean:
> 
> for file in $(make external-deps); cp dl/$file /tmp/mirror-project; done

Yes, indeed, I only pointed at "make external-deps", leaving it to the
reader to figure out how to make use of it in the context of what
J?r?me is trying to do. But I could have been more explicit.

>  I think a local file PRIMARY_SITE can be useful for other situations as well,
> e.g. a slow CIFS-mounted shared download location that is too slow to use as
> DL_DIR, so I think the feature has merit.

Yes, I also think the feature has merit.

J?r?me, could you respin the patch after updating the Config.in help
text of the BR2_PRIMARY_SITE option?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com