[Buildroot] [PATCH] minizip: new package

[Buildroot] [PATCH] minizip: new package

[gustavo.zacarias at free-electrons.com]

From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>

Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
---
 package/Config.in          |  1 +
 package/minizip/Config.in  | 15 +++++++++++++++
 package/minizip/minizip.mk | 17 +++++++++++++++++
 3 files changed, 33 insertions(+)
 create mode 100644 package/minizip/Config.in
 create mode 100644 package/minizip/minizip.mk

diff --git a/package/Config.in b/package/Config.in
index f9af31c..d6d5505 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -746,6 +746,7 @@ menu "Compression and decompression"
 	source "package/libsquish/Config.in"
 	source "package/libzip/Config.in"
 	source "package/lzo/Config.in"
+	source "package/minizip/Config.in"
 	source "package/snappy/Config.in"
 	source "package/szip/Config.in"
 	source "package/zlib/Config.in"
diff --git a/package/minizip/Config.in b/package/minizip/Config.in
new file mode 100644
index 0000000..7205e00
--- /dev/null
+++ b/package/minizip/Config.in
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_MINIZIP
+	bool "minizip"
+	select BR2_PACKAGE_ZLIB
+	help
+	  Enables to extract files from a .zip archive file.
+	  It is compatible with PKZip 2.04g, WinZip, InfoZip,
+	  MimarSinan Codex Suite 2002 tools, and compatible sofware.
+
+	  https://github.com/nmoinvaz/minizip
+
+config BR2_PACKAGE_MINIZIP_DEMOS
+	bool "miniunzip/minizip"
+	depends on BR2_PACKAGE_MINIZIP
+	help
+	  Enable miniunzip/minizip binary tools.
diff --git a/package/minizip/minizip.mk b/package/minizip/minizip.mk
new file mode 100644
index 0000000..aa77c56
--- /dev/null
+++ b/package/minizip/minizip.mk
@@ -0,0 +1,17 @@
+################################################################################
+#
+# minizip
+#
+################################################################################
+
+MINIZIP_VERSION = 977afb22966e6ab0ee401293a8e85fe808133f9a
+MINIZIP_SITE = https://github.com/nmoinvaz/minizip.git
+MINIZIP_SITE_METHOD = git
+MINIZIP_DEPENDENCIES = zlib
+MINIZIP_AUTORECONF = YES
+MINIZIP_INSTALL_STAGING = YES
+MINIZIP_CONF_OPTS = $(if $(BR2_PACKAGE_MINIZIP_DEMOS),--enable-demos)
+MINIZIP_LICENSE = zlib license
+MINIZIP_LICENSE_FILES = LICENSE
+
+$(eval $(autotools-package))
-- 
2.4.10

[Buildroot] [PATCH] minizip: new package

[Vicente Olivert Riera]

Dear Gustavo Zacarias,

On 23/11/15 22:06, gustavo.zacarias at free-electrons.com wrote:

[snip]

> diff --git a/package/minizip/Config.in b/package/minizip/Config.in
> new file mode 100644
> index 0000000..7205e00
> --- /dev/null
> +++ b/package/minizip/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_MINIZIP
> +	bool "minizip"
> +	select BR2_PACKAGE_ZLIB
> +	help
> +	  Enables to extract files from a .zip archive file.
> +	  It is compatible with PKZip 2.04g, WinZip, InfoZip,
> +	  MimarSinan Codex Suite 2002 tools, and compatible sofware.
> +
> +	  https://github.com/nmoinvaz/minizip
> +
> +config BR2_PACKAGE_MINIZIP_DEMOS
> +	bool "miniunzip/minizip"

Personally I would write something more obvious like "Install tools".

> +	depends on BR2_PACKAGE_MINIZIP
> +	help
> +	  Enable miniunzip/minizip binary tools.
> diff --git a/package/minizip/minizip.mk b/package/minizip/minizip.mk
> new file mode 100644
> index 0000000..aa77c56
> --- /dev/null
> +++ b/package/minizip/minizip.mk
> @@ -0,0 +1,17 @@
> +################################################################################
> +#
> +# minizip
> +#
> +################################################################################
> +
> +MINIZIP_VERSION = 977afb22966e6ab0ee401293a8e85fe808133f9a
> +MINIZIP_SITE = https://github.com/nmoinvaz/minizip.git

Why not using the github helper?

MINIZIP_SITE = $(call github,nmoinvaz,minizip,$(MINIZIP_VERSION))

> +MINIZIP_SITE_METHOD = git

Not needed if you use the github helper, although I'm sure you already
know that.

> +MINIZIP_DEPENDENCIES = zlib
> +MINIZIP_AUTORECONF = YES
> +MINIZIP_INSTALL_STAGING = YES
> +MINIZIP_CONF_OPTS = $(if $(BR2_PACKAGE_MINIZIP_DEMOS),--enable-demos)
> +MINIZIP_LICENSE = zlib license
> +MINIZIP_LICENSE_FILES = LICENSE
> +
> +$(eval $(autotools-package))
> 

And you forgot to add a hash file like this:

# Locally calculated
sha256 b39158bdf3d8bf81d3a7412dc761851fda398bc93d8989d5e940ed4ae5bbb52c
 minizip-977afb22966e6ab0ee401293a8e85fe808133f9a.tar.gz

Regards,

Vincent.

[Buildroot] [PATCH] minizip: new package

[Gustavo Zacarias]

On 24/11/15 11:33, Vicente Olivert Riera wrote:

>> +config BR2_PACKAGE_MINIZIP_DEMOS
>> +	bool "miniunzip/minizip"
>
> Personally I would write something more obvious like "Install tools".

Hi.
Well, "install tools" doesn't say much, saying what's installed if it 
fits is much more useful.
Besides these aren't tools, they're demos, that's why the config symbol 
is called so.
For a fully-fledged zip/unzip implementation infozip fits the bill more 
nicely, if you want a lib then this is it.
The rest addressed in v2.
Regards.