* [Buildroot] [PATCH 1/1] cxxtest: new package
@ 2015-11-26 5:39 Abhishek Singh
2015-11-26 8:32 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Abhishek Singh @ 2015-11-26 5:39 UTC (permalink / raw)
To: buildroot
Reviewed-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
Reviewed-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
Reviewed-by: Piotr Nakraszewicz <piotr.nakraszewicz@imgtec.com>
Signed-off-by: Abhishek Singh <Abhishek.Singh@imgtec.com>
---
package/Config.in | 1 +
package/cxxtest/Config.in | 10 ++++++++++
package/cxxtest/cxxtest.hash | 2 ++
package/cxxtest/cxxtest.mk | 25 +++++++++++++++++++++++++
4 files changed, 38 insertions(+)
create mode 100644 package/cxxtest/Config.in
create mode 100644 package/cxxtest/cxxtest.hash
create mode 100644 package/cxxtest/cxxtest.mk
diff --git a/package/Config.in b/package/Config.in
index bdc3063..6e71d25 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -116,6 +116,7 @@ menu "Development tools"
source "package/cmake/Config.in"
source "package/cppunit/Config.in"
source "package/cvs/Config.in"
+ source "package/cxxtest/Config.in"
if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
source "package/diffutils/Config.in"
source "package/dos2unix/Config.in"
diff --git a/package/cxxtest/Config.in b/package/cxxtest/Config.in
new file mode 100644
index 0000000..7512e4b
--- /dev/null
+++ b/package/cxxtest/Config.in
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_CXXTEST
+ bool "cxxtest"
+ depends on BR2_INSTALL_LIBSTDCPP
+ help
+ CxxTest is a unit testing framework for C++
+
+ http://cxxtest.com/
+
+comment "cxxtest needs toolchain with C++ support"
+ depends on !BR2_INSTALL_LIBSTDCPP
diff --git a/package/cxxtest/cxxtest.hash b/package/cxxtest/cxxtest.hash
new file mode 100644
index 0000000..f552e80
--- /dev/null
+++ b/package/cxxtest/cxxtest.hash
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256 1c154fef91c65dbf1cd4519af7ade70a61d85a923b6e0c0b007dc7f4895cf7d8 cxxtest-4.4.tar.gz
diff --git a/package/cxxtest/cxxtest.mk b/package/cxxtest/cxxtest.mk
new file mode 100644
index 0000000..5089f92
--- /dev/null
+++ b/package/cxxtest/cxxtest.mk
@@ -0,0 +1,25 @@
+################################################################################
+#
+# cxxtest
+#
+################################################################################
+
+CXXTEST_VERSION = 4.4
+CXXTEST_SOURCE = cxxtest-$(CXXTEST_VERSION).tar.gz
+CXXTEST_SITE = http://sourceforge.net/projects/cxxtest/files/cxxtest/$(CXXTEST_VERSION)
+CXXTEST_LICENSE = LGPLv3
+CXXTEST_LICENSE_FILES = COPYING
+CXXTEST_INSTALL_STAGING = YES
+CXXTEST_INSTALL_TARGET = NO
+CXXTEST_DEPENDENCIES = host-cxxtest
+HOST_CXXTEST_DEPENDENCIES = host-python
+HOST_CXXTEST_SETUP_TYPE = setuptools
+HOST_CXXTEST_SUBDIR = python
+
+define CXXTEST_INSTALL_STAGING_CMDS
+ mkdir -p $(STAGING_DIR)/usr/include/cxxtest
+ cp $(@D)/cxxtest/* $(STAGING_DIR)/usr/include/cxxtest
+endef
+
+$(eval $(generic-package))
+$(eval $(host-python-package))
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] cxxtest: new package
2015-11-26 5:39 [Buildroot] [PATCH 1/1] cxxtest: new package Abhishek Singh
@ 2015-11-26 8:32 ` Thomas Petazzoni
2015-11-26 11:26 ` Abhishek Singh
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2015-11-26 8:32 UTC (permalink / raw)
To: buildroot
Dear Abhishek Singh,
On Thu, 26 Nov 2015 11:09:49 +0530, Abhishek Singh wrote:
> diff --git a/package/cxxtest/Config.in b/package/cxxtest/Config.in
> new file mode 100644
> index 0000000..7512e4b
> --- /dev/null
> +++ b/package/cxxtest/Config.in
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_CXXTEST
> + bool "cxxtest"
> + depends on BR2_INSTALL_LIBSTDCPP
> + help
> + CxxTest is a unit testing framework for C++
> +
> + http://cxxtest.com/
> +
> +comment "cxxtest needs toolchain with C++ support"
> + depends on !BR2_INSTALL_LIBSTDCPP
> diff --git a/package/cxxtest/cxxtest.hash b/package/cxxtest/cxxtest.hash
> new file mode 100644
> index 0000000..f552e80
> --- /dev/null
> +++ b/package/cxxtest/cxxtest.hash
> @@ -0,0 +1,2 @@
> +# Locally computed:
> +sha256 1c154fef91c65dbf1cd4519af7ade70a61d85a923b6e0c0b007dc7f4895cf7d8 cxxtest-4.4.tar.gz
> diff --git a/package/cxxtest/cxxtest.mk b/package/cxxtest/cxxtest.mk
> new file mode 100644
> index 0000000..5089f92
> --- /dev/null
> +++ b/package/cxxtest/cxxtest.mk
> @@ -0,0 +1,25 @@
> +################################################################################
> +#
> +# cxxtest
> +#
> +################################################################################
> +
> +CXXTEST_VERSION = 4.4
> +CXXTEST_SOURCE = cxxtest-$(CXXTEST_VERSION).tar.gz
> +CXXTEST_SITE = http://sourceforge.net/projects/cxxtest/files/cxxtest/$(CXXTEST_VERSION)
> +CXXTEST_LICENSE = LGPLv3
> +CXXTEST_LICENSE_FILES = COPYING
> +CXXTEST_INSTALL_STAGING = YES
> +CXXTEST_INSTALL_TARGET = NO
Is CxxTest just a set of C++ headers with no library ?
> +CXXTEST_DEPENDENCIES = host-cxxtest
> +HOST_CXXTEST_DEPENDENCIES = host-python
This is not needed. host-cxxtest is using host-python-package, so the
dependency on host-python is automatically added by the
host-python-package infrastructure.
> +HOST_CXXTEST_SETUP_TYPE = setuptools
> +HOST_CXXTEST_SUBDIR = python
> +
> +define CXXTEST_INSTALL_STAGING_CMDS
> + mkdir -p $(STAGING_DIR)/usr/include/cxxtest
> + cp $(@D)/cxxtest/* $(STAGING_DIR)/usr/include/cxxtest
> +endef
> +
> +$(eval $(generic-package))
> +$(eval $(host-python-package))
I have to say it is quite strange to have the host variant of the
package using the python package infrastructure, and the target variant
use the generic package infra. I think it would deserve an additional
comment in the .mk file to give a bit of context about why you're doing
this.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] cxxtest: new package
2015-11-26 8:32 ` Thomas Petazzoni
@ 2015-11-26 11:26 ` Abhishek Singh
0 siblings, 0 replies; 3+ messages in thread
From: Abhishek Singh @ 2015-11-26 11:26 UTC (permalink / raw)
To: buildroot
On Thursday 26 November 2015 02:02 PM, Thomas Petazzoni wrote:
> Dear Abhishek Singh,
>
> On Thu, 26 Nov 2015 11:09:49 +0530, Abhishek Singh wrote:
>
>> diff --git a/package/cxxtest/Config.in b/package/cxxtest/Config.in
>> new file mode 100644
>> index 0000000..7512e4b
>> --- /dev/null
>> +++ b/package/cxxtest/Config.in
>> @@ -0,0 +1,10 @@
>> +config BR2_PACKAGE_CXXTEST
>> + bool "cxxtest"
>> + depends on BR2_INSTALL_LIBSTDCPP
>> + help
>> + CxxTest is a unit testing framework for C++
>> +
>> + http://cxxtest.com/
>> +
>> +comment "cxxtest needs toolchain with C++ support"
>> + depends on !BR2_INSTALL_LIBSTDCPP
>> diff --git a/package/cxxtest/cxxtest.hash b/package/cxxtest/cxxtest.hash
>> new file mode 100644
>> index 0000000..f552e80
>> --- /dev/null
>> +++ b/package/cxxtest/cxxtest.hash
>> @@ -0,0 +1,2 @@
>> +# Locally computed:
>> +sha256 1c154fef91c65dbf1cd4519af7ade70a61d85a923b6e0c0b007dc7f4895cf7d8 cxxtest-4.4.tar.gz
>> diff --git a/package/cxxtest/cxxtest.mk b/package/cxxtest/cxxtest.mk
>> new file mode 100644
>> index 0000000..5089f92
>> --- /dev/null
>> +++ b/package/cxxtest/cxxtest.mk
>> @@ -0,0 +1,25 @@
>> +################################################################################
>> +#
>> +# cxxtest
>> +#
>> +################################################################################
>> +
>> +CXXTEST_VERSION = 4.4
>> +CXXTEST_SOURCE = cxxtest-$(CXXTEST_VERSION).tar.gz
>> +CXXTEST_SITE = http://sourceforge.net/projects/cxxtest/files/cxxtest/$(CXXTEST_VERSION)
>> +CXXTEST_LICENSE = LGPLv3
>> +CXXTEST_LICENSE_FILES = COPYING
>> +CXXTEST_INSTALL_STAGING = YES
>> +CXXTEST_INSTALL_TARGET = NO
> Is CxxTest just a set of C++ headers with no library ?
CxxTest is just set of C++ headers and source files (acting as header). It uses python infrastructure to generate cxxtestgen command.
>
>> +CXXTEST_DEPENDENCIES = host-cxxtest
>> +HOST_CXXTEST_DEPENDENCIES = host-python
> This is not needed. host-cxxtest is using host-python-package, so the
> dependency on host-python is automatically added by the
> host-python-package infrastructure.
>
>> +HOST_CXXTEST_SETUP_TYPE = setuptools
>> +HOST_CXXTEST_SUBDIR = python
>> +
>> +define CXXTEST_INSTALL_STAGING_CMDS
>> + mkdir -p $(STAGING_DIR)/usr/include/cxxtest
>> + cp $(@D)/cxxtest/* $(STAGING_DIR)/usr/include/cxxtest
>> +endef
>> +
>> +$(eval $(generic-package))
>> +$(eval $(host-python-package))
> I have to say it is quite strange to have the host variant of the
> package using the python package infrastructure, and the target variant
> use the generic package infra. I think it would deserve an additional
> comment in the .mk file to give a bit of context about why you're doing
> this.
>
> Thanks!
>
> Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-26 11:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-26 5:39 [Buildroot] [PATCH 1/1] cxxtest: new package Abhishek Singh
2015-11-26 8:32 ` Thomas Petazzoni
2015-11-26 11:26 ` Abhishek Singh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox