* [Buildroot] [PATCH] rpi-userland: fix musl compile
@ 2015-11-27 17:37 Sergio Prado
2015-11-27 18:30 ` Peter Korsgaard
2015-11-27 20:50 ` Arnout Vandecappelle
0 siblings, 2 replies; 4+ messages in thread
From: Sergio Prado @ 2015-11-27 17:37 UTC (permalink / raw)
To: buildroot
When building with musl, the build fails with a conflicting type
qualifier error.
This is because musl defines stdout and stderr as const pointers
and RaspiVidYUV.c adds an extern declaration as normal pointers.
Since this declaration already comes in on the header (stdio.h),
there is no need to add an extern declaration, so removes it.
Fixes:
http://autobuild.buildroot.net/results/27bd6f32cecdb4e7c95247c1feaf2732c1d8e3fa
Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
---
...ting-type-qualifiers-errors-when-building.patch | 23 ++++++++++++++++++++++
1 file changed, 23 insertions(+)
create mode 100644 package/rpi-userland/0006-Fix-conflicting-type-qualifiers-errors-when-building.patch
diff --git a/package/rpi-userland/0006-Fix-conflicting-type-qualifiers-errors-when-building.patch b/package/rpi-userland/0006-Fix-conflicting-type-qualifiers-errors-when-building.patch
new file mode 100644
index 000000000000..4db60142c6ad
--- /dev/null
+++ b/package/rpi-userland/0006-Fix-conflicting-type-qualifiers-errors-when-building.patch
@@ -0,0 +1,23 @@
+Fix conflicting type qualifiers errors when building with musl.
+
+Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
+---
+ host_applications/linux/apps/raspicam/RaspiVidYUV.c | 2 --
+ 1 file changed, 2 deletions(-)
+
+diff --git a/host_applications/linux/apps/raspicam/RaspiVidYUV.c b/host_applications/linux/apps/raspicam/RaspiVidYUV.c
+index b340d63c913f..13e6a6ccf5bf 100644
+--- a/host_applications/linux/apps/raspicam/RaspiVidYUV.c
++++ b/host_applications/linux/apps/raspicam/RaspiVidYUV.c
+@@ -106,8 +106,6 @@ const int ABORT_INTERVAL = 100; // ms
+ /// Run/record forever
+ #define WAIT_METHOD_FOREVER 4
+
+-extern FILE *stderr, *stdout;
+-
+ int mmal_status_to_int(MMAL_STATUS_T status);
+ static void signal_handler(int signal_number);
+
+--
+1.9.1
+
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] rpi-userland: fix musl compile
2015-11-27 17:37 [Buildroot] [PATCH] rpi-userland: fix musl compile Sergio Prado
@ 2015-11-27 18:30 ` Peter Korsgaard
2015-11-27 20:50 ` Arnout Vandecappelle
1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2015-11-27 18:30 UTC (permalink / raw)
To: buildroot
>>>>> "Sergio" == Sergio Prado <sergio.prado@e-labworks.com> writes:
> When building with musl, the build fails with a conflicting type
> qualifier error.
> This is because musl defines stdout and stderr as const pointers
> and RaspiVidYUV.c adds an extern declaration as normal pointers.
> Since this declaration already comes in on the header (stdio.h),
> there is no need to add an extern declaration, so removes it.
> Fixes:
> http://autobuild.buildroot.net/results/27bd6f32cecdb4e7c95247c1feaf2732c1d8e3fa
> Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] rpi-userland: fix musl compile
2015-11-27 17:37 [Buildroot] [PATCH] rpi-userland: fix musl compile Sergio Prado
2015-11-27 18:30 ` Peter Korsgaard
@ 2015-11-27 20:50 ` Arnout Vandecappelle
2015-11-27 21:31 ` Sergio Prado
1 sibling, 1 reply; 4+ messages in thread
From: Arnout Vandecappelle @ 2015-11-27 20:50 UTC (permalink / raw)
To: buildroot
Hi Sergio,
On 27-11-15 18:37, Sergio Prado wrote:
> When building with musl, the build fails with a conflicting type
> qualifier error.
>
> This is because musl defines stdout and stderr as const pointers
> and RaspiVidYUV.c adds an extern declaration as normal pointers.
>
> Since this declaration already comes in on the header (stdio.h),
> there is no need to add an extern declaration, so removes it.
>
> Fixes:
>
> http://autobuild.buildroot.net/results/27bd6f32cecdb4e7c95247c1feaf2732c1d8e3fa
> Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
> ---
> ...ting-type-qualifiers-errors-when-building.patch | 23 ++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 package/rpi-userland/0006-Fix-conflicting-type-qualifiers-errors-when-building.patch
>
> diff --git a/package/rpi-userland/0006-Fix-conflicting-type-qualifiers-errors-when-building.patch b/package/rpi-userland/0006-Fix-conflicting-type-qualifiers-errors-when-building.patch
> new file mode 100644
> index 000000000000..4db60142c6ad
> --- /dev/null
> +++ b/package/rpi-userland/0006-Fix-conflicting-type-qualifiers-errors-when-building.patch
> @@ -0,0 +1,23 @@
> +Fix conflicting type qualifiers errors when building with musl.
> +
> +Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
Did you send this patch upstream?
Regards,
Arnout
> +---
> + host_applications/linux/apps/raspicam/RaspiVidYUV.c | 2 --
> + 1 file changed, 2 deletions(-)
> +
> +diff --git a/host_applications/linux/apps/raspicam/RaspiVidYUV.c b/host_applications/linux/apps/raspicam/RaspiVidYUV.c
> +index b340d63c913f..13e6a6ccf5bf 100644
> +--- a/host_applications/linux/apps/raspicam/RaspiVidYUV.c
> ++++ b/host_applications/linux/apps/raspicam/RaspiVidYUV.c
> +@@ -106,8 +106,6 @@ const int ABORT_INTERVAL = 100; // ms
> + /// Run/record forever
> + #define WAIT_METHOD_FOREVER 4
> +
> +-extern FILE *stderr, *stdout;
> +-
> + int mmal_status_to_int(MMAL_STATUS_T status);
> + static void signal_handler(int signal_number);
> +
> +--
> +1.9.1
> +
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] rpi-userland: fix musl compile
2015-11-27 20:50 ` Arnout Vandecappelle
@ 2015-11-27 21:31 ` Sergio Prado
0 siblings, 0 replies; 4+ messages in thread
From: Sergio Prado @ 2015-11-27 21:31 UTC (permalink / raw)
To: buildroot
Hi Arnout,
2015-11-27 18:50 GMT-02:00 Arnout Vandecappelle <arnout@mind.be>:
> Hi Sergio,
>
> On 27-11-15 18:37, Sergio Prado wrote:
> > When building with musl, the build fails with a conflicting type
> > qualifier error.
> >
> > This is because musl defines stdout and stderr as const pointers
> > and RaspiVidYUV.c adds an extern declaration as normal pointers.
> >
> > Since this declaration already comes in on the header (stdio.h),
> > there is no need to add an extern declaration, so removes it.
> >
> > Fixes:
> >
> >
> http://autobuild.buildroot.net/results/27bd6f32cecdb4e7c95247c1feaf2732c1d8e3fa
> > Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
> > ---
> > ...ting-type-qualifiers-errors-when-building.patch | 23
> ++++++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> > create mode 100644
> package/rpi-userland/0006-Fix-conflicting-type-qualifiers-errors-when-building.patch
> >
> > diff --git
> a/package/rpi-userland/0006-Fix-conflicting-type-qualifiers-errors-when-building.patch
> b/package/rpi-userland/0006-Fix-conflicting-type-qualifiers-errors-when-building.patch
> > new file mode 100644
> > index 000000000000..4db60142c6ad
> > --- /dev/null
> > +++
> b/package/rpi-userland/0006-Fix-conflicting-type-qualifiers-errors-when-building.patch
> > @@ -0,0 +1,23 @@
> > +Fix conflicting type qualifiers errors when building with musl.
> > +
> > +Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
>
> Did you send this patch upstream?
>
I've just did: https://github.com/raspberrypi/userland/pull/272
> Regards,
> Arnout
>
Thanks!
>
> > +---
> > + host_applications/linux/apps/raspicam/RaspiVidYUV.c | 2 --
> > + 1 file changed, 2 deletions(-)
> > +
> > +diff --git a/host_applications/linux/apps/raspicam/RaspiVidYUV.c
> b/host_applications/linux/apps/raspicam/RaspiVidYUV.c
> > +index b340d63c913f..13e6a6ccf5bf 100644
> > +--- a/host_applications/linux/apps/raspicam/RaspiVidYUV.c
> > ++++ b/host_applications/linux/apps/raspicam/RaspiVidYUV.c
> > +@@ -106,8 +106,6 @@ const int ABORT_INTERVAL = 100; // ms
> > + /// Run/record forever
> > + #define WAIT_METHOD_FOREVER 4
> > +
> > +-extern FILE *stderr, *stdout;
> > +-
> > + int mmal_status_to_int(MMAL_STATUS_T status);
> > + static void signal_handler(int signal_number);
> > +
> > +--
> > +1.9.1
> > +
> >
>
>
> --
> Arnout Vandecappelle arnout at mind be
> Senior Embedded Software Architect +32-16-286500
> Essensium/Mind http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20151127/84aab774/attachment.html>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-27 21:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-27 17:37 [Buildroot] [PATCH] rpi-userland: fix musl compile Sergio Prado
2015-11-27 18:30 ` Peter Korsgaard
2015-11-27 20:50 ` Arnout Vandecappelle
2015-11-27 21:31 ` Sergio Prado
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox