[Buildroot] [PATCH v2] sbc: new package

[Buildroot] [PATCH v2] sbc: new package

[gustavo.zacarias at free-electrons.com]

From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>

Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
---
 package/Config.in     |  1 +
 package/sbc/Config.in |  8 ++++++++
 package/sbc/sbc.hash  |  2 ++
 package/sbc/sbc.mk    | 15 +++++++++++++++
 4 files changed, 26 insertions(+)
 create mode 100644 package/sbc/Config.in
 create mode 100644 package/sbc/sbc.hash
 create mode 100644 package/sbc/sbc.mk

diff --git a/package/Config.in b/package/Config.in
index 1ab5133..1c7c64b 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -739,6 +739,7 @@ menu "Audio/Sound"
 	source "package/opus/Config.in"
 	source "package/opusfile/Config.in"
 	source "package/portaudio/Config.in"
+	source "package/sbc/Config.in"
 	source "package/speex/Config.in"
 	source "package/taglib/Config.in"
 	source "package/tinyalsa/Config.in"
diff --git a/package/sbc/Config.in b/package/sbc/Config.in
new file mode 100644
index 0000000..f1dbc0e
--- /dev/null
+++ b/package/sbc/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_SBC
+	bool "sbc"
+	select BR2_PACKAGE_LIBSNDFILE
+	help
+	  An audio codec to connect bluetooth high quality audio
+	  devices like headphones or loudspeakers.
+
+	  http://www.bluez.org/
diff --git a/package/sbc/sbc.hash b/package/sbc/sbc.hash
new file mode 100644
index 0000000..be3c8f7
--- /dev/null
+++ b/package/sbc/sbc.hash
@@ -0,0 +1,2 @@
+# From https://www.kernel.org/pub/linux/bluetooth/sha256sums.asc
+sha256	e61022cf576f14190241e7071753fdacdce5d1dea89ffd704110fc50be689309	sbc-1.3.tar.xz
diff --git a/package/sbc/sbc.mk b/package/sbc/sbc.mk
new file mode 100644
index 0000000..60ebc74
--- /dev/null
+++ b/package/sbc/sbc.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# sbc
+#
+################################################################################
+
+SBC_VERSION = 1.3
+SBC_SOURCE = sbc-$(SBC_VERSION).tar.xz
+SBC_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth
+SBC_INSTALL_STAGING = YES
+SBC_DEPENDENCIES = libsndfile host-pkgconf
+SBC_LICENSE = GPLv2+ (programs), LGPLv2.1+ (library)
+SBC_LICENSE_FILES = COPYING COPYING.LIB
+
+$(eval $(autotools-package))
-- 
2.4.10

[Buildroot] [PATCH v2] sbc: new package

[Vicente Olivert Riera]

Dear Gustavo Zacarias,

On 14/12/15 11:29, gustavo.zacarias at free-electrons.com wrote:
> From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
> 
> Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
> ---

I was expecting some sort of changelog here, as the manual says:

"21.5.2. Patch revision changelog

When improvements are requested, the new revision of each commit should
include a changelog of the modifications between each submission."

>  package/Config.in     |  1 +
>  package/sbc/Config.in |  8 ++++++++
>  package/sbc/sbc.hash  |  2 ++
>  package/sbc/sbc.mk    | 15 +++++++++++++++
>  4 files changed, 26 insertions(+)
>  create mode 100644 package/sbc/Config.in
>  create mode 100644 package/sbc/sbc.hash
>  create mode 100644 package/sbc/sbc.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 1ab5133..1c7c64b 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -739,6 +739,7 @@ menu "Audio/Sound"
>  	source "package/opus/Config.in"
>  	source "package/opusfile/Config.in"
>  	source "package/portaudio/Config.in"
> +	source "package/sbc/Config.in"
>  	source "package/speex/Config.in"
>  	source "package/taglib/Config.in"
>  	source "package/tinyalsa/Config.in"
> diff --git a/package/sbc/Config.in b/package/sbc/Config.in
> new file mode 100644
> index 0000000..f1dbc0e
> --- /dev/null
> +++ b/package/sbc/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_SBC
> +	bool "sbc"
> +	select BR2_PACKAGE_LIBSNDFILE
> +	help
> +	  An audio codec to connect bluetooth high quality audio
> +	  devices like headphones or loudspeakers.

The "devices" word fits in the first line.

Apart from that, everything looks OK to me, so...

Reviewed-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Tested-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

Build test for MIPS architecture:

$ file output/target/usr/lib/libsbc.so.1.2.1
output/target/usr/lib/libsbc.so.1.2.1: ELF 32-bit LSB shared object,
MIPS, MIPS32 rel2 version 1 (SYSV), dynamically linked, stripped

Regards,

Vincent.

[Buildroot] [PATCH v2] sbc: new package

[Gustavo Zacarias]

On 14/12/15 09:02, Vicente Olivert Riera wrote:

> Dear Gustavo Zacarias,
>
> On 14/12/15 11:29, gustavo.zacarias at free-electrons.com wrote:
>> From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
>>
>> Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
>> ---
>
> I was expecting some sort of changelog here, as the manual says:
>
> "21.5.2. Patch revision changelog
>
> When improvements are requested, the new revision of each commit should
> include a changelog of the modifications between each submission."

Hi.
It was lost in the shuffle, it's just the licensing style change.
Regards.

[Buildroot] [PATCH v2] sbc: new package

[Thomas Petazzoni]

Gustavo,

On Mon, 14 Dec 2015 08:29:44 -0300, gustavo.zacarias at free-electrons.com
wrote:
> From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
> 
> Signed-off-by: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
> ---
>  package/Config.in     |  1 +
>  package/sbc/Config.in |  8 ++++++++
>  package/sbc/sbc.hash  |  2 ++
>  package/sbc/sbc.mk    | 15 +++++++++++++++
>  4 files changed, 26 insertions(+)
>  create mode 100644 package/sbc/Config.in
>  create mode 100644 package/sbc/sbc.hash
>  create mode 100644 package/sbc/sbc.mk

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com