* [Buildroot] [PATCH] gnutls: needs argp-standalone for musl/uclibc
@ 2015-12-04 17:01 Gustavo Zacarias
2015-12-04 20:38 ` Peter Korsgaard
2015-12-13 21:32 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Gustavo Zacarias @ 2015-12-04 17:01 UTC (permalink / raw)
To: buildroot
It's required for crywrap (tools), fixes:
http://autobuild.buildroot.net/results/2d9/2d98fced7ff7c3b5c39a97eb1c8db7dd651fa86c/
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
package/gnutls/Config.in | 2 ++
package/gnutls/gnutls.mk | 6 ++++++
2 files changed, 8 insertions(+)
diff --git a/package/gnutls/Config.in b/package/gnutls/Config.in
index dde23ce..998e213 100644
--- a/package/gnutls/Config.in
+++ b/package/gnutls/Config.in
@@ -14,6 +14,8 @@ if BR2_PACKAGE_GNUTLS
config BR2_PACKAGE_GNUTLS_TOOLS
bool "install tools"
+ select BR2_PACKAGE_ARGP_STANDALONE \
+ if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL
help
Install GnuTLS command line tools for various cryptographic tasks.
diff --git a/package/gnutls/gnutls.mk b/package/gnutls/gnutls.mk
index 3b9fc7f..a7342d6 100644
--- a/package/gnutls/gnutls.mk
+++ b/package/gnutls/gnutls.mk
@@ -44,6 +44,12 @@ ifeq ($(BR2_PACKAGE_GNUTLS_TOOLS),)
GNUTLS_CONF_OPTS += --disable-crywrap
endif
+# Prerequisite for crywrap
+ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
+GNUTLS_CONF_ENV += LIBS="-largp"
+GNUTLS_DEPENDENCIES += argp-standalone
+endif
+
# libidn support for nommu must exclude the crywrap wrapper (uses fork)
GNUTLS_CONF_OPTS += $(if $(BR2_USE_MMU),,--disable-crywrap)
--
2.4.10
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] gnutls: needs argp-standalone for musl/uclibc
2015-12-04 17:01 [Buildroot] [PATCH] gnutls: needs argp-standalone for musl/uclibc Gustavo Zacarias
@ 2015-12-04 20:38 ` Peter Korsgaard
2015-12-13 21:32 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2015-12-04 20:38 UTC (permalink / raw)
To: buildroot
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:
> It's required for crywrap (tools), fixes:
> http://autobuild.buildroot.net/results/2d9/2d98fced7ff7c3b5c39a97eb1c8db7dd651fa86c/
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] gnutls: needs argp-standalone for musl/uclibc
2015-12-04 17:01 [Buildroot] [PATCH] gnutls: needs argp-standalone for musl/uclibc Gustavo Zacarias
2015-12-04 20:38 ` Peter Korsgaard
@ 2015-12-13 21:32 ` Thomas Petazzoni
2015-12-14 17:16 ` Gustavo Zacarias
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2015-12-13 21:32 UTC (permalink / raw)
To: buildroot
Gustavo,
On Fri, 4 Dec 2015 14:01:39 -0300, Gustavo Zacarias wrote:
> diff --git a/package/gnutls/Config.in b/package/gnutls/Config.in
> index dde23ce..998e213 100644
> --- a/package/gnutls/Config.in
> +++ b/package/gnutls/Config.in
> @@ -14,6 +14,8 @@ if BR2_PACKAGE_GNUTLS
>
> config BR2_PACKAGE_GNUTLS_TOOLS
> bool "install tools"
> + select BR2_PACKAGE_ARGP_STANDALONE \
> + if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL
> help
> Install GnuTLS command line tools for various cryptographic tasks.
Seems like BR2_PACKAGE_GNUTLS needs argp.h as well, not only
BR2_PACKAGE_GNUTLS_TOOLS. See
http://autobuild.buildroot.org/results/d86/d8604fe448bb11395e8443726d09b041eb34c6d5//.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] gnutls: needs argp-standalone for musl/uclibc
2015-12-13 21:32 ` Thomas Petazzoni
@ 2015-12-14 17:16 ` Gustavo Zacarias
2015-12-14 20:05 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Gustavo Zacarias @ 2015-12-14 17:16 UTC (permalink / raw)
To: buildroot
On 13/12/15 18:32, Thomas Petazzoni wrote:
>> config BR2_PACKAGE_GNUTLS_TOOLS
>> bool "install tools"
>> + select BR2_PACKAGE_ARGP_STANDALONE \
>> + if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL
>> help
>> Install GnuTLS command line tools for various cryptographic tasks.
>
> Seems like BR2_PACKAGE_GNUTLS needs argp.h as well, not only
> BR2_PACKAGE_GNUTLS_TOOLS. See
> http://autobuild.buildroot.org/results/d86/d8604fe448bb11395e8443726d09b041eb34c6d5//.
Hi.
It's still crywrap failing, hence tools.
Probably --disable-crywrap isn't doing it's job efficently, i'll take a
look.
Regards.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] gnutls: needs argp-standalone for musl/uclibc
2015-12-14 17:16 ` Gustavo Zacarias
@ 2015-12-14 20:05 ` Thomas Petazzoni
2015-12-14 20:08 ` Gustavo Zacarias
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2015-12-14 20:05 UTC (permalink / raw)
To: buildroot
Dear Gustavo Zacarias,
On Mon, 14 Dec 2015 14:16:01 -0300, Gustavo Zacarias wrote:
> On 13/12/15 18:32, Thomas Petazzoni wrote:
>
> >> config BR2_PACKAGE_GNUTLS_TOOLS
> >> bool "install tools"
> >> + select BR2_PACKAGE_ARGP_STANDALONE \
> >> + if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL
> >> help
> >> Install GnuTLS command line tools for various cryptographic tasks.
> >
> > Seems like BR2_PACKAGE_GNUTLS needs argp.h as well, not only
> > BR2_PACKAGE_GNUTLS_TOOLS. See
> > http://autobuild.buildroot.org/results/d86/d8604fe448bb11395e8443726d09b041eb34c6d5//.
>
> Hi.
> It's still crywrap failing, hence tools.
Well the failing config I'm pointing to has BR2_PACKAGE_GNUTLS_TOOLS
disabled, but BR2_PACKAGE_GNUTLS enabled.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] gnutls: needs argp-standalone for musl/uclibc
2015-12-14 20:05 ` Thomas Petazzoni
@ 2015-12-14 20:08 ` Gustavo Zacarias
0 siblings, 0 replies; 6+ messages in thread
From: Gustavo Zacarias @ 2015-12-14 20:08 UTC (permalink / raw)
To: buildroot
On 14/12/15 17:05, Thomas Petazzoni wrote:
>> Hi.
>> It's still crywrap failing, hence tools.
>
> Well the failing config I'm pointing to has BR2_PACKAGE_GNUTLS_TOOLS
> disabled, but BR2_PACKAGE_GNUTLS enabled.
>
> Thomas
crywrap isn't part of tools in the gnutls sense, it's only so in the
buildroot package sense/option.
Essentially --disable-crywrap is a no-op in gnutls, that's what the
patch fixes, so it was never disabled.
Regards.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-12-14 20:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-04 17:01 [Buildroot] [PATCH] gnutls: needs argp-standalone for musl/uclibc Gustavo Zacarias
2015-12-04 20:38 ` Peter Korsgaard
2015-12-13 21:32 ` Thomas Petazzoni
2015-12-14 17:16 ` Gustavo Zacarias
2015-12-14 20:05 ` Thomas Petazzoni
2015-12-14 20:08 ` Gustavo Zacarias
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox