Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] New package RPi-GPIO
@ 2016-01-02 11:59 Ian Haylock
  2016-01-02 11:59 ` [Buildroot] [PATCH 2/2] " Ian Haylock
  0 siblings, 1 reply; 4+ messages in thread
From: Ian Haylock @ 2016-01-02 11:59 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Ian Haylock <haylocki@yahoo.co.uk>
---
 package/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/Config.in b/package/Config.in
index f58f2be..4051251 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -690,6 +690,7 @@ menu "External python modules"
 	source "package/python-pyyaml/Config.in"
 	source "package/python-pyzmq/Config.in"
 	source "package/python-requests/Config.in"
+	source "package/python-rpi-gpio/Config.in"
 	source "package/python-rtslib-fb/Config.in"
 	source "package/python-serial/Config.in"
 	source "package/python-setuptools/Config.in"
-- 
2.6.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] New package RPi-GPIO
  2016-01-02 11:59 [Buildroot] [PATCH 1/2] New package RPi-GPIO Ian Haylock
@ 2016-01-02 11:59 ` Ian Haylock
  2016-01-02 18:10   ` Yegor Yefremov
  2016-01-02 21:18   ` Arnout Vandecappelle
  0 siblings, 2 replies; 4+ messages in thread
From: Ian Haylock @ 2016-01-02 11:59 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Ian Haylock <haylocki@yahoo.co.uk>
---
 package/python-rpi-gpio/Config.in            |  9 +++++++++
 package/python-rpi-gpio/python-rpi-gpio.hash |  4 ++++
 package/python-rpi-gpio/python-rpi-gpio.mk   | 14 ++++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100755 package/python-rpi-gpio/Config.in
 create mode 100755 package/python-rpi-gpio/python-rpi-gpio.hash
 create mode 100755 package/python-rpi-gpio/python-rpi-gpio.mk

diff --git a/package/python-rpi-gpio/Config.in b/package/python-rpi-gpio/Config.in
new file mode 100755
index 0000000..da5b8c2
--- /dev/null
+++ b/package/python-rpi-gpio/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_PYTHON_RPI_GPIO
+        bool "python-rpi-gpio"
+	depends on BR2_arm
+	depends on BR2_PACKAGE_PYTHON
+
+        help
+          A Python module to control the GPIO on a Raspberry Pi.
+
+          http://sourceforge.net/p/raspberry-gpio-python
\ No newline at end of file
diff --git a/package/python-rpi-gpio/python-rpi-gpio.hash b/package/python-rpi-gpio/python-rpi-gpio.hash
new file mode 100755
index 0000000..b234396
--- /dev/null
+++ b/package/python-rpi-gpio/python-rpi-gpio.hash
@@ -0,0 +1,4 @@
+md5	a98d0b33e16fce3f303136e963b187ec	RPi.GPIO-0.5.11.tar.gz
+
+
+
diff --git a/package/python-rpi-gpio/python-rpi-gpio.mk b/package/python-rpi-gpio/python-rpi-gpio.mk
new file mode 100755
index 0000000..efad0f3
--- /dev/null
+++ b/package/python-rpi-gpio/python-rpi-gpio.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# python-rpi-gpio
+#
+################################################################################
+
+PYTHON_RPI_GPIO_VERSION = 0.5.11
+PYTHON_RPI_GPIO_SOURCE = RPi.GPIO-$(PYTHON_RPI_GPIO_VERSION).tar.gz
+PYTHON_RPI_GPIO_SITE = http://sourceforge.net/projects/raspberry-gpio-python/files
+PYTHON_RPI_GPIO_LICENSE = MIT
+PYTHON_RPI_GPIO_LICENSE_FILES = LICENSE.txt
+PYTHON_RPI_GPIO_SETUP_TYPE = distutils
+
+$(eval $(python-package))
\ No newline at end of file
-- 
2.6.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] New package RPi-GPIO
  2016-01-02 11:59 ` [Buildroot] [PATCH 2/2] " Ian Haylock
@ 2016-01-02 18:10   ` Yegor Yefremov
  2016-01-02 21:18   ` Arnout Vandecappelle
  1 sibling, 0 replies; 4+ messages in thread
From: Yegor Yefremov @ 2016-01-02 18:10 UTC (permalink / raw)
  To: buildroot

Hello Ian,

could you please squash these two patches into one?

The patch title should be

python-rpi-gpio: new package

On Sat, Jan 2, 2016 at 12:59 PM, Ian Haylock <haylocki@yahoo.co.uk> wrote:
> Signed-off-by: Ian Haylock <haylocki@yahoo.co.uk>
> ---
>  package/python-rpi-gpio/Config.in            |  9 +++++++++
>  package/python-rpi-gpio/python-rpi-gpio.hash |  4 ++++
>  package/python-rpi-gpio/python-rpi-gpio.mk   | 14 ++++++++++++++
>  3 files changed, 27 insertions(+)
>  create mode 100755 package/python-rpi-gpio/Config.in
>  create mode 100755 package/python-rpi-gpio/python-rpi-gpio.hash
>  create mode 100755 package/python-rpi-gpio/python-rpi-gpio.mk
>
> diff --git a/package/python-rpi-gpio/Config.in b/package/python-rpi-gpio/Config.in
> new file mode 100755
> index 0000000..da5b8c2
> --- /dev/null
> +++ b/package/python-rpi-gpio/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_PYTHON_RPI_GPIO
> +        bool "python-rpi-gpio"
> +       depends on BR2_arm
> +       depends on BR2_PACKAGE_PYTHON
> +
> +        help
> +          A Python module to control the GPIO on a Raspberry Pi.
> +
> +          http://sourceforge.net/p/raspberry-gpio-python
> \ No newline at end of file
> diff --git a/package/python-rpi-gpio/python-rpi-gpio.hash b/package/python-rpi-gpio/python-rpi-gpio.hash
> new file mode 100755
> index 0000000..b234396
> --- /dev/null
> +++ b/package/python-rpi-gpio/python-rpi-gpio.hash
> @@ -0,0 +1,4 @@
> +md5    a98d0b33e16fce3f303136e963b187ec        RPi.GPIO-0.5.11.tar.gz

Could you please name the origin of this MD5 checksum? We also add
locally calculated sha256 checksum.  See package/python-pyudev package
for example.

> +
> +
> +
> diff --git a/package/python-rpi-gpio/python-rpi-gpio.mk b/package/python-rpi-gpio/python-rpi-gpio.mk
> new file mode 100755
> index 0000000..efad0f3
> --- /dev/null
> +++ b/package/python-rpi-gpio/python-rpi-gpio.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# python-rpi-gpio
> +#
> +################################################################################
> +
> +PYTHON_RPI_GPIO_VERSION = 0.5.11
> +PYTHON_RPI_GPIO_SOURCE = RPi.GPIO-$(PYTHON_RPI_GPIO_VERSION).tar.gz
> +PYTHON_RPI_GPIO_SITE = http://sourceforge.net/projects/raspberry-gpio-python/files
> +PYTHON_RPI_GPIO_LICENSE = MIT
> +PYTHON_RPI_GPIO_LICENSE_FILES = LICENSE.txt
> +PYTHON_RPI_GPIO_SETUP_TYPE = distutils
> +
> +$(eval $(python-package))
> \ No newline at end of file
> --
> 2.6.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] New package RPi-GPIO
  2016-01-02 11:59 ` [Buildroot] [PATCH 2/2] " Ian Haylock
  2016-01-02 18:10   ` Yegor Yefremov
@ 2016-01-02 21:18   ` Arnout Vandecappelle
  1 sibling, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2016-01-02 21:18 UTC (permalink / raw)
  To: buildroot

 Hi Ian,

 In addition to Yegor's comments, a few more things below.

On 02-01-16 12:59, Ian Haylock wrote:
> Signed-off-by: Ian Haylock <haylocki@yahoo.co.uk>
> ---
>  package/python-rpi-gpio/Config.in            |  9 +++++++++
>  package/python-rpi-gpio/python-rpi-gpio.hash |  4 ++++
>  package/python-rpi-gpio/python-rpi-gpio.mk   | 14 ++++++++++++++
>  3 files changed, 27 insertions(+)
>  create mode 100755 package/python-rpi-gpio/Config.in
>  create mode 100755 package/python-rpi-gpio/python-rpi-gpio.hash
>  create mode 100755 package/python-rpi-gpio/python-rpi-gpio.mk

 These files should not be executable.

> 
> diff --git a/package/python-rpi-gpio/Config.in b/package/python-rpi-gpio/Config.in
> new file mode 100755
> index 0000000..da5b8c2
> --- /dev/null
> +++ b/package/python-rpi-gpio/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_PYTHON_RPI_GPIO
> +        bool "python-rpi-gpio"

 Indentation should be a single tab.

> +	depends on BR2_arm
> +	depends on BR2_PACKAGE_PYTHON
> +
> +        help

 Here as well.

> +          A Python module to control the GPIO on a Raspberry Pi.

 And here one tab followed by two spaces.

> +
> +          http://sourceforge.net/p/raspberry-gpio-python
> \ No newline at end of file

 There should be a newline at the end of the file (not an empty line, but the
last character should be \n).

> diff --git a/package/python-rpi-gpio/python-rpi-gpio.hash b/package/python-rpi-gpio/python-rpi-gpio.hash
> new file mode 100755
> index 0000000..b234396
> --- /dev/null
> +++ b/package/python-rpi-gpio/python-rpi-gpio.hash
> @@ -0,0 +1,4 @@
> +md5	a98d0b33e16fce3f303136e963b187ec	RPi.GPIO-0.5.11.tar.gz
> +
> +
> +

 There shouldn't be any empty lines here.

> diff --git a/package/python-rpi-gpio/python-rpi-gpio.mk b/package/python-rpi-gpio/python-rpi-gpio.mk
> new file mode 100755
> index 0000000..efad0f3
> --- /dev/null
> +++ b/package/python-rpi-gpio/python-rpi-gpio.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# python-rpi-gpio
> +#
> +################################################################################
> +
> +PYTHON_RPI_GPIO_VERSION = 0.5.11
> +PYTHON_RPI_GPIO_SOURCE = RPi.GPIO-$(PYTHON_RPI_GPIO_VERSION).tar.gz
> +PYTHON_RPI_GPIO_SITE = http://sourceforge.net/projects/raspberry-gpio-python/files
> +PYTHON_RPI_GPIO_LICENSE = MIT
> +PYTHON_RPI_GPIO_LICENSE_FILES = LICENSE.txt
> +PYTHON_RPI_GPIO_SETUP_TYPE = distutils
> +
> +$(eval $(python-package))
> \ No newline at end of file

 There should be a newline here as well.


 Regards,
 Arnout

> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-01-02 21:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-02 11:59 [Buildroot] [PATCH 1/2] New package RPi-GPIO Ian Haylock
2016-01-02 11:59 ` [Buildroot] [PATCH 2/2] " Ian Haylock
2016-01-02 18:10   ` Yegor Yefremov
2016-01-02 21:18   ` Arnout Vandecappelle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox