Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH trivial] uboot: remove unused helper function insert_define
@ 2016-01-06 13:33 Thomas De Schampheleire
  2016-01-08 23:44 ` Arnout Vandecappelle
  2016-01-18  9:11 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas De Schampheleire @ 2016-01-06 13:33 UTC (permalink / raw)
  To: buildroot

From: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

Commit 16b8e813c810fde2fe3655c696edf1e76a7d27ba removed all remaining users
of helper function insert_define.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
 boot/uboot/uboot.mk | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
index c8c50f0..d539b31 100644
--- a/boot/uboot/uboot.mk
+++ b/boot/uboot/uboot.mk
@@ -89,18 +89,6 @@ ifeq ($(BR2_TARGET_UBOOT_NEEDS_DTC),y)
 UBOOT_DEPENDENCIES += host-dtc
 endif
 
-# Helper function to fill the U-Boot config.h file.
-# Argument 1: option name
-# Argument 2: option value
-# If the option value is empty, this function does nothing.
-define insert_define
-$(if $(call qstrip,$(2)),
-	@echo "#ifdef $(strip $(1))" >> $(@D)/include/config.h
-	@echo "#undef $(strip $(1))" >> $(@D)/include/config.h
-	@echo "#endif" >> $(@D)/include/config.h
-	@echo '#define $(strip $(1)) $(call qstrip,$(2))' >> $(@D)/include/config.h)
-endef
-
 # prior to u-boot 2013.10 the license info was in COPYING. Copy it so
 # legal-info finds it
 define UBOOT_COPY_OLD_LICENSE_FILE
-- 
1.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH trivial] uboot: remove unused helper function insert_define
  2016-01-06 13:33 [Buildroot] [PATCH trivial] uboot: remove unused helper function insert_define Thomas De Schampheleire
@ 2016-01-08 23:44 ` Arnout Vandecappelle
  2016-01-18  9:11 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2016-01-08 23:44 UTC (permalink / raw)
  To: buildroot

On 06-01-16 14:33, Thomas De Schampheleire wrote:
> From: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
> 
> Commit 16b8e813c810fde2fe3655c696edf1e76a7d27ba removed all remaining users
> of helper function insert_define.
> 
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>


 Regards,
 Arnout

> ---
>  boot/uboot/uboot.mk | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> index c8c50f0..d539b31 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -89,18 +89,6 @@ ifeq ($(BR2_TARGET_UBOOT_NEEDS_DTC),y)
>  UBOOT_DEPENDENCIES += host-dtc
>  endif
>  
> -# Helper function to fill the U-Boot config.h file.
> -# Argument 1: option name
> -# Argument 2: option value
> -# If the option value is empty, this function does nothing.
> -define insert_define
> -$(if $(call qstrip,$(2)),
> -	@echo "#ifdef $(strip $(1))" >> $(@D)/include/config.h
> -	@echo "#undef $(strip $(1))" >> $(@D)/include/config.h
> -	@echo "#endif" >> $(@D)/include/config.h
> -	@echo '#define $(strip $(1)) $(call qstrip,$(2))' >> $(@D)/include/config.h)
> -endef
> -
>  # prior to u-boot 2013.10 the license info was in COPYING. Copy it so
>  # legal-info finds it
>  define UBOOT_COPY_OLD_LICENSE_FILE
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH trivial] uboot: remove unused helper function insert_define
  2016-01-06 13:33 [Buildroot] [PATCH trivial] uboot: remove unused helper function insert_define Thomas De Schampheleire
  2016-01-08 23:44 ` Arnout Vandecappelle
@ 2016-01-18  9:11 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2016-01-18  9:11 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:

 > From: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
 > Commit 16b8e813c810fde2fe3655c696edf1e76a7d27ba removed all remaining users
 > of helper function insert_define.

 > Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-01-18  9:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-06 13:33 [Buildroot] [PATCH trivial] uboot: remove unused helper function insert_define Thomas De Schampheleire
2016-01-08 23:44 ` Arnout Vandecappelle
2016-01-18  9:11 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox