[Buildroot] [PATCH v2] package/libbroadvoice: Broken on BR2_arc with gcc <= 4.8

[Buildroot] [PATCH v2] package/libbroadvoice: Broken on BR2_arc with gcc <= 4.8

[Bernd Kuhls]

Please read this bug report for details:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59049

Fixes
http://autobuild.buildroot.net/results/4a1/4a1fd92d1ce4963d3e282ea2dc8f0f6c5db4f1e1/
http://autobuild.buildroot.net/results/ce3/ce3be7d27489647a98d8932c5bcabd08c845187b/
http://autobuild.buildroot.net/results/988/988bd189bab37a03c037160d6758774d4aa6c8a0/
and many others

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
v2: changed logic to "material implication" (Arnout, Mason)

 package/libbroadvoice/Config.in | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/libbroadvoice/Config.in b/package/libbroadvoice/Config.in
index d695df0..3301ba8 100644
--- a/package/libbroadvoice/Config.in
+++ b/package/libbroadvoice/Config.in
@@ -1,5 +1,8 @@
 config BR2_PACKAGE_LIBBROADVOICE
 	bool "libbroadvoice"
+	# broken with gcc <= 4.8 on arc
+	# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59049
+	depends on !BR2_arc || BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
 	help
 	  broadvoice - a library for the BroadVoice 16 and 32 speech
 	  codecs
-- 
2.7.0.rc3

[Buildroot] [PATCH v2] package/libbroadvoice: Broken on BR2_arc with gcc <= 4.8

[Thomas Petazzoni]

Bernd,

On Sun, 17 Jan 2016 14:53:16 +0100, Bernd Kuhls wrote:

> diff --git a/package/libbroadvoice/Config.in b/package/libbroadvoice/Config.in
> index d695df0..3301ba8 100644
> --- a/package/libbroadvoice/Config.in
> +++ b/package/libbroadvoice/Config.in
> @@ -1,5 +1,8 @@
>  config BR2_PACKAGE_LIBBROADVOICE
>  	bool "libbroadvoice"
> +	# broken with gcc <= 4.8 on arc
> +	# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59049
> +	depends on !BR2_arc || BR2_TOOLCHAIN_GCC_AT_LEAST_4_9

If the bug affects gcc 4.8, and ARC currently uses gcc 4.8, why do you
need the "!BR2_arc" part of the condition ?

Doing:

	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9

is sufficient, and will ensure that this package will be built again
once ARC is moved to a gcc 4.9 based toolchain.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v2] package/libbroadvoice: Broken on BR2_arc with gcc <= 4.8

[Bernd Kuhls]

Am Sun, 17 Jan 2016 15:38:06 +0100 schrieb Thomas Petazzoni:

> If the bug affects gcc 4.8, and ARC currently uses gcc 4.8, why do you
> need the "!BR2_arc" part of the condition ?
> 
> Doing:
> 
> 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> 
> is sufficient, and will ensure that this package will be built again
> once ARC is moved to a gcc 4.9 based toolchain.

Hi Thomas,

libbroadvoice will compile with gcc 4.8 or older on all archs except arc, 
the gcc bug exists only on arc.

Regards, Bernd

[Buildroot] [PATCH v2] package/libbroadvoice: Broken on BR2_arc with gcc <= 4.8

[Arnout Vandecappelle]

On 17-01-16 14:53, Bernd Kuhls wrote:
> Please read this bug report for details:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59049
> 
> Fixes
> http://autobuild.buildroot.net/results/4a1/4a1fd92d1ce4963d3e282ea2dc8f0f6c5db4f1e1/
> http://autobuild.buildroot.net/results/ce3/ce3be7d27489647a98d8932c5bcabd08c845187b/
> http://autobuild.buildroot.net/results/988/988bd189bab37a03c037160d6758774d4aa6c8a0/
> and many others
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 ThomasP: this really is the intended condition.

 Note that we could add a comment saying that it needs gcc 4.9 on ARC, but that
would be pointless since you can't currently select gcc 4.9 on ARC...

 Regards,
 Arnout


> ---
> v2: changed logic to "material implication" (Arnout, Mason)
> 
>  package/libbroadvoice/Config.in | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/libbroadvoice/Config.in b/package/libbroadvoice/Config.in
> index d695df0..3301ba8 100644
> --- a/package/libbroadvoice/Config.in
> +++ b/package/libbroadvoice/Config.in
> @@ -1,5 +1,8 @@
>  config BR2_PACKAGE_LIBBROADVOICE
>  	bool "libbroadvoice"
> +	# broken with gcc <= 4.8 on arc
> +	# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59049
> +	depends on !BR2_arc || BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
>  	help
>  	  broadvoice - a library for the BroadVoice 16 and 32 speech
>  	  codecs
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH v2] package/libbroadvoice: Broken on BR2_arc with gcc <= 4.8

[Thomas Petazzoni]

Dear Bernd Kuhls,

On Sun, 17 Jan 2016 14:53:16 +0100, Bernd Kuhls wrote:
> Please read this bug report for details:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59049
> 
> Fixes
> http://autobuild.buildroot.net/results/4a1/4a1fd92d1ce4963d3e282ea2dc8f0f6c5db4f1e1/
> http://autobuild.buildroot.net/results/ce3/ce3be7d27489647a98d8932c5bcabd08c845187b/
> http://autobuild.buildroot.net/results/988/988bd189bab37a03c037160d6758774d4aa6c8a0/
> and many others
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> v2: changed logic to "material implication" (Arnout, Mason)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com