Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] uclibc: fix MIPS builds with disabled threads
@ 2016-02-05  6:34 Waldemar Brodkorb
  2016-02-05 13:02 ` Gustavo Zacarias
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Waldemar Brodkorb @ 2016-02-05  6:34 UTC (permalink / raw)
  To: buildroot

There was a regression found while building for MIPS
with disabled threads. Upstream patch fixed it.

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 ...02-mips-fix-build-if-threads-are-disabled.patch |   59 ++++++++++++++++++++
 1 file changed, 59 insertions(+)
 create mode 100644 package/uclibc/0002-mips-fix-build-if-threads-are-disabled.patch

diff --git a/package/uclibc/0002-mips-fix-build-if-threads-are-disabled.patch b/package/uclibc/0002-mips-fix-build-if-threads-are-disabled.patch
new file mode 100644
index 0000000..a74a5f9
--- /dev/null
+++ b/package/uclibc/0002-mips-fix-build-if-threads-are-disabled.patch
@@ -0,0 +1,59 @@
+From b499fe614ac5b492fc0fdc6e1fbbeeb904674159 Mon Sep 17 00:00:00 2001
+From: Waldemar Brodkorb <wbx@uclibc-ng.org>
+Date: Wed, 3 Feb 2016 21:57:04 +0100
+Subject: [PATCH] mips: fix build if threads are disabled
+
+Reported-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
+Signed-off-by: Waldemar Brodkorb <wbx@uclibc-ng.org>
+---
+ libc/string/mips/memcpy.S |    4 ++--
+ libc/string/mips/memset.S |    4 ++--
+ 2 files changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/libc/string/mips/memcpy.S b/libc/string/mips/memcpy.S
+index 3afdb2c..59f9f0a 100644
+--- a/libc/string/mips/memcpy.S
++++ b/libc/string/mips/memcpy.S
+@@ -23,7 +23,7 @@
+ # define PREFETCH_STORE_HINT PREFETCH_HINT_PREPAREFORSTORE
+ #elif _LIBC
+ # include <sysdep.h>
+-# include <regdef.h>
++# include <sys/regdef.h>
+ # include <sys/asm.h>
+ # define PREFETCH_LOAD_HINT PREFETCH_HINT_LOAD_STREAMED
+ # define PREFETCH_STORE_HINT PREFETCH_HINT_PREPAREFORSTORE
+@@ -33,7 +33,7 @@
+ # define PREFETCH_LOAD_HINT PREFETCH_HINT_LOAD_STREAMED
+ # define PREFETCH_STORE_HINT PREFETCH_HINT_PREPAREFORSTORE
+ #else
+-# include <regdef.h>
++# include <sys/regdef.h>
+ # include <sys/asm.h>
+ #endif
+ 
+diff --git a/libc/string/mips/memset.S b/libc/string/mips/memset.S
+index ef8ab0b..43034ce 100644
+--- a/libc/string/mips/memset.S
++++ b/libc/string/mips/memset.S
+@@ -21,7 +21,7 @@
+ # define PREFETCH_STORE_HINT PREFETCH_HINT_PREPAREFORSTORE
+ #elif _LIBC
+ # include <sysdep.h>
+-# include <regdef.h>
++# include <sys/regdef.h>
+ # include <sys/asm.h>
+ # define PREFETCH_STORE_HINT PREFETCH_HINT_PREPAREFORSTORE
+ #elif defined _COMPILING_NEWLIB
+@@ -29,7 +29,7 @@
+ # include "machine/regdef.h"
+ # define PREFETCH_STORE_HINT PREFETCH_HINT_PREPAREFORSTORE
+ #else
+-# include <regdef.h>
++# include <sys/regdef.h>
+ # include <sys/asm.h>
+ #endif
+ 
+-- 
+1.7.10.4
+
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] uclibc: fix MIPS builds with disabled threads
  2016-02-05  6:34 [Buildroot] [PATCH] uclibc: fix MIPS builds with disabled threads Waldemar Brodkorb
@ 2016-02-05 13:02 ` Gustavo Zacarias
  2016-02-05 13:27 ` Vicente Olivert Riera
  2016-02-05 20:57 ` Thomas Petazzoni
  2 siblings, 0 replies; 4+ messages in thread
From: Gustavo Zacarias @ 2016-02-05 13:02 UTC (permalink / raw)
  To: buildroot

On 05/02/16 03:34, Waldemar Brodkorb wrote:

> There was a regression found while building for MIPS
> with disabled threads. Upstream patch fixed it.
>
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>

Acked-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] uclibc: fix MIPS builds with disabled threads
  2016-02-05  6:34 [Buildroot] [PATCH] uclibc: fix MIPS builds with disabled threads Waldemar Brodkorb
  2016-02-05 13:02 ` Gustavo Zacarias
@ 2016-02-05 13:27 ` Vicente Olivert Riera
  2016-02-05 20:57 ` Thomas Petazzoni
  2 siblings, 0 replies; 4+ messages in thread
From: Vicente Olivert Riera @ 2016-02-05 13:27 UTC (permalink / raw)
  To: buildroot

Dear Waldemar Brodkorb,

On 05/02/16 07:34, Waldemar Brodkorb wrote:
> There was a regression found while building for MIPS
> with disabled threads. Upstream patch fixed it.
>
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>

Reviewed-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Tested-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

Without the patch:

   AS libc/string/mips/memset.os
libc/string/mips/memset.S:24:21: fatal error: regdef.h: No such file or 
directory
  # include <regdef.h>
                      ^
compilation terminated.

With the patch:

$ file output/build/uclibc-1.0.12/.stamp_target_installed
output/build/uclibc-1.0.12/.stamp_target_installed: empty

Regards,

Vincent.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] uclibc: fix MIPS builds with disabled threads
  2016-02-05  6:34 [Buildroot] [PATCH] uclibc: fix MIPS builds with disabled threads Waldemar Brodkorb
  2016-02-05 13:02 ` Gustavo Zacarias
  2016-02-05 13:27 ` Vicente Olivert Riera
@ 2016-02-05 20:57 ` Thomas Petazzoni
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2016-02-05 20:57 UTC (permalink / raw)
  To: buildroot

Dear Waldemar Brodkorb,

On Fri, 5 Feb 2016 07:34:35 +0100, Waldemar Brodkorb wrote:
> There was a regression found while building for MIPS
> with disabled threads. Upstream patch fixed it.
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
>  ...02-mips-fix-build-if-threads-are-disabled.patch |   59 ++++++++++++++++++++
>  1 file changed, 59 insertions(+)
>  create mode 100644 package/uclibc/0002-mips-fix-build-if-threads-are-disabled.patch

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-02-05 20:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-05  6:34 [Buildroot] [PATCH] uclibc: fix MIPS builds with disabled threads Waldemar Brodkorb
2016-02-05 13:02 ` Gustavo Zacarias
2016-02-05 13:27 ` Vicente Olivert Riera
2016-02-05 20:57 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox