* [Buildroot] [PATCH 1/1] package/libarchive: add optional support for bzip2
2016-02-10 20:59 [Buildroot] [PATCH 1/1] package/gdb: add optional support for xz Bernd Kuhls
@ 2016-02-10 20:59 ` Bernd Kuhls
2016-02-10 21:19 ` Arnout Vandecappelle
2016-02-10 20:59 ` [Buildroot] [PATCH 1/1] package/tiff: add optional support for xz Bernd Kuhls
` (3 subsequent siblings)
4 siblings, 1 reply; 14+ messages in thread
From: Bernd Kuhls @ 2016-02-10 20:59 UTC (permalink / raw)
To: buildroot
When bzip2 was compiled before, libarchive will use it as optional
dependency:
$ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/lib/libarchive.so.13.1.2 | grep NEEDED
0x00000001 (NEEDED) Shared library: [liblzma.so.5]
0x00000001 (NEEDED) Shared library: [libbz2.so.1.0]
0x00000001 (NEEDED) Shared library: [libz.so.1]
0x00000001 (NEEDED) Shared library: [libc.so.1]
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/libarchive/libarchive.mk | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/package/libarchive/libarchive.mk b/package/libarchive/libarchive.mk
index 206de3f..f438d6e 100644
--- a/package/libarchive/libarchive.mk
+++ b/package/libarchive/libarchive.mk
@@ -42,6 +42,12 @@ else
LIBARCHIVE_CONF_OPTS += --disable-xattr
endif
+ifeq ($(BR2_PACKAGE_BZIP2),y)
+LIBARCHIVE_DEPENDENCIES += bzip2
+else
+LIBARCHIVE_CONF_OPTS += --without-bz2lib
+endif
+
ifeq ($(BR2_PACKAGE_EXPAT),y)
LIBARCHIVE_DEPENDENCIES += expat
else
--
2.7.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* [Buildroot] [PATCH 1/1] package/libarchive: add optional support for bzip2
2016-02-10 20:59 ` [Buildroot] [PATCH 1/1] package/libarchive: add optional support for bzip2 Bernd Kuhls
@ 2016-02-10 21:19 ` Arnout Vandecappelle
2016-02-16 22:15 ` Thomas Petazzoni
2016-02-20 13:49 ` Bernd Kuhls
0 siblings, 2 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2016-02-10 21:19 UTC (permalink / raw)
To: buildroot
On 10-02-16 21:59, Bernd Kuhls wrote:
> When bzip2 was compiled before, libarchive will use it as optional
> dependency:
>
> $ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/lib/libarchive.so.13.1.2 | grep NEEDED
> 0x00000001 (NEEDED) Shared library: [liblzma.so.5]
> 0x00000001 (NEEDED) Shared library: [libbz2.so.1.0]
> 0x00000001 (NEEDED) Shared library: [libz.so.1]
> 0x00000001 (NEEDED) Shared library: [libc.so.1]
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/libarchive/libarchive.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/package/libarchive/libarchive.mk b/package/libarchive/libarchive.mk
> index 206de3f..f438d6e 100644
> --- a/package/libarchive/libarchive.mk
> +++ b/package/libarchive/libarchive.mk
> @@ -42,6 +42,12 @@ else
> LIBARCHIVE_CONF_OPTS += --disable-xattr
> endif
>
> +ifeq ($(BR2_PACKAGE_BZIP2),y)
> +LIBARCHIVE_DEPENDENCIES += bzip2
No --with-bz2lib? If there is a good reason, mention it in the commit log.
Regards,
Arnout
> +else
> +LIBARCHIVE_CONF_OPTS += --without-bz2lib
> +endif
> +
> ifeq ($(BR2_PACKAGE_EXPAT),y)
> LIBARCHIVE_DEPENDENCIES += expat
> else
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 1/1] package/libarchive: add optional support for bzip2
2016-02-10 21:19 ` Arnout Vandecappelle
@ 2016-02-16 22:15 ` Thomas Petazzoni
2016-02-20 13:49 ` Bernd Kuhls
1 sibling, 0 replies; 14+ messages in thread
From: Thomas Petazzoni @ 2016-02-16 22:15 UTC (permalink / raw)
To: buildroot
Bernd,
On Wed, 10 Feb 2016 22:19:07 +0100, Arnout Vandecappelle wrote:
> > +ifeq ($(BR2_PACKAGE_BZIP2),y)
> > +LIBARCHIVE_DEPENDENCIES += bzip2
>
> No --with-bz2lib? If there is a good reason, mention it in the commit log.
Could you give some feedback on this?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 1/1] package/libarchive: add optional support for bzip2
2016-02-10 21:19 ` Arnout Vandecappelle
2016-02-16 22:15 ` Thomas Petazzoni
@ 2016-02-20 13:49 ` Bernd Kuhls
2016-02-20 23:45 ` Arnout Vandecappelle
1 sibling, 1 reply; 14+ messages in thread
From: Bernd Kuhls @ 2016-02-20 13:49 UTC (permalink / raw)
To: buildroot
Am Wed, 10 Feb 2016 22:19:07 +0100 schrieb Arnout Vandecappelle:
> No --with-bz2lib? If there is a good reason, mention it in the commit
> log.
Hi Arnout,
libarchive always checks for bzip2 unless --without-bz2lib is used:
https://github.com/libarchive/libarchive/blob/master/configure.ac#L300
Therefore I see no need for --with-bz2lib and I also should not have
added --with-lzma as well, I will send a patch removing it along with v2
of this patch explaining why --with-bz2lib is not needed.
Regards, Bernd
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 1/1] package/libarchive: add optional support for bzip2
2016-02-20 13:49 ` Bernd Kuhls
@ 2016-02-20 23:45 ` Arnout Vandecappelle
0 siblings, 0 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2016-02-20 23:45 UTC (permalink / raw)
To: buildroot
On 02/20/16 14:49, Bernd Kuhls wrote:
> Am Wed, 10 Feb 2016 22:19:07 +0100 schrieb Arnout Vandecappelle:
>
>> No --with-bz2lib? If there is a good reason, mention it in the commit
>> log.
>
> Hi Arnout,
>
> libarchive always checks for bzip2 unless --without-bz2lib is used:
> https://github.com/libarchive/libarchive/blob/master/configure.ac#L300
>
> Therefore I see no need for --with-bz2lib and I also should not have
> added --with-lzma as well, I will send a patch removing it along with v2
> of this patch explaining why --with-bz2lib is not needed.
We prefer to have both an explicit enable and disable (or with and without)
because:
- it makes it simpler in case the default changes after a version bump;
- it makes it easier for other people to understand that the right thing is done
(no need to check in configure what the default is);
- AFAIK the typical --enable/--with will give an error if the dependency is not
found, which gives an extra safety net;
- we do it like this in other places, it's nice to see the same pattern everywhere.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 1/1] package/tiff: add optional support for xz
2016-02-10 20:59 [Buildroot] [PATCH 1/1] package/gdb: add optional support for xz Bernd Kuhls
2016-02-10 20:59 ` [Buildroot] [PATCH 1/1] package/libarchive: add optional support for bzip2 Bernd Kuhls
@ 2016-02-10 20:59 ` Bernd Kuhls
2016-02-16 22:16 ` Thomas Petazzoni
2016-02-10 21:14 ` [Buildroot] [PATCH 1/1] package/gdb: " Arnout Vandecappelle
` (2 subsequent siblings)
4 siblings, 1 reply; 14+ messages in thread
From: Bernd Kuhls @ 2016-02-10 20:59 UTC (permalink / raw)
To: buildroot
When xz was compiled before, tiff will use it as optional dependency:
$ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/lib/libtiff.so.5.2.4 | grep NEEDED
0x00000001 (NEEDED) Shared library: [liblzma.so.5]
0x00000001 (NEEDED) Shared library: [libjpeg.so.9]
0x00000001 (NEEDED) Shared library: [libz.so.1]
0x00000001 (NEEDED) Shared library: [libm.so.1]
0x00000001 (NEEDED) Shared library: [libc.so.1]
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/tiff/Config.in | 4 ++++
package/tiff/tiff.mk | 6 ++++++
2 files changed, 10 insertions(+)
diff --git a/package/tiff/Config.in b/package/tiff/Config.in
index acb335c..00c2a3d 100644
--- a/package/tiff/Config.in
+++ b/package/tiff/Config.in
@@ -41,6 +41,10 @@ config BR2_PACKAGE_TIFF_ZLIB
select BR2_PACKAGE_ZLIB
default y
+config BR2_PACKAGE_TIFF_XZ
+ bool "XZ compression"
+ select BR2_PACKAGE_XZ
+
config BR2_PACKAGE_TIFF_PIXARLOG
bool "Pixar log-format algorithm (requires Zlib)"
select BR2_PACKAGE_TIFF_ZLIB
diff --git a/package/tiff/tiff.mk b/package/tiff/tiff.mk
index c2e713c..266272a 100644
--- a/package/tiff/tiff.mk
+++ b/package/tiff/tiff.mk
@@ -49,6 +49,12 @@ else
TIFF_DEPENDENCIES += zlib
endif
+ifneq ($(BR2_PACKAGE_TIFF_XZ),y)
+TIFF_CONF_OPTS += --disable-lzma
+else
+TIFF_DEPENDENCIES += xz
+endif
+
ifneq ($(BR2_PACKAGE_TIFF_PIXARLOG),y)
TIFF_CONF_OPTS += --disable-pixarlog
endif
--
2.7.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* [Buildroot] [PATCH 1/1] package/tiff: add optional support for xz
2016-02-10 20:59 ` [Buildroot] [PATCH 1/1] package/tiff: add optional support for xz Bernd Kuhls
@ 2016-02-16 22:16 ` Thomas Petazzoni
0 siblings, 0 replies; 14+ messages in thread
From: Thomas Petazzoni @ 2016-02-16 22:16 UTC (permalink / raw)
To: buildroot
Dear Bernd Kuhls,
On Wed, 10 Feb 2016 21:59:10 +0100, Bernd Kuhls wrote:
> When xz was compiled before, tiff will use it as optional dependency:
>
> $ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/lib/libtiff.so.5.2.4 | grep NEEDED
> 0x00000001 (NEEDED) Shared library: [liblzma.so.5]
> 0x00000001 (NEEDED) Shared library: [libjpeg.so.9]
> 0x00000001 (NEEDED) Shared library: [libz.so.1]
> 0x00000001 (NEEDED) Shared library: [libm.so.1]
> 0x00000001 (NEEDED) Shared library: [libc.so.1]
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/tiff/Config.in | 4 ++++
> package/tiff/tiff.mk | 6 ++++++
> 2 files changed, 10 insertions(+)
I've applied, but I would *really* like to see additional patches to
use --enable-<foo> explicitly for all dependencies of the tiff package.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 1/1] package/gdb: add optional support for xz
2016-02-10 20:59 [Buildroot] [PATCH 1/1] package/gdb: add optional support for xz Bernd Kuhls
2016-02-10 20:59 ` [Buildroot] [PATCH 1/1] package/libarchive: add optional support for bzip2 Bernd Kuhls
2016-02-10 20:59 ` [Buildroot] [PATCH 1/1] package/tiff: add optional support for xz Bernd Kuhls
@ 2016-02-10 21:14 ` Arnout Vandecappelle
2016-02-10 21:34 ` Bernd Kuhls
2016-02-10 21:23 ` Arnout Vandecappelle
2016-02-16 22:14 ` Thomas Petazzoni
4 siblings, 1 reply; 14+ messages in thread
From: Arnout Vandecappelle @ 2016-02-10 21:14 UTC (permalink / raw)
To: buildroot
On 10-02-16 21:59, Bernd Kuhls wrote:
> When xz was compiled before, gdb will use it as optional dependency:
>
> $ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/bin/gdb | grep NEEDED
> 0x00000001 (NEEDED) Shared library: [libdl.so.1]
> 0x00000001 (NEEDED) Shared library: [libncurses.so.5]
> 0x00000001 (NEEDED) Shared library: [libz.so.1]
> 0x00000001 (NEEDED) Shared library: [libm.so.1]
> 0x00000001 (NEEDED) Shared library: [liblzma.so.5]
> 0x00000001 (NEEDED) Shared library: [libc.so.1]
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
This should probably go in to 2016.02.
Regards,
Arnout
> ---
> package/gdb/gdb.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk
> index 3b0f501..32d52eb 100644
> --- a/package/gdb/gdb.mk
> +++ b/package/gdb/gdb.mk
> @@ -118,6 +118,13 @@ else
> GDB_CONF_OPTS += --without-expat
> endif
>
> +ifeq ($(BR2_PACKAGE_XZ),y)
> +GDB_CONF_OPTS += --with-lzma
> +GDB_DEPENDENCIES += xz
> +else
> +GDB_CONF_OPTS += --without-lzma
> +endif
> +
> ifeq ($(BR2_PACKAGE_ZLIB),y)
> GDB_CONF_OPTS += --with-zlib
> GDB_DEPENDENCIES += zlib
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 1/1] package/gdb: add optional support for xz
2016-02-10 21:14 ` [Buildroot] [PATCH 1/1] package/gdb: " Arnout Vandecappelle
@ 2016-02-10 21:34 ` Bernd Kuhls
2016-02-16 22:19 ` Peter Korsgaard
0 siblings, 1 reply; 14+ messages in thread
From: Bernd Kuhls @ 2016-02-10 21:34 UTC (permalink / raw)
To: buildroot
Am Wed, 10 Feb 2016 22:14:42 +0100 schrieb Arnout Vandecappelle:
> This should probably go in to 2016.02.
Hi @all,
in the coming days I will post 60-80 patches like this one for a variety
of packages. Currently I only have a list of packages with missing
dependencies, I have yet to prepare the patches for them. Because I
consider them as bugfixes I sent the first patches based on git HEAD,
shall I continue to do so?
Regards, Bernd
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 1/1] package/gdb: add optional support for xz
2016-02-10 21:34 ` Bernd Kuhls
@ 2016-02-16 22:19 ` Peter Korsgaard
0 siblings, 0 replies; 14+ messages in thread
From: Peter Korsgaard @ 2016-02-16 22:19 UTC (permalink / raw)
To: buildroot
>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:
> Am Wed, 10 Feb 2016 22:14:42 +0100 schrieb Arnout Vandecappelle:
>> This should probably go in to 2016.02.
> Hi @all,
> in the coming days I will post 60-80 patches like this one for a variety
> of packages. Currently I only have a list of packages with missing
> dependencies, I have yet to prepare the patches for them. Because I
> consider them as bugfixes I sent the first patches based on git HEAD,
> shall I continue to do so?
Yes, please.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 1/1] package/gdb: add optional support for xz
2016-02-10 20:59 [Buildroot] [PATCH 1/1] package/gdb: add optional support for xz Bernd Kuhls
` (2 preceding siblings ...)
2016-02-10 21:14 ` [Buildroot] [PATCH 1/1] package/gdb: " Arnout Vandecappelle
@ 2016-02-10 21:23 ` Arnout Vandecappelle
2016-02-10 23:04 ` Thomas Petazzoni
2016-02-16 22:14 ` Thomas Petazzoni
4 siblings, 1 reply; 14+ messages in thread
From: Arnout Vandecappelle @ 2016-02-10 21:23 UTC (permalink / raw)
To: buildroot
On 10-02-16 21:59, Bernd Kuhls wrote:
> When xz was compiled before, gdb will use it as optional dependency:
>
> $ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/bin/gdb | grep NEEDED
> 0x00000001 (NEEDED) Shared library: [libdl.so.1]
> 0x00000001 (NEEDED) Shared library: [libncurses.so.5]
> 0x00000001 (NEEDED) Shared library: [libz.so.1]
> 0x00000001 (NEEDED) Shared library: [libm.so.1]
> 0x00000001 (NEEDED) Shared library: [liblzma.so.5]
> 0x00000001 (NEEDED) Shared library: [libc.so.1]
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
This would obviously be needed for host-gdb as well, but that is impossible to
handle without explicit host Config.in options.
I really think we should go that way, there are several problems that need it.
Regards,
Arnout
> ---
> package/gdb/gdb.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk
> index 3b0f501..32d52eb 100644
> --- a/package/gdb/gdb.mk
> +++ b/package/gdb/gdb.mk
> @@ -118,6 +118,13 @@ else
> GDB_CONF_OPTS += --without-expat
> endif
>
> +ifeq ($(BR2_PACKAGE_XZ),y)
> +GDB_CONF_OPTS += --with-lzma
> +GDB_DEPENDENCIES += xz
> +else
> +GDB_CONF_OPTS += --without-lzma
> +endif
> +
> ifeq ($(BR2_PACKAGE_ZLIB),y)
> GDB_CONF_OPTS += --with-zlib
> GDB_DEPENDENCIES += zlib
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 14+ messages in thread* [Buildroot] [PATCH 1/1] package/gdb: add optional support for xz
2016-02-10 20:59 [Buildroot] [PATCH 1/1] package/gdb: add optional support for xz Bernd Kuhls
` (3 preceding siblings ...)
2016-02-10 21:23 ` Arnout Vandecappelle
@ 2016-02-16 22:14 ` Thomas Petazzoni
4 siblings, 0 replies; 14+ messages in thread
From: Thomas Petazzoni @ 2016-02-16 22:14 UTC (permalink / raw)
To: buildroot
Dear Bernd Kuhls,
On Wed, 10 Feb 2016 21:59:08 +0100, Bernd Kuhls wrote:
> When xz was compiled before, gdb will use it as optional dependency:
>
> $ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/bin/gdb | grep NEEDED
> 0x00000001 (NEEDED) Shared library: [libdl.so.1]
> 0x00000001 (NEEDED) Shared library: [libncurses.so.5]
> 0x00000001 (NEEDED) Shared library: [libz.so.1]
> 0x00000001 (NEEDED) Shared library: [libm.so.1]
> 0x00000001 (NEEDED) Shared library: [liblzma.so.5]
> 0x00000001 (NEEDED) Shared library: [libc.so.1]
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/gdb/gdb.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 14+ messages in thread