From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4] package/python-pillow: new package
Date: Tue, 23 Feb 2016 23:36:36 +0100 [thread overview]
Message-ID: <56CCDEF4.9050803@mind.be> (raw)
In-Reply-To: <CA+TH9Vmri=sS5e0gacaoRMxwxNT_evmC9=-ERFvxS86H3NnpKQ@mail.gmail.com>
On 02/23/16 23:18, Angelo Compagnucci wrote:
> Dear Thomas Petazzoni,
>
> 2016-02-21 15:26 GMT+01:00 Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com>:
[snip]
>> It seems like you should pass explicit --enable/--disable options,
>> since at least jpeg and zlib are by default expected to be enabled.
>> See https://pillow.readthedocs.org/en/latest/installation.html#external-libraries.
>>
>> Unfortunately, those options are only recognized when calling "setup.py
>> build_ext", not when calling "setup.py build" as the python-package
>> infrastructure is doing. So you might need to override the build
>> commands for this package.
>
> Right.
>
> I actually implemented something lie this in pkg-python.mk
>
> [...]
> $(2)_BUILD_TARGET ?= build
> [...]
> $(2)_BASE_BUILD_TGT = $$($(2)_BUILD_TARGET)
> [...]
>
> and seems to work and not breaking other packages.
> This way I can add:
>
> PYTHON_PILLOW_BUILD_TARGET = build_ext
>
> What do you think?
Looks like a good idea to me - parallel with autotools-package.
Regards,
Arnout
[snip]
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2016-02-23 22:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 9:55 [Buildroot] [PATCH v4] package/python-pillow: new package Angelo Compagnucci
2016-02-21 14:26 ` Thomas Petazzoni
2016-02-23 22:18 ` Angelo Compagnucci
2016-02-23 22:35 ` Thomas Petazzoni
2016-02-23 22:45 ` Arnout Vandecappelle
2016-02-24 7:06 ` Angelo Compagnucci
2016-02-23 22:36 ` Arnout Vandecappelle [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-06-12 11:38 Angelo Compagnucci
2016-06-13 14:48 ` Peter Korsgaard
2016-06-13 16:05 ` Angelo Compagnucci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CCDEF4.9050803@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox