From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4] package/python-pillow: new package
Date: Tue, 23 Feb 2016 23:45:45 +0100 [thread overview]
Message-ID: <56CCE119.2020305@mind.be> (raw)
In-Reply-To: <20160223233528.4016ea2b@free-electrons.com>
On 02/23/16 23:35, Thomas Petazzoni wrote:
> On Tue, 23 Feb 2016 23:18:47 +0100, Angelo Compagnucci wrote:
>
>> > Right.
>> >
>> > I actually implemented something lie this in pkg-python.mk
>> >
>> > [...]
>> > $(2)_BUILD_TARGET ?= build
>> > [...]
>> > $(2)_BASE_BUILD_TGT = $$($(2)_BUILD_TARGET)
>> > [...]
>> >
>> > and seems to work and not breaking other packages.
>> > This way I can add:
>> >
>> > PYTHON_PILLOW_BUILD_TARGET = build_ext
>> >
>> > What do you think?
> Since it's the first package to require this, I would rather suggest to
> override PYTHON_PILLOW_BUILD_CMDS in python-pillow.mk, so that this
> hack is limited to this package.
>
> Should more packages need this in the future, we can add better
> support in the infrastructure.
Hm, good point as well. Especially because the build commands are just a few lines.
I notice now that in pkg-python we define _BASE_BUILD_TGT in four different
places, and it's always 'build'. Probably can be removed...
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2016-02-23 22:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 9:55 [Buildroot] [PATCH v4] package/python-pillow: new package Angelo Compagnucci
2016-02-21 14:26 ` Thomas Petazzoni
2016-02-23 22:18 ` Angelo Compagnucci
2016-02-23 22:35 ` Thomas Petazzoni
2016-02-23 22:45 ` Arnout Vandecappelle [this message]
2016-02-24 7:06 ` Angelo Compagnucci
2016-02-23 22:36 ` Arnout Vandecappelle
-- strict thread matches above, loose matches on Subject: below --
2016-06-12 11:38 Angelo Compagnucci
2016-06-13 14:48 ` Peter Korsgaard
2016-06-13 16:05 ` Angelo Compagnucci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CCE119.2020305@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox