Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] linux-firmware: Update bnx2x firwmare version
Date: Tue, 1 Mar 2016 22:17:17 +0100	[thread overview]
Message-ID: <56D606DD.5010209@mind.be> (raw)
In-Reply-To: <1456805852-11045-1-git-send-email-joel@jms.id.au>

On 03/01/16 05:17, Joel Stanley wrote:
> Linux kernel 4.2 moved the driver to a newer firmware version. As that
> is our default kernel, move the firmeware to a compatable version.
> 
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> v2: Just use the new firmware to avoid adding extra cruft to our config system

 No, this is certainly not good, it fixes 4.2+ and simultaneously breaks 4.1-.

 What is wrong with Thomas's proposal to remove the unneeded versions in a
post-build script? If your size is so important that 640K matters, you would
probably anyway want to keep only one of the six binaries instead of three
different chip revisions.

 Regards,
 Arnout

> 
>  package/linux-firmware/linux-firmware.mk | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/linux-firmware/linux-firmware.mk b/package/linux-firmware/linux-firmware.mk
> index 083a381ea00a..9363099b68fd 100644
> --- a/package/linux-firmware/linux-firmware.mk
> +++ b/package/linux-firmware/linux-firmware.mk
> @@ -253,9 +253,9 @@ endif
>  
>  ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_BNX2X),y)
>  LINUX_FIRMWARE_FILES += \
> -	bnx2x/bnx2x-e1-7.10.51.0.fw \
> -	bnx2x/bnx2x-e1h-7.10.51.0.fw \
> -	bnx2x/bnx2x-e2-7.10.51.0.fw
> +	bnx2x/bnx2x-e1-7.12.30.0.fw \
> +	bnx2x/bnx2x-e1h-7.12.30.0.fw \
> +	bnx2x/bnx2x-e2-7.12.30.0.fw
>  # No license file; the license is in the file WHENCE
>  # which is installed unconditionally
>  endif
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2016-03-01 21:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26  4:31 [Buildroot] [PATCH] linux-firmware: Allow selection of bnx2x fw version Joel Stanley
2016-02-26  8:39 ` Thomas Petazzoni
2016-02-29  1:45   ` Joel Stanley
2016-02-29  2:51     ` Stewart Smith
2016-03-01  4:17       ` [Buildroot] [PATCH v2] linux-firmware: Update bnx2x firwmare version Joel Stanley
2016-03-01 21:17         ` Arnout Vandecappelle [this message]
2016-03-03  7:06           ` Joel Stanley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D606DD.5010209@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox