* [Buildroot] [PATCH 1/1] busybox: Make S01logging source a default file.
@ 2016-02-26 10:50 Nicolas Cavallari
2016-03-01 22:47 ` Luca Ceresoli
0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Cavallari @ 2016-02-26 10:50 UTC (permalink / raw)
To: buildroot
The default syslog parameters are to keep only 200-400 KiB of logs,
which is very few if there is a spammy daemon on the system, or a daemon
that fails and then spams errors that hides the original problem.
Make S01logging source a /etc/default/logging file where these
parameters can be overridden.
Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
---
package/busybox/S01logging | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/package/busybox/S01logging b/package/busybox/S01logging
index a72c69d..af7bdff 100644
--- a/package/busybox/S01logging
+++ b/package/busybox/S01logging
@@ -3,10 +3,14 @@
# Start logging
#
+SYSLOGD_ARGS=-n
+KLOGD_ARGS=-n
+[ -e /etc/default/logging ] && . /etc/default/logging
+
start() {
printf "Starting logging: "
- start-stop-daemon -b -S -q -m -p /var/run/syslogd.pid --exec /sbin/syslogd -- -n
- start-stop-daemon -b -S -q -m -p /var/run/klogd.pid --exec /sbin/klogd -- -n
+ start-stop-daemon -b -S -q -m -p /var/run/syslogd.pid --exec /sbin/syslogd -- $SYSLOGD_ARGS
+ start-stop-daemon -b -S -q -m -p /var/run/klogd.pid --exec /sbin/klogd -- $KLOGD_ARGS
echo "OK"
}
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/1] busybox: Make S01logging source a default file.
2016-02-26 10:50 [Buildroot] [PATCH 1/1] busybox: Make S01logging source a default file Nicolas Cavallari
@ 2016-03-01 22:47 ` Luca Ceresoli
2016-03-02 18:20 ` Arnout Vandecappelle
2016-03-07 9:48 ` [Buildroot] [PATCH v2 " Nicolas Cavallari
0 siblings, 2 replies; 6+ messages in thread
From: Luca Ceresoli @ 2016-03-01 22:47 UTC (permalink / raw)
To: buildroot
Hi Nicolas,
On 26/02/2016 11:50, Nicolas Cavallari wrote:
> The default syslog parameters are to keep only 200-400 KiB of logs,
> which is very few if there is a spammy daemon on the system, or a daemon
> that fails and then spams errors that hides the original problem.
>
> Make S01logging source a /etc/default/logging file where these
> parameters can be overridden.
>
> Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
> ---
> package/busybox/S01logging | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/package/busybox/S01logging b/package/busybox/S01logging
> index a72c69d..af7bdff 100644
> --- a/package/busybox/S01logging
> +++ b/package/busybox/S01logging
> @@ -3,10 +3,14 @@
> # Start logging
> #
>
> +SYSLOGD_ARGS=-n
> +KLOGD_ARGS=-n
> +[ -e /etc/default/logging ] && . /etc/default/logging
Instead of '-e', we typically use '-r'.
Other than that, looks good. Could you send v2 with this change?
> start() {
> printf "Starting logging: "
> - start-stop-daemon -b -S -q -m -p /var/run/syslogd.pid --exec /sbin/syslogd -- -n
> - start-stop-daemon -b -S -q -m -p /var/run/klogd.pid --exec /sbin/klogd -- -n
> + start-stop-daemon -b -S -q -m -p /var/run/syslogd.pid --exec /sbin/syslogd -- $SYSLOGD_ARGS
> + start-stop-daemon -b -S -q -m -p /var/run/klogd.pid --exec /sbin/klogd -- $KLOGD_ARGS
Unrelated to your patch, but passing '-n' (Run in foreground) looks
strange since we are daemonizing those processes anyway. Do you know any
good reason for this?
--
Luca
--
Luca
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/1] busybox: Make S01logging source a default file.
2016-03-01 22:47 ` Luca Ceresoli
@ 2016-03-02 18:20 ` Arnout Vandecappelle
2016-03-03 13:23 ` Luca Ceresoli
2016-03-07 9:48 ` [Buildroot] [PATCH v2 " Nicolas Cavallari
1 sibling, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2016-03-02 18:20 UTC (permalink / raw)
To: buildroot
On 03/01/16 23:47, Luca Ceresoli wrote:
> Hi Nicolas,
>
> On 26/02/2016 11:50, Nicolas Cavallari wrote:
>> The default syslog parameters are to keep only 200-400 KiB of logs,
>> which is very few if there is a spammy daemon on the system, or a daemon
>> that fails and then spams errors that hides the original problem.
>>
>> Make S01logging source a /etc/default/logging file where these
>> parameters can be overridden.
>>
>> Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
>> ---
>> package/busybox/S01logging | 8 ++++++--
>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/busybox/S01logging b/package/busybox/S01logging
>> index a72c69d..af7bdff 100644
>> --- a/package/busybox/S01logging
>> +++ b/package/busybox/S01logging
>> @@ -3,10 +3,14 @@
>> # Start logging
>> #
>>
>> +SYSLOGD_ARGS=-n
>> +KLOGD_ARGS=-n
>> +[ -e /etc/default/logging ] && . /etc/default/logging
>
> Instead of '-e', we typically use '-r'.
>
> Other than that, looks good. Could you send v2 with this change?
>
>> start() {
>> printf "Starting logging: "
>> - start-stop-daemon -b -S -q -m -p /var/run/syslogd.pid --exec /sbin/syslogd -- -n
>> - start-stop-daemon -b -S -q -m -p /var/run/klogd.pid --exec /sbin/klogd -- -n
>> + start-stop-daemon -b -S -q -m -p /var/run/syslogd.pid --exec /sbin/syslogd -- $SYSLOGD_ARGS
>> + start-stop-daemon -b -S -q -m -p /var/run/klogd.pid --exec /sbin/klogd -- $KLOGD_ARGS
>
> Unrelated to your patch, but passing '-n' (Run in foreground) looks
> strange since we are daemonizing those processes anyway. Do you know any
> good reason for this?
I do: these daemons don't create a PID file, and if they daemonize and
start-stop-daemon creates the PID file, the PID logged in there will be wrong
(it will be the PID of the exited parent).
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/1] busybox: Make S01logging source a default file.
2016-03-02 18:20 ` Arnout Vandecappelle
@ 2016-03-03 13:23 ` Luca Ceresoli
0 siblings, 0 replies; 6+ messages in thread
From: Luca Ceresoli @ 2016-03-03 13:23 UTC (permalink / raw)
To: buildroot
Dear Arnout,
On 02/03/2016 19:20, Arnout Vandecappelle wrote:
> On 03/01/16 23:47, Luca Ceresoli wrote:
[...]
>> Unrelated to your patch, but passing '-n' (Run in foreground) looks
>> strange since we are daemonizing those processes anyway. Do you know any
>> good reason for this?
>
> I do: these daemons don't create a PID file, and if they daemonize and
> start-stop-daemon creates the PID file, the PID logged in there will be wrong
> (it will be the PID of the exited parent).
Good point. Thanks.
--
Luca
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 1/1] busybox: Make S01logging source a default file.
2016-03-01 22:47 ` Luca Ceresoli
2016-03-02 18:20 ` Arnout Vandecappelle
@ 2016-03-07 9:48 ` Nicolas Cavallari
2016-03-09 22:05 ` Peter Korsgaard
1 sibling, 1 reply; 6+ messages in thread
From: Nicolas Cavallari @ 2016-03-07 9:48 UTC (permalink / raw)
To: buildroot
The default syslog parameters are to keep only 200-400 KiB of logs,
which is very few if there is a spammy daemon on the system, or a daemon
that fails and then spams errors that hides the original problem.
Make S01logging source a /etc/default/logging file where these
parameters can be overridden.
Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
---
package/busybox/S01logging | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/package/busybox/S01logging b/package/busybox/S01logging
index a72c69d..4632a4c 100644
--- a/package/busybox/S01logging
+++ b/package/busybox/S01logging
@@ -3,10 +3,14 @@
# Start logging
#
+SYSLOGD_ARGS=-n
+KLOGD_ARGS=-n
+[ -r /etc/default/logging ] && . /etc/default/logging
+
start() {
printf "Starting logging: "
- start-stop-daemon -b -S -q -m -p /var/run/syslogd.pid --exec /sbin/syslogd -- -n
- start-stop-daemon -b -S -q -m -p /var/run/klogd.pid --exec /sbin/klogd -- -n
+ start-stop-daemon -b -S -q -m -p /var/run/syslogd.pid --exec /sbin/syslogd -- $SYSLOGD_ARGS
+ start-stop-daemon -b -S -q -m -p /var/run/klogd.pid --exec /sbin/klogd -- $KLOGD_ARGS
echo "OK"
}
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH v2 1/1] busybox: Make S01logging source a default file.
2016-03-07 9:48 ` [Buildroot] [PATCH v2 " Nicolas Cavallari
@ 2016-03-09 22:05 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2016-03-09 22:05 UTC (permalink / raw)
To: buildroot
>>>>> "Nicolas" == Nicolas Cavallari <nicolas.cavallari@green-communications.fr> writes:
> The default syslog parameters are to keep only 200-400 KiB of logs,
> which is very few if there is a spammy daemon on the system, or a daemon
> that fails and then spams errors that hides the original problem.
> Make S01logging source a /etc/default/logging file where these
> parameters can be overridden.
> Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-03-09 22:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-26 10:50 [Buildroot] [PATCH 1/1] busybox: Make S01logging source a default file Nicolas Cavallari
2016-03-01 22:47 ` Luca Ceresoli
2016-03-02 18:20 ` Arnout Vandecappelle
2016-03-03 13:23 ` Luca Ceresoli
2016-03-07 9:48 ` [Buildroot] [PATCH v2 " Nicolas Cavallari
2016-03-09 22:05 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox