* [Buildroot] [PATCH] libcap-ng: bump to version 0.7.7
@ 2016-03-04 23:00 Sergio Prado
2016-03-04 23:13 ` Romain Naour
2016-03-05 18:05 ` Thomas Petazzoni
0 siblings, 2 replies; 5+ messages in thread
From: Sergio Prado @ 2016-03-04 23:00 UTC (permalink / raw)
To: buildroot
Also disable optimization when compiling for nios2 to prevent a compiler
bug.
Fixes:
http://autobuild.buildroot.net/results/3afc4c006a74fd7512dace90b5f884bf7be4cc58/
http://autobuild.buildroot.net/results/2c53f611a705506ca86fedb0f1129df1d315632c/
http://autobuild.buildroot.net/results/c3d9477688b55987591b5b5efed5ee65499aa0e6/
http://autobuild.buildroot.net/results/052ff24f3985b652c11ac390f342e9ad3d862431/
...
Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
---
package/libcap-ng/Config.in | 1 -
package/libcap-ng/libcap-ng.hash | 2 +-
package/libcap-ng/libcap-ng.mk | 7 ++++++-
3 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/package/libcap-ng/Config.in b/package/libcap-ng/Config.in
index 4939e262ac62..d1663cdefc20 100644
--- a/package/libcap-ng/Config.in
+++ b/package/libcap-ng/Config.in
@@ -1,6 +1,5 @@
config BR2_PACKAGE_LIBCAP_NG
bool "libcap-ng"
- depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII # triggers compiler bug
help
The libcap-ng library is intended to make programming with
posix capabilities much easier than the traditional libcap
diff --git a/package/libcap-ng/libcap-ng.hash b/package/libcap-ng/libcap-ng.hash
index d8dde2360e52..ecea6e88416b 100644
--- a/package/libcap-ng/libcap-ng.hash
+++ b/package/libcap-ng/libcap-ng.hash
@@ -1,2 +1,2 @@
# Locally calculated
-sha256 48a2083276f9820cb92dcb05d001b30733bcbf48c14c230303cac3cd08b45b6b libcap-ng-0.7.4.tar.gz
+sha256 615549ce39b333f6b78baee0c0b4ef18bc726c6bf1cca123dfd89dd963f6d06b libcap-ng-0.7.7.tar.gz
diff --git a/package/libcap-ng/libcap-ng.mk b/package/libcap-ng/libcap-ng.mk
index c2ae25bc5b91..6b84a8cfe566 100644
--- a/package/libcap-ng/libcap-ng.mk
+++ b/package/libcap-ng/libcap-ng.mk
@@ -4,7 +4,7 @@
#
################################################################################
-LIBCAP_NG_VERSION = 0.7.4
+LIBCAP_NG_VERSION = 0.7.7
LIBCAP_NG_SITE = http://people.redhat.com/sgrubb/libcap-ng
LIBCAP_NG_LICENSE = GPLv2+ LGPLv2.1+
LIBCAP_NG_LICENSE_FILES = COPYING COPYING.LIB
@@ -13,4 +13,9 @@ LIBCAP_NG_INSTALL_STAGING = YES
LIBCAP_NG_CONF_ENV = ac_cv_prog_swig_found=no
LIBCAP_NG_CONF_OPTS = --without-python
+# disable optimization when compiling for nios2 to prevent a compiler bug
+#ifeq ($(BR2_nios2),y)
+#LIBCAP_NG_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -O0"
+#endif
+
$(eval $(autotools-package))
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] libcap-ng: bump to version 0.7.7
2016-03-04 23:00 [Buildroot] [PATCH] libcap-ng: bump to version 0.7.7 Sergio Prado
@ 2016-03-04 23:13 ` Romain Naour
2016-03-04 23:48 ` Sergio Prado
2016-03-05 18:05 ` Thomas Petazzoni
1 sibling, 1 reply; 5+ messages in thread
From: Romain Naour @ 2016-03-04 23:13 UTC (permalink / raw)
To: buildroot
Hi Sergio,
Le 05/03/2016 00:00, Sergio Prado a ?crit :
> Also disable optimization when compiling for nios2 to prevent a compiler
> bug.
The bump and the nios2 fix must be two separate patches.
>
> Fixes:
> http://autobuild.buildroot.net/results/3afc4c006a74fd7512dace90b5f884bf7be4cc58/
> http://autobuild.buildroot.net/results/2c53f611a705506ca86fedb0f1129df1d315632c/
> http://autobuild.buildroot.net/results/c3d9477688b55987591b5b5efed5ee65499aa0e6/
> http://autobuild.buildroot.net/results/052ff24f3985b652c11ac390f342e9ad3d862431/
Also the compiler bug is due to an issue with gcc <= 5.2. All theses build
issues are trigged by br-nios2-full-2015.11-rc1-71-g90d1299.tar.bz2 toolchain
which is based on gcc 4.9.
I propose to add an exception in the autobuilder script:
http://patchwork.ozlabs.org/patch/582313/
Also see:
http://lists.busybox.net/pipermail/buildroot/2015-December/146308.html
Best regards,
Romain
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] libcap-ng: bump to version 0.7.7
2016-03-04 23:13 ` Romain Naour
@ 2016-03-04 23:48 ` Sergio Prado
2016-03-05 11:35 ` Romain Naour
0 siblings, 1 reply; 5+ messages in thread
From: Sergio Prado @ 2016-03-04 23:48 UTC (permalink / raw)
To: buildroot
Hi Romain,
Thanks for reviewing the patch.
2016-03-04 20:13 GMT-03:00 Romain Naour <romain.naour@gmail.com>:
>
> Hi Sergio,
>
> Le 05/03/2016 00:00, Sergio Prado a ?crit :
> > Also disable optimization when compiling for nios2 to prevent a compiler
> > bug.
>
> The bump and the nios2 fix must be two separate patches.
Right.
> > Fixes:
> >
http://autobuild.buildroot.net/results/3afc4c006a74fd7512dace90b5f884bf7be4cc58/
> >
http://autobuild.buildroot.net/results/2c53f611a705506ca86fedb0f1129df1d315632c/
> >
http://autobuild.buildroot.net/results/c3d9477688b55987591b5b5efed5ee65499aa0e6/
> >
http://autobuild.buildroot.net/results/052ff24f3985b652c11ac390f342e9ad3d862431/
>
> Also the compiler bug is due to an issue with gcc <= 5.2. All theses build
> issues are trigged by br-nios2-full-2015.11-rc1-71-g90d1299.tar.bz2
toolchain
> which is based on gcc 4.9.
>
> I propose to add an exception in the autobuilder script:
> http://patchwork.ozlabs.org/patch/582313/
>
> Also see:
> http://lists.busybox.net/pipermail/buildroot/2015-December/146308.html
Adding an exception in the autobuilder will not fix the problem in
production, right? The user that wants to use this package with NIOS2 and
GCC <= 5.2 will still catch this problem. Working around the problem
disabling GCC optimizations fixes in all cases. What do you think?
>
> Best regards,
> Romain
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160304/ee2eaf52/attachment.html>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] libcap-ng: bump to version 0.7.7
2016-03-04 23:48 ` Sergio Prado
@ 2016-03-05 11:35 ` Romain Naour
0 siblings, 0 replies; 5+ messages in thread
From: Romain Naour @ 2016-03-05 11:35 UTC (permalink / raw)
To: buildroot
Hello Sergio,
Le 05/03/2016 00:48, Sergio Prado a ?crit :
> Hi Romain,
>
> Thanks for reviewing the patch.
You're welcome !
>
> 2016-03-04 20:13 GMT-03:00 Romain Naour <romain.naour@gmail.com
> <mailto:romain.naour@gmail.com>>:
>>
>> Hi Sergio,
>>
>> Le 05/03/2016 00:00, Sergio Prado a ?crit :
>> > Also disable optimization when compiling for nios2 to prevent a compiler
>> > bug.
>>
>> The bump and the nios2 fix must be two separate patches.
>
> Right.
>
>> > Fixes:
>> > http://autobuild.buildroot.net/results/3afc4c006a74fd7512dace90b5f884bf7be4cc58/
>> > http://autobuild.buildroot.net/results/2c53f611a705506ca86fedb0f1129df1d315632c/
>> > http://autobuild.buildroot.net/results/c3d9477688b55987591b5b5efed5ee65499aa0e6/
>> > http://autobuild.buildroot.net/results/052ff24f3985b652c11ac390f342e9ad3d862431/
>>
>> Also the compiler bug is due to an issue with gcc <= 5.2. All theses build
>> issues are trigged by br-nios2-full-2015.11-rc1-71-g90d1299.tar.bz2 toolchain
>> which is based on gcc 4.9.
>>
>> I propose to add an exception in the autobuilder script:
>> http://patchwork.ozlabs.org/patch/582313/
>>
>> Also see:
>> http://lists.busybox.net/pipermail/buildroot/2015-December/146308.html
>
> Adding an exception in the autobuilder will not fix the problem in production,
> right? The user that wants to use this package with NIOS2 and GCC <= 5.2 will
> still catch this problem. Working around the problem disabling GCC optimizations
> fixes in all cases. What do you think?
I think we need to backport the patch [1] to gcc 4.9.3 but we still need to add
an exception in the autobuilder until the nios2 toolchain is rebuild.
Can you test this patch please:
http://patchwork.ozlabs.org/patch/592357/
Since other version of gcc are not available for nios2, we don't need to
backport this patch.
Thanks for looking at nios2 build failure.
Best regards,
Romain
[1]
https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=3e326557585ffde323867375539f04643fcad29a
>
>>
>> Best regards,
>> Romain
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] libcap-ng: bump to version 0.7.7
2016-03-04 23:00 [Buildroot] [PATCH] libcap-ng: bump to version 0.7.7 Sergio Prado
2016-03-04 23:13 ` Romain Naour
@ 2016-03-05 18:05 ` Thomas Petazzoni
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2016-03-05 18:05 UTC (permalink / raw)
To: buildroot
Dear Sergio Prado,
On Fri, 4 Mar 2016 20:00:40 -0300, Sergio Prado wrote:
> Also disable optimization when compiling for nios2 to prevent a compiler
> bug.
>
> Fixes:
> http://autobuild.buildroot.net/results/3afc4c006a74fd7512dace90b5f884bf7be4cc58/
> http://autobuild.buildroot.net/results/2c53f611a705506ca86fedb0f1129df1d315632c/
> http://autobuild.buildroot.net/results/c3d9477688b55987591b5b5efed5ee65499aa0e6/
> http://autobuild.buildroot.net/results/052ff24f3985b652c11ac390f342e9ad3d862431/
> ...
>
> Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
> ---
> package/libcap-ng/Config.in | 1 -
> package/libcap-ng/libcap-ng.hash | 2 +-
> package/libcap-ng/libcap-ng.mk | 7 ++++++-
> 3 files changed, 7 insertions(+), 3 deletions(-)
I've removed the nios2 related bits (following the feedback from Romain
Naour), and applied to master.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-05 18:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-04 23:00 [Buildroot] [PATCH] libcap-ng: bump to version 0.7.7 Sergio Prado
2016-03-04 23:13 ` Romain Naour
2016-03-04 23:48 ` Sergio Prado
2016-03-05 11:35 ` Romain Naour
2016-03-05 18:05 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox