From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] libpjsip: fix optional dependency on libsrtp
Date: Wed, 9 Mar 2016 00:01:34 +0100 [thread overview]
Message-ID: <56DF59CE.7000505@lucaceresoli.net> (raw)
In-Reply-To: <20160308211526.6a639ffb@free-electrons.com>
On 08/03/2016 21:15, Thomas Petazzoni wrote:
> Dear Luca Ceresoli,
>
> On Mon, 7 Mar 2016 22:56:45 +0100, Luca Ceresoli wrote:
>
>> +ifeq ($(BR2_PACKAGE_LIBSRTP),y)
>> +LIBPJSIP_DEPENDENCIES += libsrtp
>> +LIBPJSIP_CONF_OPTS += --with-external-srtp=$(STAGING_DIR)/usr
>> +endif
>
> The --with-external-srtp seems to imply that there is also an
> "internal/bundled" srtp.
>
> If pjsip indeed needs srtp unconditionally, then we should always
> depend on it and use the external libsrtp rather than the bundled one.
Uh, indeed libpjsip always links libsrtp, and ships the internal copy in
case the no external one is found.
Updated patch incoming.
--
Luca
next prev parent reply other threads:[~2016-03-08 23:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 21:56 [Buildroot] [PATCH 1/2] libpjsip: needs threads Luca Ceresoli
2016-03-07 21:56 ` [Buildroot] [PATCH 2/2] libpjsip: fix optional dependency on libsrtp Luca Ceresoli
2016-03-08 20:15 ` Thomas Petazzoni
2016-03-08 23:01 ` Luca Ceresoli [this message]
2016-03-08 20:14 ` [Buildroot] [PATCH 1/2] libpjsip: needs threads Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DF59CE.7000505@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox