* [Buildroot] [PATCH] rtptools: disable for MIPS Codescape toolchains
@ 2016-03-08 14:23 Vicente Olivert Riera
2016-03-08 15:32 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Vicente Olivert Riera @ 2016-03-08 14:23 UTC (permalink / raw)
To: buildroot
Codescape toolchains don't provide rpcsvc/ypclnt.h, therefore rtptools
fails to build showing an error like this one:
host2ip.c:13:38: fatal error: rpcsvc/ypclnt.h: No such file or directory
#include <rpcsvc/ypclnt.h> /* YP */
Fixes:
http://autobuild.buildroot.net/results/5a8abdd4918a721c1bddbf68a16d99bea90a59a9/
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
package/rtptools/Config.in | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/rtptools/Config.in b/package/rtptools/Config.in
index 80bbb7a..257be7f 100644
--- a/package/rtptools/Config.in
+++ b/package/rtptools/Config.in
@@ -1,7 +1,14 @@
config BR2_PACKAGE_RTPTOOLS
bool "rtptools"
+ # Codescape toolchains don't have rpcsvc/ypclnt.h
+ depends on !BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_IMG_MIPS && \
+ !BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_MTI_MIPS
help
The rtptools distribution consists of a number of small
applications that can be used for processing RTP data.
http://www.cs.columbia.edu/irt/software/rtptools/
+
+comment "rtptools cannot be built with a MIPS Codescape toolchain"
+ depends on BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_IMG_MIPS || \
+ BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_MTI_MIPS
--
2.4.10
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] rtptools: disable for MIPS Codescape toolchains
2016-03-08 14:23 [Buildroot] [PATCH] rtptools: disable for MIPS Codescape toolchains Vicente Olivert Riera
@ 2016-03-08 15:32 ` Thomas Petazzoni
2016-03-08 16:03 ` Vicente Olivert Riera
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2016-03-08 15:32 UTC (permalink / raw)
To: buildroot
Vicente,
On Tue, 8 Mar 2016 14:23:03 +0000, Vicente Olivert Riera wrote:
> Codescape toolchains don't provide rpcsvc/ypclnt.h, therefore rtptools
> fails to build showing an error like this one:
>
> host2ip.c:13:38: fatal error: rpcsvc/ypclnt.h: No such file or directory
> #include <rpcsvc/ypclnt.h> /* YP */
>
> Fixes:
>
> http://autobuild.buildroot.net/results/5a8abdd4918a721c1bddbf68a16d99bea90a59a9/
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Isn't the problem that the Codescape toolchain don't provide RPC
support at all ? Or is it really a bug limited to <rpcsvc/ypclnt.h>.
I don't really like to add random toolchain exclusions without a more
serious explanation than "header file is not in toolchain".
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] rtptools: disable for MIPS Codescape toolchains
2016-03-08 15:32 ` Thomas Petazzoni
@ 2016-03-08 16:03 ` Vicente Olivert Riera
2016-03-08 16:11 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Vicente Olivert Riera @ 2016-03-08 16:03 UTC (permalink / raw)
To: buildroot
Hello Thomas,
On 08/03/16 15:32, Thomas Petazzoni wrote:
> Vicente,
>
> On Tue, 8 Mar 2016 14:23:03 +0000, Vicente Olivert Riera wrote:
>> Codescape toolchains don't provide rpcsvc/ypclnt.h, therefore rtptools
>> fails to build showing an error like this one:
>>
>> host2ip.c:13:38: fatal error: rpcsvc/ypclnt.h: No such file or directory
>> #include <rpcsvc/ypclnt.h> /* YP */
>>
>> Fixes:
>>
>> http://autobuild.buildroot.net/results/5a8abdd4918a721c1bddbf68a16d99bea90a59a9/
>>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>
> Isn't the problem that the Codescape toolchain don't provide RPC
> support at all ?
Yes, that's the problem.
> Or is it really a bug limited to <rpcsvc/ypclnt.h>.
>
> I don't really like to add random toolchain exclusions without a more
> serious explanation than "header file is not in toolchain".
Ok. Perhaps we should make rtptools package depeding on
BR2_TOOLCHAIN_HAS_NATIVE_RPC?
Regards,
Vincent.
>
> Thomas
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] rtptools: disable for MIPS Codescape toolchains
2016-03-08 16:03 ` Vicente Olivert Riera
@ 2016-03-08 16:11 ` Thomas Petazzoni
2016-03-09 14:00 ` Vicente Olivert Riera
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2016-03-08 16:11 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 8 Mar 2016 16:03:56 +0000, Vicente Olivert Riera wrote:
> > Isn't the problem that the Codescape toolchain don't provide RPC
> > support at all ?
>
> Yes, that's the problem.
Ah, OK. That's a different problem indeed.
> > I don't really like to add random toolchain exclusions without a more
> > serious explanation than "header file is not in toolchain".
>
> Ok. Perhaps we should make rtptools package depeding on
> BR2_TOOLCHAIN_HAS_NATIVE_RPC?
Well, I just built rtptools with
http://autobuild.buildroot.org/toolchains/configs/br-arm-basic.config,
which does *not* have RPC support, and it builds fine. So it is not
simply that rtptools unconditionally needs RPC support. Looking at the
code, it does:
#ifndef __UCLIBC__
#define HAVE_YP
#endif
#ifdef HAVE_YP
#include <rpcsvc/ypclnt.h> /* YP */
#endif
So it seems like it has special handling for uClibc. I think you should
replace this with an AC_CHECK_HEADERS test for rpcsvc/ypclnt.h, and use
the HAVE_<foo> variable that will be defined by this test.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] rtptools: disable for MIPS Codescape toolchains
2016-03-08 16:11 ` Thomas Petazzoni
@ 2016-03-09 14:00 ` Vicente Olivert Riera
2016-03-09 14:05 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Vicente Olivert Riera @ 2016-03-09 14:00 UTC (permalink / raw)
To: buildroot
Hello Thomas,
On 08/03/16 16:11, Thomas Petazzoni wrote:
> Hello,
>
> On Tue, 8 Mar 2016 16:03:56 +0000, Vicente Olivert Riera wrote:
>
>>> Isn't the problem that the Codescape toolchain don't provide RPC
>>> support at all ?
>>
>> Yes, that's the problem.
>
> Ah, OK. That's a different problem indeed.
>
>>> I don't really like to add random toolchain exclusions without a more
>>> serious explanation than "header file is not in toolchain".
>>
>> Ok. Perhaps we should make rtptools package depeding on
>> BR2_TOOLCHAIN_HAS_NATIVE_RPC?
>
> Well, I just built rtptools with
> http://autobuild.buildroot.org/toolchains/configs/br-arm-basic.config,
> which does *not* have RPC support, and it builds fine. So it is not
> simply that rtptools unconditionally needs RPC support. Looking at the
> code, it does:
>
> #ifndef __UCLIBC__
> #define HAVE_YP
> #endif
>
> #ifdef HAVE_YP
> #include <rpcsvc/ypclnt.h> /* YP */
> #endif
>
>
> So it seems like it has special handling for uClibc. I think you should
> replace this with an AC_CHECK_HEADERS test for rpcsvc/ypclnt.h, and use
> the HAVE_<foo> variable that will be defined by this test.
the thing is that rtptools already includes its own ypclnt.h under the
"nt/include/rpcsvc" directory, so we could replace the code you wrote
above with something like this:
#ifndef __UCLIBC__
#include "nt/include/rpcsvc/ypclnt.h"
#endif
CC'ing Peter as he wrote the patch which adds that uClibc stuff to
host2ip.c.
Regards,
Vincent.
> Best regards,
>
> Thomas
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] rtptools: disable for MIPS Codescape toolchains
2016-03-09 14:00 ` Vicente Olivert Riera
@ 2016-03-09 14:05 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2016-03-09 14:05 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 9 Mar 2016 14:00:19 +0000, Vicente Olivert Riera wrote:
> the thing is that rtptools already includes its own ypclnt.h under the
> "nt/include/rpcsvc" directory, so we could replace the code you wrote
> above with something like this:
>
> #ifndef __UCLIBC__
> #include "nt/include/rpcsvc/ypclnt.h"
> #endif
>
> CC'ing Peter as he wrote the patch which adds that uClibc stuff to
> host2ip.c.
I haven't looked at the code, but it's not only about including a
header, Peter's patch also puts some code between HAVE_YP.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-03-09 14:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-08 14:23 [Buildroot] [PATCH] rtptools: disable for MIPS Codescape toolchains Vicente Olivert Riera
2016-03-08 15:32 ` Thomas Petazzoni
2016-03-08 16:03 ` Vicente Olivert Riera
2016-03-08 16:11 ` Thomas Petazzoni
2016-03-09 14:00 ` Vicente Olivert Riera
2016-03-09 14:05 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox