[Buildroot] [PATCH] libglib2: improve dev file removal

[Buildroot] [PATCH] libglib2: improve dev file removal

[Gustavo Zacarias]

* Remove /usr/share/glib-2.0 rmdir from DEV_FILES hook, if we are not
using gdb the GDB_FILES hook will hit and remove it anway, and if we are
indeed using gdb we need it.

* Remove glib-compile-resources and glib-compile-schemas binaries, these
aren't used for runtime purposes.

* Remove /usr/share/glib-2.0/codegen and /usr/share/glib-2.0/schemas, as
with the binaries these aren't used for runtime purposes either.

Size savings delta +800 KB.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/libglib2/libglib2.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/libglib2/libglib2.mk b/package/libglib2/libglib2.mk
index ea45f4a..8539505 100644
--- a/package/libglib2/libglib2.mk
+++ b/package/libglib2/libglib2.mk
@@ -128,9 +128,9 @@ endif
 
 define LIBGLIB2_REMOVE_DEV_FILES
 	rm -rf $(TARGET_DIR)/usr/lib/glib-2.0
-	rm -rf $(TARGET_DIR)/usr/share/glib-2.0/gettext
+	rm -rf $(addprefix $(TARGET_DIR)/usr/share/glib-2.0/,codegen gettext schemas)
 	rmdir --ignore-fail-on-non-empty $(TARGET_DIR)/usr/share/glib-2.0
-	rm -f $(addprefix $(TARGET_DIR)/usr/bin/,glib-genmarshal glib-gettextize glib-mkenums gobject-query gtester gtester-report)
+	rm -f $(addprefix $(TARGET_DIR)/usr/bin/,glib-compile-resources glib-compile-schemas glib-genmarshal glib-gettextize glib-mkenums gobject-query gtester gtester-report)
 endef
 
 LIBGLIB2_POST_INSTALL_TARGET_HOOKS += LIBGLIB2_REMOVE_DEV_FILES
-- 
2.4.10

[Buildroot] [PATCH] libglib2: improve dev file removal

[Thomas Petazzoni]

Gustavo,

On Wed,  9 Mar 2016 13:25:12 -0300, Gustavo Zacarias wrote:
> * Remove /usr/share/glib-2.0 rmdir from DEV_FILES hook, if we are not
> using gdb the GDB_FILES hook will hit and remove it anway, and if we are
> indeed using gdb we need it.

Where is this done in your patch?

> * Remove glib-compile-resources and glib-compile-schemas binaries, these
> aren't used for runtime purposes.
> 
> * Remove /usr/share/glib-2.0/codegen and /usr/share/glib-2.0/schemas, as
> with the binaries these aren't used for runtime purposes either.

Those two are OK, of course.

> Size savings delta +800 KB.

Nice savings! I would have written -800KB though :)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] libglib2: improve dev file removal

[Gustavo Zacarias]

On 09/03/16 13:35, Thomas Petazzoni wrote:

> Gustavo,
>
> On Wed,  9 Mar 2016 13:25:12 -0300, Gustavo Zacarias wrote:
>> * Remove /usr/share/glib-2.0 rmdir from DEV_FILES hook, if we are not
>> using gdb the GDB_FILES hook will hit and remove it anway, and if we are
>> indeed using gdb we need it.
>
> Where is this done in your patch?

Bleh! I'll spin v2 for correctness.
Regards.