Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] boot/grub2: add rootwait to default config
@ 2016-03-09 23:46 Gustavo Zacarias
  2016-03-10 20:43 ` Thomas Petazzoni
  2016-03-10 21:33 ` Peter Korsgaard
  0 siblings, 2 replies; 4+ messages in thread
From: Gustavo Zacarias @ 2016-03-09 23:46 UTC (permalink / raw)
  To: buildroot

It doesn't hurt, and is useful for removable boot media like a pendrive
that may depend on usb enumeration and isn't available immediately.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 boot/grub2/grub.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/boot/grub2/grub.cfg b/boot/grub2/grub.cfg
index c8abbd3..bd3e3f0 100644
--- a/boot/grub2/grub.cfg
+++ b/boot/grub2/grub.cfg
@@ -2,5 +2,5 @@ set default="0"
 set timeout="5"
 
 menuentry "Buildroot" {
-	linux /boot/bzImage root=/dev/sda1 console=tty1
+	linux /boot/bzImage root=/dev/sda1 rootwait console=tty1
 }
-- 
2.4.10

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] boot/grub2: add rootwait to default config
  2016-03-09 23:46 [Buildroot] [PATCH] boot/grub2: add rootwait to default config Gustavo Zacarias
@ 2016-03-10 20:43 ` Thomas Petazzoni
  2016-03-10 20:44   ` Gustavo Zacarias
  2016-03-10 21:33 ` Peter Korsgaard
  1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2016-03-10 20:43 UTC (permalink / raw)
  To: buildroot

Dear Gustavo Zacarias,

On Wed,  9 Mar 2016 20:46:35 -0300, Gustavo Zacarias wrote:
> It doesn't hurt, and is useful for removable boot media like a pendrive
> that may depend on usb enumeration and isn't available immediately.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  boot/grub2/grub.cfg | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

But it would be good to be consistent and also change it in
boot/grub/menu.lst, no?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] boot/grub2: add rootwait to default config
  2016-03-10 20:43 ` Thomas Petazzoni
@ 2016-03-10 20:44   ` Gustavo Zacarias
  0 siblings, 0 replies; 4+ messages in thread
From: Gustavo Zacarias @ 2016-03-10 20:44 UTC (permalink / raw)
  To: buildroot

On 10/03/16 17:43, Thomas Petazzoni wrote:

> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> But it would be good to be consistent and also change it in
> boot/grub/menu.lst, no?
>
> Thomas

Sure, i'll send a followup patch, if anyone is still using grub1 ;)
Regards.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] boot/grub2: add rootwait to default config
  2016-03-09 23:46 [Buildroot] [PATCH] boot/grub2: add rootwait to default config Gustavo Zacarias
  2016-03-10 20:43 ` Thomas Petazzoni
@ 2016-03-10 21:33 ` Peter Korsgaard
  1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2016-03-10 21:33 UTC (permalink / raw)
  To: buildroot

>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 > It doesn't hurt, and is useful for removable boot media like a pendrive
 > that may depend on usb enumeration and isn't available immediately.

 > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-03-10 21:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-09 23:46 [Buildroot] [PATCH] boot/grub2: add rootwait to default config Gustavo Zacarias
2016-03-10 20:43 ` Thomas Petazzoni
2016-03-10 20:44   ` Gustavo Zacarias
2016-03-10 21:33 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox