Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] putty: add new package
@ 2016-03-11  6:45 Alexander Dahl
  2016-03-11  7:05 ` Baruch Siach
  2016-03-12 23:13 ` Yann E. MORIN
  0 siblings, 2 replies; 5+ messages in thread
From: Alexander Dahl @ 2016-03-11  6:45 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Alexander Dahl <post@lespocky.de>
---
This is the first patch in a series trying to get packages upstream
created for and used by fli4l [1], in some cases for a long time. I
start with putty, because it got a security update this week anyway.

[1] http://www.fli4l.de/

 package/Config.in        |  1 +
 package/putty/Config.in  | 12 ++++++++++++
 package/putty/putty.hash |  5 +++++
 package/putty/putty.mk   | 22 ++++++++++++++++++++++
 4 files changed, 40 insertions(+)
 create mode 100644 package/putty/Config.in
 create mode 100644 package/putty/putty.hash
 create mode 100644 package/putty/putty.mk

diff --git a/package/Config.in b/package/Config.in
index 35a24ba..2e00fbb 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1465,6 +1465,7 @@ endif
 	source "package/ptpd/Config.in"
 	source "package/ptpd2/Config.in"
 	source "package/pure-ftpd/Config.in"
+	source "package/putty/Config.in"
 	source "package/quagga/Config.in"
 	source "package/radvd/Config.in"
 	source "package/rp-pppoe/Config.in"
diff --git a/package/putty/Config.in b/package/putty/Config.in
new file mode 100644
index 0000000..5c18b2c
--- /dev/null
+++ b/package/putty/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_PUTTY
+	bool "putty"
+	depends on BR2_USE_MMU # fork()
+	depends on BR2_USE_WCHAR
+	help
+	  PuTTY is a free SSH and Telnet client
+
+	  http://www.chiark.greenend.org.uk/~sgtatham/putty/
+
+comment "putty needs a toolchain w/ wchar"
+	depends on BR2_USE_MMU
+	depends on !BR2_USE_WCHAR
diff --git a/package/putty/putty.hash b/package/putty/putty.hash
new file mode 100644
index 0000000..4b02acc
--- /dev/null
+++ b/package/putty/putty.hash
@@ -0,0 +1,5 @@
+# Hashes from: http://the.earth.li/~sgtatham/putty/0.67/{md5,sha1,sha256,sha512}sums
+md5 8d5d450e8f9a011e2e411e3f30827e9b                                                                                                    putty-0.67.tar.gz
+sha1 132ff74266e590a007f86cbb4bea5642db7bdd76                                                                                           putty-0.67.tar.gz
+sha256 80192458e8a46229de512afeca5c757dd8fce09606b3c992fbaeeee29b994a47                                                                 putty-0.67.tar.gz
+sha512 c2b17da46b8db3fe3837a10cb9cf5dd4b3ef6bfa15cadab83f3b87cf1479ed31fced90b774297ae53bdcbbdf230fc80d5c73d5ff3be6916fb591fd7ce3d35eca putty-0.67.tar.gz
diff --git a/package/putty/putty.mk b/package/putty/putty.mk
new file mode 100644
index 0000000..ca86c47
--- /dev/null
+++ b/package/putty/putty.mk
@@ -0,0 +1,22 @@
+################################################################################
+#
+# putty
+#
+################################################################################
+
+PUTTY_VERSION = 0.67
+PUTTY_SOURCE = putty-$(PUTTY_VERSION).tar.gz
+PUTTY_SITE = http://the.earth.li/~sgtatham/putty/$(PUTTY_VERSION)
+PUTTY_SUBDIR = unix
+PUTTY_LICENSE = MIT
+PUTTY_LICENSE_FILES = LICENCE
+PUTTY_CONF_OPTS = --disable-gtktest
+
+ifeq ($(BR2_PACKAGE_LIBGTK2),y)
+PUTTY_CONF_OPTS += --with-gtk=2
+PUTTY_DEPENDENCIES += libgtk2
+else
+PUTTY_CONF_OPTS += --without-gtk
+endif
+
+$(eval $(autotools-package))
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] putty: add new package
  2016-03-11  6:45 [Buildroot] [PATCH 1/1] putty: add new package Alexander Dahl
@ 2016-03-11  7:05 ` Baruch Siach
  2016-03-11  7:54   ` Alexander Dahl
  2016-03-12 23:13 ` Yann E. MORIN
  1 sibling, 1 reply; 5+ messages in thread
From: Baruch Siach @ 2016-03-11  7:05 UTC (permalink / raw)
  To: buildroot

Hi Alexander,

On Fri, Mar 11, 2016 at 07:45:59AM +0100, Alexander Dahl wrote:
> +config BR2_PACKAGE_PUTTY
> +	bool "putty"
> +	depends on BR2_USE_MMU # fork()
> +	depends on BR2_USE_WCHAR
> +	help
> +	  PuTTY is a free SSH and Telnet client
> +
> +	  http://www.chiark.greenend.org.uk/~sgtatham/putty/

It might be useful to note here that the putty program itself depends on gtk2. 
Without gtk2, only command line utilities (pscp, plink, etc.) are built.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] putty: add new package
  2016-03-11  7:05 ` Baruch Siach
@ 2016-03-11  7:54   ` Alexander Dahl
  2016-03-12 23:05     ` Yann E. MORIN
  0 siblings, 1 reply; 5+ messages in thread
From: Alexander Dahl @ 2016-03-11  7:54 UTC (permalink / raw)
  To: buildroot

Hei hei,

On 11.03.2016 08:05, Baruch Siach wrote:
> On Fri, Mar 11, 2016 at 07:45:59AM +0100, Alexander Dahl wrote:
>> +	help
>> +	  PuTTY is a free SSH and Telnet client
>> +
>> +	  http://www.chiark.greenend.org.uk/~sgtatham/putty/
> 
> It might be useful to note here that the putty program itself depends on gtk2. 
> Without gtk2, only command line utilities (pscp, plink, etc.) are built.

You mean in the help text there? I know this is the case, but it might
be a good idea to make it a little more explicit, yes.

Greets
Alex

-- 
?With the first link, the chain is forged. The first speech censured,
the first thought forbidden, the first freedom denied, chains us all
irrevocably.? (Jean-Luc Picard, quoting Judge Aaron Satie)
*** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601  D1D5 8FBA 7744 CC87 10D0 ***

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160311/56b1db34/attachment.asc>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] putty: add new package
  2016-03-11  7:54   ` Alexander Dahl
@ 2016-03-12 23:05     ` Yann E. MORIN
  0 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2016-03-12 23:05 UTC (permalink / raw)
  To: buildroot

Alexander, All,

On 2016-03-11 08:54 +0100, Alexander Dahl spake thusly:
> Hei hei,
> 
> On 11.03.2016 08:05, Baruch Siach wrote:
> > On Fri, Mar 11, 2016 at 07:45:59AM +0100, Alexander Dahl wrote:
> >> +	help
> >> +	  PuTTY is a free SSH and Telnet client
> >> +
> >> +	  http://www.chiark.greenend.org.uk/~sgtatham/putty/
> > 
> > It might be useful to note here that the putty program itself depends on gtk2. 
> > Without gtk2, only command line utilities (pscp, plink, etc.) are built.
> 
> You mean in the help text there? I know this is the case, but it might
> be a good idea to make it a little more explicit, yes.

Yes, in the help text. Something like:

    help
      PuTTY is a free SSH and Telnet client.

      Without GTK2, onlt the command line utilities ar ebuilt; enable
      GTK2 for the graphical client.

      http://www.chiark.greenend.org.uk/~sgtatham/putty/

Regards,
Yann E. MORIN.

> Greets
> Alex
> 
> -- 
> ?With the first link, the chain is forged. The first speech censured,
> the first thought forbidden, the first freedom denied, chains us all
> irrevocably.? (Jean-Luc Picard, quoting Judge Aaron Satie)
> *** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601  D1D5 8FBA 7744 CC87 10D0 ***
> 



> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot


-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] putty: add new package
  2016-03-11  6:45 [Buildroot] [PATCH 1/1] putty: add new package Alexander Dahl
  2016-03-11  7:05 ` Baruch Siach
@ 2016-03-12 23:13 ` Yann E. MORIN
  1 sibling, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2016-03-12 23:13 UTC (permalink / raw)
  To: buildroot

Alexander, All,

On 2016-03-11 07:45 +0100, Alexander Dahl spake thusly:
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> ---
[--SNIP--]
> diff --git a/package/putty/putty.hash b/package/putty/putty.hash
> new file mode 100644
> index 0000000..4b02acc
> --- /dev/null
> +++ b/package/putty/putty.hash
> @@ -0,0 +1,5 @@
> +# Hashes from: http://the.earth.li/~sgtatham/putty/0.67/{md5,sha1,sha256,sha512}sums
> +md5 8d5d450e8f9a011e2e411e3f30827e9b                                                                                                    putty-0.67.tar.gz
> +sha1 132ff74266e590a007f86cbb4bea5642db7bdd76                                                                                           putty-0.67.tar.gz
> +sha256 80192458e8a46229de512afeca5c757dd8fce09606b3c992fbaeeee29b994a47                                                                 putty-0.67.tar.gz
> +sha512 c2b17da46b8db3fe3837a10cb9cf5dd4b3ef6bfa15cadab83f3b87cf1479ed31fced90b774297ae53bdcbbdf230fc80d5c73d5ff3be6916fb591fd7ce3d35eca putty-0.67.tar.gz

sha256 and sha512 are two strong hashes, so md5 and sha1 are not needed.

Otherwise, looks good. When you fix the hashes and tweak the help text
as mentionned in the other mail, you can add my:

    Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> diff --git a/package/putty/putty.mk b/package/putty/putty.mk
> new file mode 100644
> index 0000000..ca86c47
> --- /dev/null
> +++ b/package/putty/putty.mk
> @@ -0,0 +1,22 @@
> +################################################################################
> +#
> +# putty
> +#
> +################################################################################
> +
> +PUTTY_VERSION = 0.67
> +PUTTY_SOURCE = putty-$(PUTTY_VERSION).tar.gz
> +PUTTY_SITE = http://the.earth.li/~sgtatham/putty/$(PUTTY_VERSION)
> +PUTTY_SUBDIR = unix
> +PUTTY_LICENSE = MIT
> +PUTTY_LICENSE_FILES = LICENCE
> +PUTTY_CONF_OPTS = --disable-gtktest
> +
> +ifeq ($(BR2_PACKAGE_LIBGTK2),y)
> +PUTTY_CONF_OPTS += --with-gtk=2
> +PUTTY_DEPENDENCIES += libgtk2
> +else
> +PUTTY_CONF_OPTS += --without-gtk
> +endif
> +
> +$(eval $(autotools-package))
> -- 
> 2.1.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-12 23:13 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-11  6:45 [Buildroot] [PATCH 1/1] putty: add new package Alexander Dahl
2016-03-11  7:05 ` Baruch Siach
2016-03-11  7:54   ` Alexander Dahl
2016-03-12 23:05     ` Yann E. MORIN
2016-03-12 23:13 ` Yann E. MORIN

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox