* [Buildroot] [PATCH 1/3] libtommath: new package
@ 2016-04-01 8:07 Francois Perrad
2016-04-01 8:07 ` [Buildroot] [PATCH 2/3] libtomcrypt: " Francois Perrad
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Francois Perrad @ 2016-04-01 8:07 UTC (permalink / raw)
To: buildroot
Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
package/Config.in | 1 +
package/libtommath/Config.in | 7 +++++++
package/libtommath/libtommath.mk | 21 +++++++++++++++++++++
3 files changed, 29 insertions(+)
create mode 100644 package/libtommath/Config.in
create mode 100644 package/libtommath/libtommath.mk
diff --git a/package/Config.in b/package/Config.in
index 7b23519..84df812 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1233,6 +1233,7 @@ menu "Other"
source "package/libsigc/Config.in"
source "package/libsigsegv/Config.in"
source "package/libtasn1/Config.in"
+ source "package/libtommath/Config.in"
source "package/libtpl/Config.in"
source "package/libubox/Config.in"
source "package/libuci/Config.in"
diff --git a/package/libtommath/Config.in b/package/libtommath/Config.in
new file mode 100644
index 0000000..b2ffc72
--- /dev/null
+++ b/package/libtommath/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBTOMMATH
+ bool "libtommath"
+ help
+ LibTomMath is a free open source portable number theoretic
+ multiple-precision integer library written entirely in C.
+
+ http://www.libtom.net
diff --git a/package/libtommath/libtommath.mk b/package/libtommath/libtommath.mk
new file mode 100644
index 0000000..44f21ff
--- /dev/null
+++ b/package/libtommath/libtommath.mk
@@ -0,0 +1,21 @@
+################################################################################
+#
+# libtommath
+#
+################################################################################
+
+LIBTOMMATH_VERSION = v1.0
+LIBTOMMATH_SITE = $(call github,libtom,libtommath,$(LIBTOMMATH_VERSION))
+LIBTOMMATH_LICENSE = WTFPL
+LIBTOMMATH_LICENSE_FILES = LICENSE
+LIBTOMMATH_INSTALL_STAGING = YES
+
+define LIBTOMMATH_BUILD_CMDS
+ $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) CFLAGS="-I./ $(TARGET_CFLAGS)"
+endef
+
+define LIBTOMMATH_INSTALL_STAGING_CMDS
+ $(MAKE) -C $(@D) DESTDIR="$(STAGING_DIR)" install
+endef
+
+$(eval $(generic-package))
--
2.5.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/3] libtomcrypt: new package
2016-04-01 8:07 [Buildroot] [PATCH 1/3] libtommath: new package Francois Perrad
@ 2016-04-01 8:07 ` Francois Perrad
2016-04-01 8:07 ` [Buildroot] [PATCH 3/3] dropbear: use libtomath & libtomcrypt Francois Perrad
2016-04-01 8:19 ` [Buildroot] [PATCH 1/3] libtommath: new package Yegor Yefremov
2 siblings, 0 replies; 9+ messages in thread
From: Francois Perrad @ 2016-04-01 8:07 UTC (permalink / raw)
To: buildroot
Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
package/Config.in | 1 +
.../0001-install-without-USER-and-GROUP.patch | 61 ++++++++++++++++++++++
package/libtomcrypt/Config.in | 11 ++++
package/libtomcrypt/libtomcrypt.mk | 22 ++++++++
4 files changed, 95 insertions(+)
create mode 100644 package/libtomcrypt/0001-install-without-USER-and-GROUP.patch
create mode 100644 package/libtomcrypt/Config.in
create mode 100644 package/libtomcrypt/libtomcrypt.mk
diff --git a/package/Config.in b/package/Config.in
index 84df812..b38b24b 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -839,6 +839,7 @@ menu "Crypto"
source "package/libsodium/Config.in"
source "package/libssh/Config.in"
source "package/libssh2/Config.in"
+ source "package/libtomcrypt/Config.in"
source "package/libuecc/Config.in"
source "package/mbedtls/Config.in"
source "package/nettle/Config.in"
diff --git a/package/libtomcrypt/0001-install-without-USER-and-GROUP.patch b/package/libtomcrypt/0001-install-without-USER-and-GROUP.patch
new file mode 100644
index 0000000..325d04b
--- /dev/null
+++ b/package/libtomcrypt/0001-install-without-USER-and-GROUP.patch
@@ -0,0 +1,61 @@
+install without USER and GROUP
+
+see https://github.com/libtom/libtomcrypt/pull/115
+
+Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
+
+diff --git a/makefile b/makefile
+index f650ea1..b346bed 100644
+--- a/makefile
++++ b/makefile
+@@ -300,19 +300,19 @@ install: library docs
+ else
+ install: library
+ endif
+- install -d -g $(GROUP) -o $(USER) $(DESTDIR)$(LIBPATH)
+- install -d -g $(GROUP) -o $(USER) $(DESTDIR)$(INCPATH)
+- install -d -g $(GROUP) -o $(USER) $(DESTDIR)$(DATAPATH)
+- install -g $(GROUP) -o $(USER) $(LIBNAME) $(DESTDIR)$(LIBPATH)
+- install -g $(GROUP) -o $(USER) $(HEADERS) $(DESTDIR)$(INCPATH)
++ install -d $(DESTDIR)$(LIBPATH)
++ install -d $(DESTDIR)$(INCPATH)
++ install -d $(DESTDIR)$(DATAPATH)
++ install -m 644 $(LIBNAME) $(DESTDIR)$(LIBPATH)
++ install -m 644 $(HEADERS) $(DESTDIR)$(INCPATH)
+ ifndef NODOCS
+- install -g $(GROUP) -o $(USER) doc/crypt.pdf $(DESTDIR)$(DATAPATH)
++ install -m 644 doc/crypt.pdf $(DESTDIR)$(DATAPATH)
+ endif
+
+ install_test: testprof/$(LIBTEST)
+- install -d -g $(GROUP) -o $(USER) $(DESTDIR)$(LIBPATH)
+- install -d -g $(GROUP) -o $(USER) $(DESTDIR)$(INCPATH)
+- install -g $(GROUP) -o $(USER) testprof/$(LIBTEST) $(DESTDIR)$(LIBPATH)
++ install -d $(DESTDIR)$(LIBPATH)
++ install -d $(DESTDIR)$(INCPATH)
++ install -m 644 testprof/$(LIBTEST) $(DESTDIR)$(LIBPATH)
+
+ profile:
+ CFLAGS="$(CFLAGS) -fprofile-generate" $(MAKE) timing EXTRALIBS="$(EXTRALIBS) -lgcov"
+diff --git a/makefile.shared b/makefile.shared
+index dd575d9..c5e97af 100644
+--- a/makefile.shared
++++ b/makefile.shared
+@@ -252,11 +252,11 @@ $(LIBNAME): $(OBJECTS) testprof/$(LIBTEST)
+ libtool --silent --mode=link gcc $(CFLAGS) `find . -type f | grep "[.]lo" | grep "src/" | xargs` $(EXTRALIBS) -o $(LIBNAME) -rpath $(LIBPATH) -version-info $(VERSION)
+
+ install: $(LIBNAME)
+- install -d -g $(GROUP) -o $(USER) $(DESTDIR)$(LIBPATH)
+- cd testprof ; CFLAGS="$(CFLAGS)" GROUP=$(GROUP) USER=$(USER) VERSION=$(VERSION) LIBPATH=$(LIBPATH) LIBTEST=$(LIBTEST) LIBTEST_S=$(LIBTEST_S) DESTDIR=$(DESTDIR) make -f makefile.shared install
++ install -d $(DESTDIR)$(LIBPATH)
++ cd testprof ; CFLAGS="$(CFLAGS)" VERSION=$(VERSION) LIBPATH=$(LIBPATH) LIBTEST=$(LIBTEST) LIBTEST_S=$(LIBTEST_S) DESTDIR=$(DESTDIR) make -f makefile.shared install
+ libtool --silent --mode=install install -c libtomcrypt.la $(DESTDIR)$(LIBPATH)/libtomcrypt.la
+- install -d -g $(GROUP) -o $(USER) $(DESTDIR)$(INCPATH)
+- install -g $(GROUP) -o $(USER) $(HEADERS) $(DESTDIR)$(INCPATH)
++ install -d $(DESTDIR)$(INCPATH)
++ install -m 644 $(HEADERS) $(DESTDIR)$(INCPATH)
+
+ #This rule makes the hash program included with libtomcrypt
+ hashsum: library
+--
+
diff --git a/package/libtomcrypt/Config.in b/package/libtomcrypt/Config.in
new file mode 100644
index 0000000..6678b30
--- /dev/null
+++ b/package/libtomcrypt/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_LIBTOMCRYPT
+ bool "libtomcrypt"
+ select BR2_PACKAGE_LIBTOMMATH
+ help
+ LibTomCrypt is a fairly comprehensive, modular and portable
+ cryptographic toolkit that provides developers with a vast array
+ of well known published block ciphers, one-way hash functions,
+ chaining modes, pseudo-random number generators, public key
+ cryptography and a plethora of other routines.
+
+ http://www.libtom.net
diff --git a/package/libtomcrypt/libtomcrypt.mk b/package/libtomcrypt/libtomcrypt.mk
new file mode 100644
index 0000000..921eed3
--- /dev/null
+++ b/package/libtomcrypt/libtomcrypt.mk
@@ -0,0 +1,22 @@
+################################################################################
+#
+# libtomcrypt
+#
+################################################################################
+
+LIBTOMCRYPT_VERSION = 1.17
+LIBTOMCRYPT_SITE = $(call github,libtom,libtomcrypt,$(LIBTOMCRYPT_VERSION))
+LIBTOMCRYPT_LICENSE = WTFPL
+LIBTOMCRYPT_LICENSE_FILES = LICENSE
+LIBTOMCRYPT_INSTALL_STAGING = YES
+LIBTOMCRYPT_DEPENDENCIES = libtommath
+
+define LIBTOMCRYPT_BUILD_CMDS
+ $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) CFLAGS="-I./src/headers $(TARGET_CFLAGS) -DLTC_SOURCE -DLTM_DESC"
+endef
+
+define LIBTOMCRYPT_INSTALL_STAGING_CMDS
+ $(MAKE) -C $(@D) DESTDIR="$(STAGING_DIR)" NODOCS=1 install
+endef
+
+$(eval $(generic-package))
--
2.5.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 3/3] dropbear: use libtomath & libtomcrypt
2016-04-01 8:07 [Buildroot] [PATCH 1/3] libtommath: new package Francois Perrad
2016-04-01 8:07 ` [Buildroot] [PATCH 2/3] libtomcrypt: " Francois Perrad
@ 2016-04-01 8:07 ` Francois Perrad
2016-04-01 8:42 ` Baruch Siach
2016-04-01 8:19 ` [Buildroot] [PATCH 1/3] libtommath: new package Yegor Yefremov
2 siblings, 1 reply; 9+ messages in thread
From: Francois Perrad @ 2016-04-01 8:07 UTC (permalink / raw)
To: buildroot
Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
package/dropbear/0001-fix-linking.patch | 36 +++++++++++++++++++++++++++++++++
package/dropbear/dropbear.mk | 7 +++++++
2 files changed, 43 insertions(+)
create mode 100644 package/dropbear/0001-fix-linking.patch
diff --git a/package/dropbear/0001-fix-linking.patch b/package/dropbear/0001-fix-linking.patch
new file mode 100644
index 0000000..93925eb
--- /dev/null
+++ b/package/dropbear/0001-fix-linking.patch
@@ -0,0 +1,36 @@
+fix linking
+
+see https://github.com/mkj/dropbear/pull/28
+
+Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
+
+diff --git a/Makefile.in b/Makefile.in
+index d9bfdfa..0356b0f 100644
+--- a/Makefile.in
++++ b/Makefile.in
+@@ -16,12 +16,12 @@ endif
+ STATIC_LTC=libtomcrypt/libtomcrypt.a
+ STATIC_LTM=libtommath/libtommath.a
+
+-LIBTOM_LIBS=@LIBTOM_LIBS@
++LIBTOM_LIBS=-ltomcrypt -ltommath
+
+ ifeq (@BUNDLED_LIBTOM@, 1)
+ LIBTOM_DEPS=$(STATIC_LTC) $(STATIC_LTM)
+ CFLAGS+=-I$(srcdir)/libtomcrypt/src/headers/
+-LIBTOM_LIBS=$(STATIC_LTC) $(STATIC_LTM)
++LDFLAGS+=-L ./libtomcrypt -L ./libtommath
+ endif
+
+ COMMONOBJS=dbutil.o buffer.o dbhelpers.o \
+@@ -84,7 +84,7 @@ INSTALL=@INSTALL@
+ CPPFLAGS=@CPPFLAGS@
+ CFLAGS+=-I. -I$(srcdir) $(CPPFLAGS) @CFLAGS@
+ LIBS+=@LIBS@
+-LDFLAGS=@LDFLAGS@
++LDFLAGS+=@LDFLAGS@
+
+ EXEEXT=@EXEEXT@
+
+--
+
diff --git a/package/dropbear/dropbear.mk b/package/dropbear/dropbear.mk
index 32e2167..f664c8d 100644
--- a/package/dropbear/dropbear.mk
+++ b/package/dropbear/dropbear.mk
@@ -12,6 +12,13 @@ DROPBEAR_LICENSE_FILES = LICENSE
DROPBEAR_TARGET_BINS = dropbearkey dropbearconvert scp
DROPBEAR_PROGRAMS = dropbear $(DROPBEAR_TARGET_BINS)
+ifeq ($(BR2_PACKAGE_LIBTOMMATH)$(BR2_PACKAGE_LIBTOMCRYPT),yy)
+DROPBEAR_DEPENDENCIES += libtommath libtomcrypt
+DROPBEAR_CONF_OPTS += --disable-bundled-libtom
+else
+DROPBEAR_CONF_OPTS += --enable-bundled-libtom
+endif
+
ifeq ($(BR2_PACKAGE_DROPBEAR_CLIENT),y)
# Build dbclient, and create a convenience symlink named ssh
DROPBEAR_PROGRAMS += dbclient
--
2.5.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/3] libtommath: new package
2016-04-01 8:07 [Buildroot] [PATCH 1/3] libtommath: new package Francois Perrad
2016-04-01 8:07 ` [Buildroot] [PATCH 2/3] libtomcrypt: " Francois Perrad
2016-04-01 8:07 ` [Buildroot] [PATCH 3/3] dropbear: use libtomath & libtomcrypt Francois Perrad
@ 2016-04-01 8:19 ` Yegor Yefremov
2016-04-01 9:11 ` François Perrad
2 siblings, 1 reply; 9+ messages in thread
From: Yegor Yefremov @ 2016-04-01 8:19 UTC (permalink / raw)
To: buildroot
Hi Francois,
On Fri, Apr 1, 2016 at 10:07 AM, Francois Perrad <fperrad@gmail.com> wrote:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
> package/Config.in | 1 +
> package/libtommath/Config.in | 7 +++++++
> package/libtommath/libtommath.mk | 21 +++++++++++++++++++++
hash file is missing
> 3 files changed, 29 insertions(+)
> create mode 100644 package/libtommath/Config.in
> create mode 100644 package/libtommath/libtommath.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 7b23519..84df812 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1233,6 +1233,7 @@ menu "Other"
> source "package/libsigc/Config.in"
> source "package/libsigsegv/Config.in"
> source "package/libtasn1/Config.in"
> + source "package/libtommath/Config.in"
> source "package/libtpl/Config.in"
> source "package/libubox/Config.in"
> source "package/libuci/Config.in"
> diff --git a/package/libtommath/Config.in b/package/libtommath/Config.in
> new file mode 100644
> index 0000000..b2ffc72
> --- /dev/null
> +++ b/package/libtommath/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_LIBTOMMATH
> + bool "libtommath"
> + help
> + LibTomMath is a free open source portable number theoretic
> + multiple-precision integer library written entirely in C.
> +
> + http://www.libtom.net
> diff --git a/package/libtommath/libtommath.mk b/package/libtommath/libtommath.mk
> new file mode 100644
> index 0000000..44f21ff
> --- /dev/null
> +++ b/package/libtommath/libtommath.mk
> @@ -0,0 +1,21 @@
> +################################################################################
> +#
> +# libtommath
> +#
> +################################################################################
> +
> +LIBTOMMATH_VERSION = v1.0
> +LIBTOMMATH_SITE = $(call github,libtom,libtommath,$(LIBTOMMATH_VERSION))
why don't you take official release tarballs? The same for libtomcrypt
Yegor
> +LIBTOMMATH_LICENSE = WTFPL
> +LIBTOMMATH_LICENSE_FILES = LICENSE
> +LIBTOMMATH_INSTALL_STAGING = YES
> +
> +define LIBTOMMATH_BUILD_CMDS
> + $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) CFLAGS="-I./ $(TARGET_CFLAGS)"
> +endef
> +
> +define LIBTOMMATH_INSTALL_STAGING_CMDS
> + $(MAKE) -C $(@D) DESTDIR="$(STAGING_DIR)" install
> +endef
> +
> +$(eval $(generic-package))
> --
> 2.5.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 3/3] dropbear: use libtomath & libtomcrypt
2016-04-01 8:07 ` [Buildroot] [PATCH 3/3] dropbear: use libtomath & libtomcrypt Francois Perrad
@ 2016-04-01 8:42 ` Baruch Siach
2016-04-01 9:14 ` François Perrad
0 siblings, 1 reply; 9+ messages in thread
From: Baruch Siach @ 2016-04-01 8:42 UTC (permalink / raw)
To: buildroot
Hi Francois,
On Fri, Apr 01, 2016 at 10:07:10AM +0200, Francois Perrad wrote:
> +ifeq ($(BR2_PACKAGE_LIBTOMMATH)$(BR2_PACKAGE_LIBTOMCRYPT),yy)
> +DROPBEAR_DEPENDENCIES += libtommath libtomcrypt
Does dropbear code use libtommath directly? If not, listing only libtomcrypt
should be enough. The check for BR2_PACKAGE_LIBTOMMATH can also be dropped in
this case.
> +DROPBEAR_CONF_OPTS += --disable-bundled-libtom
> +else
> +DROPBEAR_CONF_OPTS += --enable-bundled-libtom
> +endif
> +
> ifeq ($(BR2_PACKAGE_DROPBEAR_CLIENT),y)
> # Build dbclient, and create a convenience symlink named ssh
> DROPBEAR_PROGRAMS += dbclient
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/3] libtommath: new package
2016-04-01 8:19 ` [Buildroot] [PATCH 1/3] libtommath: new package Yegor Yefremov
@ 2016-04-01 9:11 ` François Perrad
2016-04-01 10:17 ` Yegor Yefremov
2016-04-01 10:21 ` Vicente Olivert Riera
0 siblings, 2 replies; 9+ messages in thread
From: François Perrad @ 2016-04-01 9:11 UTC (permalink / raw)
To: buildroot
2016-04-01 10:19 GMT+02:00 Yegor Yefremov <yegorslists@googlemail.com>:
> Hi Francois,
>
> On Fri, Apr 1, 2016 at 10:07 AM, Francois Perrad <fperrad@gmail.com> wrote:
>> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
>> ---
>> package/Config.in | 1 +
>> package/libtommath/Config.in | 7 +++++++
>> package/libtommath/libtommath.mk | 21 +++++++++++++++++++++
>
> hash file is missing
>
>> 3 files changed, 29 insertions(+)
>> create mode 100644 package/libtommath/Config.in
>> create mode 100644 package/libtommath/libtommath.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index 7b23519..84df812 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -1233,6 +1233,7 @@ menu "Other"
>> source "package/libsigc/Config.in"
>> source "package/libsigsegv/Config.in"
>> source "package/libtasn1/Config.in"
>> + source "package/libtommath/Config.in"
>> source "package/libtpl/Config.in"
>> source "package/libubox/Config.in"
>> source "package/libuci/Config.in"
>> diff --git a/package/libtommath/Config.in b/package/libtommath/Config.in
>> new file mode 100644
>> index 0000000..b2ffc72
>> --- /dev/null
>> +++ b/package/libtommath/Config.in
>> @@ -0,0 +1,7 @@
>> +config BR2_PACKAGE_LIBTOMMATH
>> + bool "libtommath"
>> + help
>> + LibTomMath is a free open source portable number theoretic
>> + multiple-precision integer library written entirely in C.
>> +
>> + http://www.libtom.net
>> diff --git a/package/libtommath/libtommath.mk b/package/libtommath/libtommath.mk
>> new file mode 100644
>> index 0000000..44f21ff
>> --- /dev/null
>> +++ b/package/libtommath/libtommath.mk
>> @@ -0,0 +1,21 @@
>> +################################################################################
>> +#
>> +# libtommath
>> +#
>> +################################################################################
>> +
>> +LIBTOMMATH_VERSION = v1.0
>> +LIBTOMMATH_SITE = $(call github,libtom,libtommath,$(LIBTOMMATH_VERSION))
>
> why don't you take official release tarballs? The same for libtomcrypt
>
on http://www.libtom.net/, all links are on Github:
- https://github.com/libtom/libtomcrypt/tree/1.17
- https://github.com/libtom/libtomcrypt/releases/download/1.17/crypt-1.17.tar.bz2
- https://github.com/libtom/libtommath/tree/v1.0
- https://github.com/libtom/libtommath/releases/download/v1.0/ltm-1.0.tar.xz
and as far I know, the Github helper is not reliable for hash.
Fran?ois
> Yegor
>
>> +LIBTOMMATH_LICENSE = WTFPL
>> +LIBTOMMATH_LICENSE_FILES = LICENSE
>> +LIBTOMMATH_INSTALL_STAGING = YES
>> +
>> +define LIBTOMMATH_BUILD_CMDS
>> + $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) CFLAGS="-I./ $(TARGET_CFLAGS)"
>> +endef
>> +
>> +define LIBTOMMATH_INSTALL_STAGING_CMDS
>> + $(MAKE) -C $(@D) DESTDIR="$(STAGING_DIR)" install
>> +endef
>> +
>> +$(eval $(generic-package))
>> --
>> 2.5.0
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 3/3] dropbear: use libtomath & libtomcrypt
2016-04-01 8:42 ` Baruch Siach
@ 2016-04-01 9:14 ` François Perrad
0 siblings, 0 replies; 9+ messages in thread
From: François Perrad @ 2016-04-01 9:14 UTC (permalink / raw)
To: buildroot
2016-04-01 10:42 GMT+02:00 Baruch Siach <baruch@tkos.co.il>:
> Hi Francois,
>
> On Fri, Apr 01, 2016 at 10:07:10AM +0200, Francois Perrad wrote:
>> +ifeq ($(BR2_PACKAGE_LIBTOMMATH)$(BR2_PACKAGE_LIBTOMCRYPT),yy)
>> +DROPBEAR_DEPENDENCIES += libtommath libtomcrypt
>
> Does dropbear code use libtommath directly? If not, listing only libtomcrypt
> should be enough. The check for BR2_PACKAGE_LIBTOMMATH can also be dropped in
> this case.
>
The configure script of dropbear checks the presence of both libraries
: libtommath and libtomcrypt.
See https://github.com/mkj/dropbear/blob/master/configure.ac#L391
Fran?ois
>> +DROPBEAR_CONF_OPTS += --disable-bundled-libtom
>> +else
>> +DROPBEAR_CONF_OPTS += --enable-bundled-libtom
>> +endif
>> +
>> ifeq ($(BR2_PACKAGE_DROPBEAR_CLIENT),y)
>> # Build dbclient, and create a convenience symlink named ssh
>> DROPBEAR_PROGRAMS += dbclient
>
> baruch
>
> --
> http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/3] libtommath: new package
2016-04-01 9:11 ` François Perrad
@ 2016-04-01 10:17 ` Yegor Yefremov
2016-04-01 10:21 ` Vicente Olivert Riera
1 sibling, 0 replies; 9+ messages in thread
From: Yegor Yefremov @ 2016-04-01 10:17 UTC (permalink / raw)
To: buildroot
On Fri, Apr 1, 2016 at 11:11 AM, Fran?ois Perrad
<francois.perrad@gadz.org> wrote:
> 2016-04-01 10:19 GMT+02:00 Yegor Yefremov <yegorslists@googlemail.com>:
>> Hi Francois,
>>
>> On Fri, Apr 1, 2016 at 10:07 AM, Francois Perrad <fperrad@gmail.com> wrote:
>>> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
>>> ---
>>> package/Config.in | 1 +
>>> package/libtommath/Config.in | 7 +++++++
>>> package/libtommath/libtommath.mk | 21 +++++++++++++++++++++
>>
>> hash file is missing
>>
>>> 3 files changed, 29 insertions(+)
>>> create mode 100644 package/libtommath/Config.in
>>> create mode 100644 package/libtommath/libtommath.mk
>>>
>>> diff --git a/package/Config.in b/package/Config.in
>>> index 7b23519..84df812 100644
>>> --- a/package/Config.in
>>> +++ b/package/Config.in
>>> @@ -1233,6 +1233,7 @@ menu "Other"
>>> source "package/libsigc/Config.in"
>>> source "package/libsigsegv/Config.in"
>>> source "package/libtasn1/Config.in"
>>> + source "package/libtommath/Config.in"
>>> source "package/libtpl/Config.in"
>>> source "package/libubox/Config.in"
>>> source "package/libuci/Config.in"
>>> diff --git a/package/libtommath/Config.in b/package/libtommath/Config.in
>>> new file mode 100644
>>> index 0000000..b2ffc72
>>> --- /dev/null
>>> +++ b/package/libtommath/Config.in
>>> @@ -0,0 +1,7 @@
>>> +config BR2_PACKAGE_LIBTOMMATH
>>> + bool "libtommath"
>>> + help
>>> + LibTomMath is a free open source portable number theoretic
>>> + multiple-precision integer library written entirely in C.
>>> +
>>> + http://www.libtom.net
>>> diff --git a/package/libtommath/libtommath.mk b/package/libtommath/libtommath.mk
>>> new file mode 100644
>>> index 0000000..44f21ff
>>> --- /dev/null
>>> +++ b/package/libtommath/libtommath.mk
>>> @@ -0,0 +1,21 @@
>>> +################################################################################
>>> +#
>>> +# libtommath
>>> +#
>>> +################################################################################
>>> +
>>> +LIBTOMMATH_VERSION = v1.0
>>> +LIBTOMMATH_SITE = $(call github,libtom,libtommath,$(LIBTOMMATH_VERSION))
>>
>> why don't you take official release tarballs? The same for libtomcrypt
>>
>
> on http://www.libtom.net/, all links are on Github:
> - https://github.com/libtom/libtomcrypt/tree/1.17
> - https://github.com/libtom/libtomcrypt/releases/download/1.17/crypt-1.17.tar.bz2
> - https://github.com/libtom/libtommath/tree/v1.0
> - https://github.com/libtom/libtommath/releases/download/v1.0/ltm-1.0.tar.xz
>
> and as far I know, the Github helper is not reliable for hash.
You don't need the GitHub helper as 1.17 and 1.0 are official "green"
releases. Just take a look how this is handled for tmux package.
Yegor
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/3] libtommath: new package
2016-04-01 9:11 ` François Perrad
2016-04-01 10:17 ` Yegor Yefremov
@ 2016-04-01 10:21 ` Vicente Olivert Riera
1 sibling, 0 replies; 9+ messages in thread
From: Vicente Olivert Riera @ 2016-04-01 10:21 UTC (permalink / raw)
To: buildroot
Hello Fran?ois,
On 01/04/16 10:11, Fran?ois Perrad wrote:
> 2016-04-01 10:19 GMT+02:00 Yegor Yefremov <yegorslists@googlemail.com>:
[snip]
>>> +++ b/package/libtommath/libtommath.mk
>>> @@ -0,0 +1,21 @@
>>> +################################################################################
>>> +#
>>> +# libtommath
>>> +#
>>> +################################################################################
>>> +
>>> +LIBTOMMATH_VERSION = v1.0
>>> +LIBTOMMATH_SITE = $(call github,libtom,libtommath,$(LIBTOMMATH_VERSION))
>>
>> why don't you take official release tarballs? The same for libtomcrypt
>>
>
> on http://www.libtom.net/, all links are on Github:
> - https://github.com/libtom/libtomcrypt/tree/1.17
> - https://github.com/libtom/libtomcrypt/releases/download/1.17/crypt-1.17.tar.bz2
> - https://github.com/libtom/libtommath/tree/v1.0
> - https://github.com/libtom/libtommath/releases/download/v1.0/ltm-1.0.tar.xz
>
> and as far I know, the Github helper is not reliable for hash.
as far as I know, it is reliable and we have hash files for all github
packages in Buildroot. See package/a10dist for instance.
But, if you use the released tarballs (even if they are hosted in
github), you will not need to use the github helper. Just:
LIBTOMMATH_VERSION = 1.0
LIBTOMMATH_SITE =
https://github.com/libtom/libtommath/releases/download/v$(LIBTOMMATH_VERSION)
LIBTOMMATH_SOURCE = ltm-$(LIBTOMMATH_VERSION).tar.xz
Regards,
Vincent.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-04-01 10:21 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-01 8:07 [Buildroot] [PATCH 1/3] libtommath: new package Francois Perrad
2016-04-01 8:07 ` [Buildroot] [PATCH 2/3] libtomcrypt: " Francois Perrad
2016-04-01 8:07 ` [Buildroot] [PATCH 3/3] dropbear: use libtomath & libtomcrypt Francois Perrad
2016-04-01 8:42 ` Baruch Siach
2016-04-01 9:14 ` François Perrad
2016-04-01 8:19 ` [Buildroot] [PATCH 1/3] libtommath: new package Yegor Yefremov
2016-04-01 9:11 ` François Perrad
2016-04-01 10:17 ` Yegor Yefremov
2016-04-01 10:21 ` Vicente Olivert Riera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox