* [Buildroot] [PATCH] xdriver_x86-input-joystick: Install server config
@ 2016-04-12 5:37 Ezequiel Garcia
2016-04-12 22:31 ` Arnout Vandecappelle
2016-04-12 22:51 ` [Buildroot] [PATCH v2] " Ezequiel Garcia
0 siblings, 2 replies; 6+ messages in thread
From: Ezequiel Garcia @ 2016-04-12 5:37 UTC (permalink / raw)
To: buildroot
In order for joysticks to be detected and used with this
driver, we need an xorg-server configuration file. This commit
installs such conf file to the default X11 xorg.conf.d path,
so we can at least provide a working template.
Users with specific needs can of course override it.
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
---
package/x11r7/xdriver_xf86-input-joystick/50-joystick.conf | 6 ++++++
.../xdriver_xf86-input-joystick/xdriver_xf86-input-joystick.mk | 8 ++++++++
2 files changed, 14 insertions(+)
create mode 100644 package/x11r7/xdriver_xf86-input-joystick/50-joystick.conf
diff --git a/package/x11r7/xdriver_xf86-input-joystick/50-joystick.conf b/package/x11r7/xdriver_xf86-input-joystick/50-joystick.conf
new file mode 100644
index 000000000000..95a295ab0010
--- /dev/null
+++ b/package/x11r7/xdriver_xf86-input-joystick/50-joystick.conf
@@ -0,0 +1,6 @@
+Section "InputClass"
+ Identifier "joystick catchall"
+ MatchIsJoystick "on"
+ MatchDevicePath "/dev/input/event*"
+ Driver "joystick"
+EndSection
diff --git a/package/x11r7/xdriver_xf86-input-joystick/xdriver_xf86-input-joystick.mk b/package/x11r7/xdriver_xf86-input-joystick/xdriver_xf86-input-joystick.mk
index c63312dd099f..8054743af038 100644
--- a/package/x11r7/xdriver_xf86-input-joystick/xdriver_xf86-input-joystick.mk
+++ b/package/x11r7/xdriver_xf86-input-joystick/xdriver_xf86-input-joystick.mk
@@ -11,4 +11,12 @@ XDRIVER_XF86_INPUT_JOYSTICK_LICENSE = MIT
XDRIVER_XF86_INPUT_JOYSTICK_LICENSE_FILES = COPYING
XDRIVER_XF86_INPUT_JOYSTICK_DEPENDENCIES = xserver_xorg-server xproto_inputproto xproto_randrproto xproto_xproto
+define XDRIVER_XF86_INPUT_JOYSTICK_CONF
+ $(INSTALL) -m 0644 -D \
+ package/x11r7/xdriver_xf86-input-joystick/50-joystick.conf \
+ $(TARGET_DIR)/usr/share/X11/xorg.conf.d/
+
+endef
+XDRIVER_XF86_INPUT_JOYSTICK_POST_INSTALL_TARGET_HOOKS += XDRIVER_XF86_INPUT_JOYSTICK_CONF
+
$(eval $(autotools-package))
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] xdriver_x86-input-joystick: Install server config
2016-04-12 5:37 [Buildroot] [PATCH] xdriver_x86-input-joystick: Install server config Ezequiel Garcia
@ 2016-04-12 22:31 ` Arnout Vandecappelle
2016-04-12 22:51 ` [Buildroot] [PATCH v2] " Ezequiel Garcia
1 sibling, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2016-04-12 22:31 UTC (permalink / raw)
To: buildroot
On 04/12/16 07:37, Ezequiel Garcia wrote:
> In order for joysticks to be detected and used with this
> driver, we need an xorg-server configuration file. This commit
> installs such conf file to the default X11 xorg.conf.d path,
> so we can at least provide a working template.
>
> Users with specific needs can of course override it.
>
> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> ---
> package/x11r7/xdriver_xf86-input-joystick/50-joystick.conf | 6 ++++++
> .../xdriver_xf86-input-joystick/xdriver_xf86-input-joystick.mk | 8 ++++++++
> 2 files changed, 14 insertions(+)
> create mode 100644 package/x11r7/xdriver_xf86-input-joystick/50-joystick.conf
>
> diff --git a/package/x11r7/xdriver_xf86-input-joystick/50-joystick.conf b/package/x11r7/xdriver_xf86-input-joystick/50-joystick.conf
> new file mode 100644
> index 000000000000..95a295ab0010
> --- /dev/null
> +++ b/package/x11r7/xdriver_xf86-input-joystick/50-joystick.conf
> @@ -0,0 +1,6 @@
> +Section "InputClass"
> + Identifier "joystick catchall"
> + MatchIsJoystick "on"
> + MatchDevicePath "/dev/input/event*"
> + Driver "joystick"
> +EndSection
> diff --git a/package/x11r7/xdriver_xf86-input-joystick/xdriver_xf86-input-joystick.mk b/package/x11r7/xdriver_xf86-input-joystick/xdriver_xf86-input-joystick.mk
> index c63312dd099f..8054743af038 100644
> --- a/package/x11r7/xdriver_xf86-input-joystick/xdriver_xf86-input-joystick.mk
> +++ b/package/x11r7/xdriver_xf86-input-joystick/xdriver_xf86-input-joystick.mk
> @@ -11,4 +11,12 @@ XDRIVER_XF86_INPUT_JOYSTICK_LICENSE = MIT
> XDRIVER_XF86_INPUT_JOYSTICK_LICENSE_FILES = COPYING
> XDRIVER_XF86_INPUT_JOYSTICK_DEPENDENCIES = xserver_xorg-server xproto_inputproto xproto_randrproto xproto_xproto
>
> +define XDRIVER_XF86_INPUT_JOYSTICK_CONF
> + $(INSTALL) -m 0644 -D \
> + package/x11r7/xdriver_xf86-input-joystick/50-joystick.conf \
> + $(TARGET_DIR)/usr/share/X11/xorg.conf.d/
With -D, you should put the target filename as well, so
$(INSTALL) -m 0644 -D \
package/x11r7/xdriver_xf86-input-joystick/50-joystick.conf \
$(TARGET_DIR)/usr/share/X11/xorg.conf.d/50-joystick.conf
With that:
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> +
> +endef
> +XDRIVER_XF86_INPUT_JOYSTICK_POST_INSTALL_TARGET_HOOKS += XDRIVER_XF86_INPUT_JOYSTICK_CONF
> +
> $(eval $(autotools-package))
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] xdriver_x86-input-joystick: Install server config
2016-04-12 5:37 [Buildroot] [PATCH] xdriver_x86-input-joystick: Install server config Ezequiel Garcia
2016-04-12 22:31 ` Arnout Vandecappelle
@ 2016-04-12 22:51 ` Ezequiel Garcia
2016-04-13 20:14 ` Thomas Petazzoni
1 sibling, 1 reply; 6+ messages in thread
From: Ezequiel Garcia @ 2016-04-12 22:51 UTC (permalink / raw)
To: buildroot
In order for joysticks to be detected and used with this
driver, we need an xorg-server configuration file. This commit
installs such conf file to the default X11 xorg.conf.d path,
so we can at least provide a working template.
Users with specific needs can of course override it.
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/x11r7/xdriver_xf86-input-joystick/50-joystick.conf | 6 ++++++
.../xdriver_xf86-input-joystick/xdriver_xf86-input-joystick.mk | 8 ++++++++
2 files changed, 14 insertions(+)
create mode 100644 package/x11r7/xdriver_xf86-input-joystick/50-joystick.conf
diff --git a/package/x11r7/xdriver_xf86-input-joystick/50-joystick.conf b/package/x11r7/xdriver_xf86-input-joystick/50-joystick.conf
new file mode 100644
index 000000000000..95a295ab0010
--- /dev/null
+++ b/package/x11r7/xdriver_xf86-input-joystick/50-joystick.conf
@@ -0,0 +1,6 @@
+Section "InputClass"
+ Identifier "joystick catchall"
+ MatchIsJoystick "on"
+ MatchDevicePath "/dev/input/event*"
+ Driver "joystick"
+EndSection
diff --git a/package/x11r7/xdriver_xf86-input-joystick/xdriver_xf86-input-joystick.mk b/package/x11r7/xdriver_xf86-input-joystick/xdriver_xf86-input-joystick.mk
index c63312dd099f..67144eda652b 100644
--- a/package/x11r7/xdriver_xf86-input-joystick/xdriver_xf86-input-joystick.mk
+++ b/package/x11r7/xdriver_xf86-input-joystick/xdriver_xf86-input-joystick.mk
@@ -11,4 +11,12 @@ XDRIVER_XF86_INPUT_JOYSTICK_LICENSE = MIT
XDRIVER_XF86_INPUT_JOYSTICK_LICENSE_FILES = COPYING
XDRIVER_XF86_INPUT_JOYSTICK_DEPENDENCIES = xserver_xorg-server xproto_inputproto xproto_randrproto xproto_xproto
+define XDRIVER_XF86_INPUT_JOYSTICK_CONF
+ $(INSTALL) -m 0644 -D \
+ package/x11r7/xdriver_xf86-input-joystick/50-joystick.conf \
+ $(TARGET_DIR)/usr/share/X11/xorg.conf.d/50-joystick.conf
+
+endef
+XDRIVER_XF86_INPUT_JOYSTICK_POST_INSTALL_TARGET_HOOKS += XDRIVER_XF86_INPUT_JOYSTICK_CONF
+
$(eval $(autotools-package))
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] xdriver_x86-input-joystick: Install server config
2016-04-12 22:51 ` [Buildroot] [PATCH v2] " Ezequiel Garcia
@ 2016-04-13 20:14 ` Thomas Petazzoni
2016-04-14 12:42 ` Ezequiel Garcia
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2016-04-13 20:14 UTC (permalink / raw)
To: buildroot
Hello,
First of all, your patch, as taken from patchwork, had a mismatch
between the From: and the Signed-off-by. Indeed, the From uses ? in
your last name, while the Signed-off-by uses the regular i.
The problem is that patchwork has recorded that in the past you were
sending your e-mails with Garc?a, so even if nowadays you sent them
with Garcia, it keeps using Garc?a when doing "git pwam", leading to
this inconsistency. I wouldn't have noticed if there wasn't this silly
git hook checking for such things, which complained:
remote: Refusing to update refs/heads/master:
remote: 4470abb693967f6bcf0828f50f9a32562adb85af..65933ad61df36ac32b7a9405aa7f674cd76a4ac2
remote:
remote: Missing Author's Signed-off-by tag
remote:
Another comment is: when you send a v2, please include a changelog from
the previous version. Some more comments below.
On Tue, 12 Apr 2016 19:51:36 -0300, Ezequiel Garcia wrote:
> +define XDRIVER_XF86_INPUT_JOYSTICK_CONF
> + $(INSTALL) -m 0644 -D \
> + package/x11r7/xdriver_xf86-input-joystick/50-joystick.conf \
You should have used $(XDRIVER_XF86_INPUT_JOYSTICK_PKGDIR) instead.
> + $(TARGET_DIR)/usr/share/X11/xorg.conf.d/50-joystick.conf
> +
This empty line was useless.
> +endef
> +XDRIVER_XF86_INPUT_JOYSTICK_POST_INSTALL_TARGET_HOOKS += XDRIVER_XF86_INPUT_JOYSTICK_CONF
I've fixed up those minor issues and applied. Please test what I've
committed to make sure I didn't introduce a typo.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] xdriver_x86-input-joystick: Install server config
2016-04-13 20:14 ` Thomas Petazzoni
@ 2016-04-14 12:42 ` Ezequiel Garcia
2016-04-14 13:05 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Ezequiel Garcia @ 2016-04-14 12:42 UTC (permalink / raw)
To: buildroot
Thomas,
On 13 April 2016 at 17:14, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> First of all, your patch, as taken from patchwork, had a mismatch
> between the From: and the Signed-off-by. Indeed, the From uses ? in
> your last name, while the Signed-off-by uses the regular i.
>
Yes, I stumbled across this in the past.
Who's behind patchwork, so I can ask for a name change on my account?
--
Ezequiel Garc?a, VanguardiaSur
www.vanguardiasur.com.ar
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-04-14 13:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-12 5:37 [Buildroot] [PATCH] xdriver_x86-input-joystick: Install server config Ezequiel Garcia
2016-04-12 22:31 ` Arnout Vandecappelle
2016-04-12 22:51 ` [Buildroot] [PATCH v2] " Ezequiel Garcia
2016-04-13 20:14 ` Thomas Petazzoni
2016-04-14 12:42 ` Ezequiel Garcia
2016-04-14 13:05 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox