* [Buildroot] [PATCH] x264: needs mmu
@ 2016-05-02 12:44 Gustavo Zacarias
2016-05-02 15:23 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Gustavo Zacarias @ 2016-05-02 12:44 UTC (permalink / raw)
To: buildroot
Uses madvise() which is not available in NOMMU. Fixes:
http://autobuild.buildroot.net/results/837/837fd5a63d59b5c65818ec005a565cb7741a1cdd/
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
package/x264/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/x264/Config.in b/package/x264/Config.in
index be3ab3f..d042ddc 100644
--- a/package/x264/Config.in
+++ b/package/x264/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_X264
bool "x264"
+ depends on BR2_USE_MMU # madvise()
help
x264 is a free software library and application for
encoding video streams into the H.264/MPEG-4 AVC
--
2.7.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] x264: needs mmu
2016-05-02 12:44 [Buildroot] [PATCH] x264: needs mmu Gustavo Zacarias
@ 2016-05-02 15:23 ` Peter Korsgaard
2016-05-02 15:26 ` Gustavo Zacarias
0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2016-05-02 15:23 UTC (permalink / raw)
To: buildroot
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:
> Uses madvise() which is not available in NOMMU. Fixes:
> http://autobuild.buildroot.net/results/837/837fd5a63d59b5c65818ec005a565cb7741a1cdd/
Hmm, is that really generally true? I don't quite see why you cannot
have madvise() without mmu. Looking at uClibc-ng, the option enabling
madvise support doesn't depend on MMU support.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] x264: needs mmu
2016-05-02 15:23 ` Peter Korsgaard
@ 2016-05-02 15:26 ` Gustavo Zacarias
2016-05-02 15:37 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Gustavo Zacarias @ 2016-05-02 15:26 UTC (permalink / raw)
To: buildroot
On 02/05/16 12:23, Peter Korsgaard wrote:
> Hmm, is that really generally true? I don't quite see why you cannot
> have madvise() without mmu. Looking at uClibc-ng, the option enabling
> madvise support doesn't depend on MMU support.
I've based the rule on previous 80b9dfce, 5b309e1a and 8d446718
scenarios and didn't investigate myself.
Regards.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] x264: needs mmu
2016-05-02 15:26 ` Gustavo Zacarias
@ 2016-05-02 15:37 ` Peter Korsgaard
2016-05-02 15:42 ` Gustavo Zacarias
2016-05-02 19:45 ` Peter Korsgaard
0 siblings, 2 replies; 6+ messages in thread
From: Peter Korsgaard @ 2016-05-02 15:37 UTC (permalink / raw)
To: buildroot
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:
> On 02/05/16 12:23, Peter Korsgaard wrote:
>> Hmm, is that really generally true? I don't quite see why you cannot
>> have madvise() without mmu. Looking at uClibc-ng, the option enabling
>> madvise support doesn't depend on MMU support.
> I've based the rule on previous 80b9dfce, 5b309e1a and 8d446718
> scenarios and didn't investigate myself.
Ok - Thomas, do you know if madvise generally isn't available or if it
is something specific to the binary bfin toolchain?
I'll kick off a build with our new stm32f defconfig and look.
--
Venlig hilsen,
Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] x264: needs mmu
2016-05-02 15:37 ` Peter Korsgaard
@ 2016-05-02 15:42 ` Gustavo Zacarias
2016-05-02 19:45 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Gustavo Zacarias @ 2016-05-02 15:42 UTC (permalink / raw)
To: buildroot
On 02/05/16 12:37, Peter Korsgaard wrote:
> Ok - Thomas, do you know if madvise generally isn't available or if it
> is something specific to the binary bfin toolchain?
>
> I'll kick off a build with our new stm32f defconfig and look.
Ostensibly madvise() can be thrown away if the target doesn't support
it, though it would require submitting a bunch of patches upstream ;)
Regards.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] x264: needs mmu
2016-05-02 15:37 ` Peter Korsgaard
2016-05-02 15:42 ` Gustavo Zacarias
@ 2016-05-02 19:45 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2016-05-02 19:45 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:
>> On 02/05/16 12:23, Peter Korsgaard wrote:
>>> Hmm, is that really generally true? I don't quite see why you cannot
>>> have madvise() without mmu. Looking at uClibc-ng, the option enabling
>>> madvise support doesn't depend on MMU support.
>> I've based the rule on previous 80b9dfce, 5b309e1a and 8d446718
>> scenarios and didn't investigate myself.
> Ok - Thomas, do you know if madvise generally isn't available or if it
> is something specific to the binary bfin toolchain?
> I'll kick off a build with our new stm32f defconfig and look.
As expected, building stm32f429_disco_defconfig with x264 works:
arm-linux-nm staging/usr/lib/libc.a | egrep 'fork|madvise'
vfork.o:
00000000 T __GI_vfork
00000000 W vfork
00000000 T __vfork
madvise.o:
00000000 T madvise
posix_madvise.o:
00000000 T posix_madvise
U __GI_vfork
00000000 T _fork_parent
U __GI_vfork
So I'll change it to simply disable for that bfin toolchain instead.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-05-02 19:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-02 12:44 [Buildroot] [PATCH] x264: needs mmu Gustavo Zacarias
2016-05-02 15:23 ` Peter Korsgaard
2016-05-02 15:26 ` Gustavo Zacarias
2016-05-02 15:37 ` Peter Korsgaard
2016-05-02 15:42 ` Gustavo Zacarias
2016-05-02 19:45 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox