[Buildroot] How to enable rtmp support in gst1-plugins-bad?

[Buildroot] How to enable rtmp support in gst1-plugins-bad?

[sonntex]

I did not find rtmp support in gst1-plugins-bad. There is only rtp support.
So, I think that it is a misprint. Is it? Patch looks like:

diff --git a/package/gstreamer1/gst1-plugins-bad/Config.in
b/package/gstreamer1/gst1-plugins-bad/Config.in
index a9667af..afbe2bf 100644
--- a/package/gstreamer1/gst1-plugins-bad/Config.in
+++ b/package/gstreamer1/gst1-plugins-bad/Config.in
@@ -382,8 +382,8 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_REMOVESILENCE
        help
          Removes silence from an audio stream

-config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTP
-       bool "rtp"
+config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTMP
+       bool "rtmp"

 config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SDI
        bool "sdi"
diff --git a/package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk
b/package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk
index a92c4a6..30c4999 100644
--- a/package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk
+++ b/package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk
@@ -479,10 +479,11 @@ else
 GST1_PLUGINS_BAD_CONF_OPTS += --disable-removesilence
 endif

-ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTP),y)
-GST1_PLUGINS_BAD_CONF_OPTS += --enable-rtp
+ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTMP),y)
+GST1_PLUGINS_BAD_CONF_OPTS += --enable-rtmp
+GST1_PLUGINS_BAD_DEPENDENCIES += rtmpdump
 else
-GST1_PLUGINS_BAD_CONF_OPTS += --disable-rtp
+GST1_PLUGINS_BAD_CONF_OPTS += --disable-rtmp
 endif

 ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SDI),y)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160503/d6c11040/attachment.html>

[Buildroot] How to enable rtmp support in gst1-plugins-bad?

[Gustavo Zacarias]

On 03/05/16 09:14, sonntex wrote:

> I did not find rtmp support in gst1-plugins-bad. There is only rtp
> support. So, I think that it is a misprint. Is it? Patch looks like:

Hi.
This looks accurate, care to resend the patch with a SoB line and a nice 
subject for the patch?
Thanks!
Regards.

[Buildroot] How to enable rtmp support in gst1-plugins-bad?

[Peter Seiderer]

Hello sonntex,

On Tue, 3 May 2016 15:14:05 +0300, sonntex <sonntex@gmail.com> wrote:

> I did not find rtmp support in gst1-plugins-bad. There is only rtp support.
> So, I think that it is a misprint. Is it? Patch looks like:

No misprint, only a missing update  since version bump to 1.8.0.

Rtp support was moved from gst-plugins-bad to gst-plugins-good (see [1]),
same with mpg123 support, moved from -bad to -ugly (see [2])...

Time to do a re-check of the options for 1.8.x, but did not yet find the
time for it....

Regards,
Peter

[1] https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/configure.ac?id=f649e85bc9e6c6f52abcdd9fe1e5de670b0f580e
[2] https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/configure.ac?id=08d8aefcdaaf89ecb6dd53ec1e4f95cd42d01664

> 
> diff --git a/package/gstreamer1/gst1-plugins-bad/Config.in
> b/package/gstreamer1/gst1-plugins-bad/Config.in
> index a9667af..afbe2bf 100644
> --- a/package/gstreamer1/gst1-plugins-bad/Config.in
> +++ b/package/gstreamer1/gst1-plugins-bad/Config.in
> @@ -382,8 +382,8 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_REMOVESILENCE
>         help
>           Removes silence from an audio stream
> 
> -config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTP
> -       bool "rtp"
> +config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTMP
> +       bool "rtmp"
> 
>  config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SDI
>         bool "sdi"
> diff --git a/package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk
> b/package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk
> index a92c4a6..30c4999 100644
> --- a/package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk
> +++ b/package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk
> @@ -479,10 +479,11 @@ else
>  GST1_PLUGINS_BAD_CONF_OPTS += --disable-removesilence
>  endif
> 
> -ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTP),y)
> -GST1_PLUGINS_BAD_CONF_OPTS += --enable-rtp
> +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTMP),y)
> +GST1_PLUGINS_BAD_CONF_OPTS += --enable-rtmp
> +GST1_PLUGINS_BAD_DEPENDENCIES += rtmpdump
>  else
> -GST1_PLUGINS_BAD_CONF_OPTS += --disable-rtp
> +GST1_PLUGINS_BAD_CONF_OPTS += --disable-rtmp
>  endif
> 
>  ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SDI),y)

[Buildroot] How to enable rtmp support in gst1-plugins-bad?

[Gustavo Zacarias]

On 03/05/16 15:46, Peter Seiderer wrote:

> Hello sonntex,
>
> On Tue, 3 May 2016 15:14:05 +0300, sonntex <sonntex@gmail.com> wrote:
>
>> I did not find rtmp support in gst1-plugins-bad. There is only rtp support.
>> So, I think that it is a misprint. Is it? Patch looks like:
>
> No misprint, only a missing update  since version bump to 1.8.0.
>
> Rtp support was moved from gst-plugins-bad to gst-plugins-good (see [1]),
> same with mpg123 support, moved from -bad to -ugly (see [2])...
>
> Time to do a re-check of the options for 1.8.x, but did not yet find the
> time for it....
>
> Regards,
> Peter
>
> [1] https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/configure.ac?id=f649e85bc9e6c6f52abcdd9fe1e5de670b0f580e
> [2] https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/configure.ac?id=08d8aefcdaaf89ecb6dd53ec1e4f95cd42d01664

Hi Peter.
Argh, i missed the move, probably because i looked into configure and/or 
NEWS rather than commits/relnotes.
Do you want to pick up these removals, moves and legacy or shall i?
It would be good to have this sorted out for the upcoming release.
Thanks.
Regards.

[Buildroot] How to enable rtmp support in gst1-plugins-bad?

[Peter Seiderer]

Hello Gustavo,

On Tue, 3 May 2016 15:55:20 -0300, Gustavo Zacarias <gustavo@zacarias.com.ar> wrote:

> On 03/05/16 15:46, Peter Seiderer wrote:
> 
> > Hello sonntex,
> >
> > On Tue, 3 May 2016 15:14:05 +0300, sonntex <sonntex@gmail.com> wrote:
> >
> >> I did not find rtmp support in gst1-plugins-bad. There is only rtp support.
> >> So, I think that it is a misprint. Is it? Patch looks like:
> >
> > No misprint, only a missing update  since version bump to 1.8.0.
> >
> > Rtp support was moved from gst-plugins-bad to gst-plugins-good (see [1]),
> > same with mpg123 support, moved from -bad to -ugly (see [2])...
> >
> > Time to do a re-check of the options for 1.8.x, but did not yet find the
> > time for it....
> >
> > Regards,
> > Peter
> >
> > [1] https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/configure.ac?id=f649e85bc9e6c6f52abcdd9fe1e5de670b0f580e
> > [2] https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/configure.ac?id=08d8aefcdaaf89ecb6dd53ec1e4f95cd42d01664
> 
> Hi Peter.
> Argh, i missed the move, probably because i looked into configure and/or 
> NEWS rather than commits/relnotes.
> Do you want to pick up these removals, moves and legacy or shall i?
> It would be good to have this sorted out for the upcoming release.

No problem (only a little work ;-) ), feel free to pick it up...

Regards,
Peter

> Thanks.
> Regards.

[Buildroot] How to enable rtmp support in gst1-plugins-bad?

[sonntex]

I remade patch using git format-patch. Gustavo, is it what do you want?

[Buildroot] How to enable rtmp support in gst1-plugins-bad?

[Arnout Vandecappelle]

On 05/04/16 13:01, sonntex wrote:
> I remade patch using git format-patch. Gustavo, is it what do you want?

  As explained in the manual, you should also send it with git send-email, to 
avoid whitespace corruption.

>
> From f03e8de9b664f4aec27c1412de6aea6be80288b7 Mon Sep 17 00:00:00 2001
> From: Nikolay Beloborodov <sonntex at gmail.com <mailto:sonntex@gmail.com>>
> Date: Wed, 4 May 2016 17:39:21 +0300
> Subject: gst1-plugins-bad: add rtmp support
>

  Add a Signed-off-by line for yourself.  This is a short way for you to
assert that you are entitled to contribute the patch under buildroot's
GPL license.  See  http://elinux.org/Developer_Certificate_Of_Origin
for more details.

> ---
>  package/gstreamer1/gst1-plugins-bad/Config.in           | 4 ++--
>  package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk
> <http://gst1-plugins-bad.mk> | 7 ++++---
>  2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/package/gstreamer1/gst1-plugins-bad/Config.in
> b/package/gstreamer1/gst1-plugins-bad/Config.in
> index a9667af..afbe2bf 100644
> --- a/package/gstreamer1/gst1-plugins-bad/Config.in
> +++ b/package/gstreamer1/gst1-plugins-bad/Config.in
> @@ -382,8 +382,8 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_REMOVESILENCE
>         help
>           Removes silence from an audio stream
>
> -config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTP
> -       bool "rtp"
> +config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTMP
> +       bool "rtmp"

  In addition, you should add an entry to Config.in.legacy that signals the 
removal of the RTP plugin. Something like:

config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTP
	bool "gst1-plugins-bad rtp plugin moved to gst1-plugins-good"
	select BR2_LEGACY
	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_RTP


  Thanks!

  Regards,
  Arnout

>
>  config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SDI
>         bool "sdi"
> diff --git a/package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk
> <http://gst1-plugins-bad.mk>
> b/package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk
> <http://gst1-plugins-bad.mk>
> index a92c4a6..30c4999 100644
> --- a/package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk
> <http://gst1-plugins-bad.mk>
> +++ b/package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk
> <http://gst1-plugins-bad.mk>
> @@ -479,10 +479,11 @@ else
>  GST1_PLUGINS_BAD_CONF_OPTS += --disable-removesilence
>  endif
>
> -ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTP),y)
> -GST1_PLUGINS_BAD_CONF_OPTS += --enable-rtp
> +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RTMP),y)
> +GST1_PLUGINS_BAD_CONF_OPTS += --enable-rtmp
> +GST1_PLUGINS_BAD_DEPENDENCIES += rtmpdump
>  else
> -GST1_PLUGINS_BAD_CONF_OPTS += --disable-rtp
> +GST1_PLUGINS_BAD_CONF_OPTS += --disable-rtmp
>  endif
>
>  ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SDI),y)


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF