[Buildroot] [PATCH] valgrind: disable for MIPS soft-float

[Buildroot] [PATCH] valgrind: disable for MIPS soft-float

[Vicente Olivert Riera]

As stated here [1], recent changes on the MIPS binutils sources have
made it necessary for GCC to pass the -msoft-float to the assembler. Due
to that, valgrind fails to build for MIPS soft-float when using a
version of binutils >= 2.25 because its using some hard-float
instructions.

However, we cannot just disable it for the soft-float and binutils >=
2.25 combination since external toolchains don't provide information
about the binutils version they use. So, instead, we simply disable it
for soft-float.

1: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg00905.html

Fixes:
  http://autobuild.buildroot.net/results/5f5/5f576c7f8d56058a19ed0e7ff4b1ec620bcafb65/

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/valgrind/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
index 21b2608..40e219d 100644
--- a/package/valgrind/Config.in
+++ b/package/valgrind/Config.in
@@ -8,6 +8,7 @@ config BR2_PACKAGE_VALGRIND
 		   BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \
 		   BR2_x86_64
 	depends on !BR2_STATIC_LIBS
+	depends on !BR2_MIPS_SOFT_FLOAT
 	help
 	  Tool for debugging and profiling Linux programs.
 
-- 
2.7.3

[Buildroot] [PATCH] valgrind: disable for MIPS soft-float

[Thomas Petazzoni]

Hello,

On Mon, 23 May 2016 12:31:51 +0100, Vicente Olivert Riera wrote:

> diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
> index 21b2608..40e219d 100644
> --- a/package/valgrind/Config.in
> +++ b/package/valgrind/Config.in
> @@ -8,6 +8,7 @@ config BR2_PACKAGE_VALGRIND
>  		   BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \
>  		   BR2_x86_64
>  	depends on !BR2_STATIC_LIBS
> +	depends on !BR2_MIPS_SOFT_FLOAT

I am wondering if it isn't better to do:

        depends on BR2_ARM_CPU_ARMV7A || BR2_i386 || \
-                  BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \
+                  ((BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el) && !BR2_MIPS_SOFT_FLOAT) || \
                   BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \
                   BR2_x86_64

But I'm not sure. It's completely equivalent from a functionality point
of view, I'm just wondering which one is more logical.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] valgrind: disable for MIPS soft-float

[Vicente Olivert Riera]

Hi Thomas,

On 23/05/16 12:55, Thomas Petazzoni wrote:
> Hello,
> 
> On Mon, 23 May 2016 12:31:51 +0100, Vicente Olivert Riera wrote:
> 
>> diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
>> index 21b2608..40e219d 100644
>> --- a/package/valgrind/Config.in
>> +++ b/package/valgrind/Config.in
>> @@ -8,6 +8,7 @@ config BR2_PACKAGE_VALGRIND
>>  		   BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \
>>  		   BR2_x86_64
>>  	depends on !BR2_STATIC_LIBS
>> +	depends on !BR2_MIPS_SOFT_FLOAT
> 
> I am wondering if it isn't better to do:
> 
>         depends on BR2_ARM_CPU_ARMV7A || BR2_i386 || \
> -                  BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \
> +                  ((BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el) && !BR2_MIPS_SOFT_FLOAT) || \
>                    BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \
>                    BR2_x86_64
> 
> But I'm not sure. It's completely equivalent from a functionality point
> of view, I'm just wondering which one is more logical.

I prefer mine.

We have architecture support in one block, and features support in
another one. More readable IMHO.

Anyway, you can commit whichever you want as at the end of the day they
will have the same functionality.

Regards,

Vincent.

> Thomas
> 

[Buildroot] [PATCH] valgrind: disable for MIPS soft-float

[Peter Korsgaard]

>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:

 > As stated here [1], recent changes on the MIPS binutils sources have
 > made it necessary for GCC to pass the -msoft-float to the assembler. Due
 > to that, valgrind fails to build for MIPS soft-float when using a
 > version of binutils >= 2.25 because its using some hard-float
 > instructions.

 > However, we cannot just disable it for the soft-float and binutils >=
 > 2.25 combination since external toolchains don't provide information
 > about the binutils version they use. So, instead, we simply disable it
 > for soft-float.

 > 1: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg00905.html

 > Fixes:
 >   http://autobuild.buildroot.net/results/5f5/5f576c7f8d56058a19ed0e7ff4b1ec620bcafb65/

 > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard