Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "André Hentschel" <nerv@dawncrow.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] fftw: Disable combined threads when building with OpenMP support
Date: Sun, 29 May 2016 15:01:59 +0200	[thread overview]
Message-ID: <574AE847.9020705@dawncrow.de> (raw)
In-Reply-To: <1464366101-637-1-git-send-email-nerv@dawncrow.de>

Hi,

Some notes on my patch:
Without it fftw fails to configure when the toolchain has threads and openmp
checking for OpenMP flag of C compiler... -fopenmp
configure: error: --with-combined-threads incompatible with --enable-openmp

I'm not sure if my approach is what you would have in mind...
should I rather use ifeq,else,endif as in the block above
or do you have a good suggestion to make --with-combined-threads mutual exclusive between threads and openmp?


Am 27.05.2016 um 18:21 schrieb Andr? Hentschel:
> Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>
> ---
>  package/fftw/fftw.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/fftw/fftw.mk b/package/fftw/fftw.mk
> index 5045ab6..f4b1794 100644
> --- a/package/fftw/fftw.mk
> +++ b/package/fftw/fftw.mk
> @@ -35,7 +35,7 @@ FFTW_CONF_OPTS += --enable-threads --with-combined-threads
>  else
>  FFTW_CONF_OPTS += --disable-threads
>  endif
> -FFTW_CONF_OPTS += $(if $(BR2_GCC_ENABLE_OPENMP),--enable,--disable)-openmp
> +FFTW_CONF_OPTS += $(if $(BR2_GCC_ENABLE_OPENMP),--without-combined-threads --enable,--disable)-openmp
>  
>  FFTW_CONF_OPTS += CFLAGS="$(FFTW_CFLAGS)"
>  
> 

      reply	other threads:[~2016-05-29 13:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-27 16:21 [Buildroot] [PATCH] fftw: Disable combined threads when building with OpenMP support André Hentschel
2016-05-29 13:01 ` André Hentschel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=574AE847.9020705@dawncrow.de \
    --to=nerv@dawncrow.de \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox