Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] fftw: Disable combined threads when building with OpenMP support
@ 2016-05-27 16:21 André Hentschel
  2016-05-29 13:01 ` André Hentschel
  0 siblings, 1 reply; 2+ messages in thread
From: André Hentschel @ 2016-05-27 16:21 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>
---
 package/fftw/fftw.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/fftw/fftw.mk b/package/fftw/fftw.mk
index 5045ab6..f4b1794 100644
--- a/package/fftw/fftw.mk
+++ b/package/fftw/fftw.mk
@@ -35,7 +35,7 @@ FFTW_CONF_OPTS += --enable-threads --with-combined-threads
 else
 FFTW_CONF_OPTS += --disable-threads
 endif
-FFTW_CONF_OPTS += $(if $(BR2_GCC_ENABLE_OPENMP),--enable,--disable)-openmp
+FFTW_CONF_OPTS += $(if $(BR2_GCC_ENABLE_OPENMP),--without-combined-threads --enable,--disable)-openmp
 
 FFTW_CONF_OPTS += CFLAGS="$(FFTW_CFLAGS)"
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] fftw: Disable combined threads when building with OpenMP support
  2016-05-27 16:21 [Buildroot] [PATCH] fftw: Disable combined threads when building with OpenMP support André Hentschel
@ 2016-05-29 13:01 ` André Hentschel
  0 siblings, 0 replies; 2+ messages in thread
From: André Hentschel @ 2016-05-29 13:01 UTC (permalink / raw)
  To: buildroot

Hi,

Some notes on my patch:
Without it fftw fails to configure when the toolchain has threads and openmp
checking for OpenMP flag of C compiler... -fopenmp
configure: error: --with-combined-threads incompatible with --enable-openmp

I'm not sure if my approach is what you would have in mind...
should I rather use ifeq,else,endif as in the block above
or do you have a good suggestion to make --with-combined-threads mutual exclusive between threads and openmp?


Am 27.05.2016 um 18:21 schrieb Andr? Hentschel:
> Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>
> ---
>  package/fftw/fftw.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/fftw/fftw.mk b/package/fftw/fftw.mk
> index 5045ab6..f4b1794 100644
> --- a/package/fftw/fftw.mk
> +++ b/package/fftw/fftw.mk
> @@ -35,7 +35,7 @@ FFTW_CONF_OPTS += --enable-threads --with-combined-threads
>  else
>  FFTW_CONF_OPTS += --disable-threads
>  endif
> -FFTW_CONF_OPTS += $(if $(BR2_GCC_ENABLE_OPENMP),--enable,--disable)-openmp
> +FFTW_CONF_OPTS += $(if $(BR2_GCC_ENABLE_OPENMP),--without-combined-threads --enable,--disable)-openmp
>  
>  FFTW_CONF_OPTS += CFLAGS="$(FFTW_CFLAGS)"
>  
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-05-29 13:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-27 16:21 [Buildroot] [PATCH] fftw: Disable combined threads when building with OpenMP support André Hentschel
2016-05-29 13:01 ` André Hentschel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox