Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/cifs-utils: remove NO_WERROR hook
@ 2026-06-20 15:02 Bernd Kuhls
  2026-06-20 15:02 ` [Buildroot] [PATCH 2/2] package/cifs-utils: bump version to 7.6 Bernd Kuhls
  2026-07-14 11:08 ` [Buildroot] [PATCH 1/2] package/cifs-utils: remove NO_WERROR hook Julien Olivain via buildroot
  0 siblings, 2 replies; 4+ messages in thread
From: Bernd Kuhls @ 2026-06-20 15:02 UTC (permalink / raw)
  To: buildroot; +Cc: Thomas Petazzoni

Buildroot commit 18bd541dd02b153427fb4f010a6426c8e91bef1b added the hook
to remove -Werror after upstream added it to CFLAGS in version 5.4:
https://git.samba.org/?p=cifs-utils.git;a=commitdiff;h=dc0dd017a856185422d2f3691062737a9e93ecae

Upstream however removed -Werror again in version 5.6
https://git.samba.org/?p=cifs-utils.git;a=commitdiff;h=74edf24d9780900f3ce15d2403c6e331b031d454
This version was bumped in buildroot with commit
839546dd3aaff56f26536ea7373978e32563c473 but the NO_WERROR hook was not
removed until now.

The tarball of version 7.6 does not include Makefile.in anymore which
broke the build of the package. As this hook is not needed anymore it is
removed.

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
Gitlab pipelines passed:
https://gitlab.com/bkuhls/buildroot/-/commits/f73f3d6fa47e362d38c258e823b6bbaaa559e616

 package/cifs-utils/cifs-utils.mk | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/package/cifs-utils/cifs-utils.mk b/package/cifs-utils/cifs-utils.mk
index 9e1e822c4c..58ac594b20 100644
--- a/package/cifs-utils/cifs-utils.mk
+++ b/package/cifs-utils/cifs-utils.mk
@@ -25,12 +25,6 @@ ifeq ($(BR2_PACKAGE_KEYUTILS),y)
 CIFS_UTILS_DEPENDENCIES += keyutils
 endif
 
-define CIFS_UTILS_NO_WERROR
-	$(SED) 's/-Werror//' $(@D)/Makefile.in
-endef
-
-CIFS_UTILS_POST_PATCH_HOOKS += CIFS_UTILS_NO_WERROR
-
 ifeq ($(BR2_PACKAGE_CIFS_UTILS_SMBTOOLS),)
 define CIFS_UTILS_REMOVE_SMBTOOLS
 	rm -f $(TARGET_DIR)/usr/bin/smbinfo
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] package/cifs-utils: bump version to 7.6
  2026-06-20 15:02 [Buildroot] [PATCH 1/2] package/cifs-utils: remove NO_WERROR hook Bernd Kuhls
@ 2026-06-20 15:02 ` Bernd Kuhls
  2026-07-14 11:12   ` Julien Olivain via buildroot
  2026-07-14 11:08 ` [Buildroot] [PATCH 1/2] package/cifs-utils: remove NO_WERROR hook Julien Olivain via buildroot
  1 sibling, 1 reply; 4+ messages in thread
From: Bernd Kuhls @ 2026-06-20 15:02 UTC (permalink / raw)
  To: buildroot; +Cc: Thomas Petazzoni

https://lists.samba.org/archive/samba-technical/2026-June/140908.html

Version 7.5 was not announced separately:
https://wiki.samba.org/index.php/LinuxCIFS_utils
"December, 2025: Release 7.5
 - Various fixes for utilities"
https://git.samba.org/?p=cifs-utils.git;a=shortlog;h=refs/tags/cifs-utils-7.5

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
Gitlab pipelines passed:
https://gitlab.com/bkuhls/buildroot/-/commits/f73f3d6fa47e362d38c258e823b6bbaaa559e616

 package/cifs-utils/cifs-utils.hash | 2 +-
 package/cifs-utils/cifs-utils.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/cifs-utils/cifs-utils.hash b/package/cifs-utils/cifs-utils.hash
index e6a5eefeaa..cfa2a84648 100644
--- a/package/cifs-utils/cifs-utils.hash
+++ b/package/cifs-utils/cifs-utils.hash
@@ -1,5 +1,5 @@
 # Locally calculated after checking pgp signature
-sha256  53353d05c30b4fc9dac006a8f0c5054cdd8a1834c176313c91e4694025c4b891  cifs-utils-7.4.tar.bz2
+sha256  7db875ff2868e5fa4e445ada0bd23ea70b9161b96188c7e276321e061ed51dd6  cifs-utils-7.6.tar.bz2
 
 # Hash for license file:
 sha256  8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903  COPYING
diff --git a/package/cifs-utils/cifs-utils.mk b/package/cifs-utils/cifs-utils.mk
index 58ac594b20..72f432326e 100644
--- a/package/cifs-utils/cifs-utils.mk
+++ b/package/cifs-utils/cifs-utils.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-CIFS_UTILS_VERSION = 7.4
+CIFS_UTILS_VERSION = 7.6
 CIFS_UTILS_SOURCE = cifs-utils-$(CIFS_UTILS_VERSION).tar.bz2
 CIFS_UTILS_SITE = http://ftp.samba.org/pub/linux-cifs/cifs-utils
 CIFS_UTILS_LICENSE = GPL-3.0+
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 1/2] package/cifs-utils: remove NO_WERROR hook
  2026-06-20 15:02 [Buildroot] [PATCH 1/2] package/cifs-utils: remove NO_WERROR hook Bernd Kuhls
  2026-06-20 15:02 ` [Buildroot] [PATCH 2/2] package/cifs-utils: bump version to 7.6 Bernd Kuhls
@ 2026-07-14 11:08 ` Julien Olivain via buildroot
  1 sibling, 0 replies; 4+ messages in thread
From: Julien Olivain via buildroot @ 2026-07-14 11:08 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: buildroot, Thomas Petazzoni

On 20/06/2026 17:02, Bernd Kuhls wrote:
> Buildroot commit 18bd541dd02b153427fb4f010a6426c8e91bef1b added the 
> hook
> to remove -Werror after upstream added it to CFLAGS in version 5.4:
> https://git.samba.org/?p=cifs-utils.git;a=commitdiff;h=dc0dd017a856185422d2f3691062737a9e93ecae
> 
> Upstream however removed -Werror again in version 5.6
> https://git.samba.org/?p=cifs-utils.git;a=commitdiff;h=74edf24d9780900f3ce15d2403c6e331b031d454
> This version was bumped in buildroot with commit
> 839546dd3aaff56f26536ea7373978e32563c473 but the NO_WERROR hook was not
> removed until now.
> 
> The tarball of version 7.6 does not include Makefile.in anymore which
> broke the build of the package. As this hook is not needed anymore it 
> is
> removed.
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

I applied this patch (only) to master, thanks.
See my comment on the patch #2.

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 2/2] package/cifs-utils: bump version to 7.6
  2026-06-20 15:02 ` [Buildroot] [PATCH 2/2] package/cifs-utils: bump version to 7.6 Bernd Kuhls
@ 2026-07-14 11:12   ` Julien Olivain via buildroot
  0 siblings, 0 replies; 4+ messages in thread
From: Julien Olivain via buildroot @ 2026-07-14 11:12 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: buildroot, Thomas Petazzoni

Hi Bernd,

On 20/06/2026 17:02, Bernd Kuhls wrote:
> https://lists.samba.org/archive/samba-technical/2026-June/140908.html
> 
> Version 7.5 was not announced separately:
> https://wiki.samba.org/index.php/LinuxCIFS_utils
> "December, 2025: Release 7.5
>  - Various fixes for utilities"
> https://git.samba.org/?p=cifs-utils.git;a=shortlog;h=refs/tags/cifs-utils-7.5
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
> Gitlab pipelines passed:
> https://gitlab.com/bkuhls/buildroot/-/commits/f73f3d6fa47e362d38c258e823b6bbaaa559e616
> 
>  package/cifs-utils/cifs-utils.hash | 2 +-
>  package/cifs-utils/cifs-utils.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/cifs-utils/cifs-utils.hash 
> b/package/cifs-utils/cifs-utils.hash
> index e6a5eefeaa..cfa2a84648 100644
> --- a/package/cifs-utils/cifs-utils.hash
> +++ b/package/cifs-utils/cifs-utils.hash
> @@ -1,5 +1,5 @@
>  # Locally calculated after checking pgp signature
> -sha256  
> 53353d05c30b4fc9dac006a8f0c5054cdd8a1834c176313c91e4694025c4b891  
> cifs-utils-7.4.tar.bz2
> +sha256  
> 7db875ff2868e5fa4e445ada0bd23ea70b9161b96188c7e276321e061ed51dd6  
> cifs-utils-7.6.tar.bz2

This archive hash is now failing. I have the error:

ERROR: while checking hashes from package/cifs-utils/cifs-utils.hash
ERROR: cifs-utils-7.6.tar.bz2 has wrong sha256 hash:
ERROR: expected: 
7db875ff2868e5fa4e445ada0bd23ea70b9161b96188c7e276321e061ed51dd6
ERROR: got     : 
b8993bc4112af331a2f31c4e1a69bcd32b44c25a8c9fb82c0f38c1ed9a49f28d

Looking at: https://download.samba.org/pub/linux-cifs/cifs-utils/
it seems the archive has been regenerated and resigned on 2026-07-09.

Also, there was a new 7.7 released on that day:
https://lists.samba.org/archive/samba-technical/2026-July/140952.html
So you might consider using this new version.

Could you have a look to what happened and send an updated patch please?

>  # Hash for license file:
>  sha256  
> 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903  
> COPYING

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-07-14 11:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-20 15:02 [Buildroot] [PATCH 1/2] package/cifs-utils: remove NO_WERROR hook Bernd Kuhls
2026-06-20 15:02 ` [Buildroot] [PATCH 2/2] package/cifs-utils: bump version to 7.6 Bernd Kuhls
2026-07-14 11:12   ` Julien Olivain via buildroot
2026-07-14 11:08 ` [Buildroot] [PATCH 1/2] package/cifs-utils: remove NO_WERROR hook Julien Olivain via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox