Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: Changming Huang <jerry.huang@nxp.com>, buildroot@busybox.net
Cc: thomas.petazzoni@bootlin.com, heiko.thiery@gmail.com,
	michael@walle.cc, geomatsi@gmail.com, matthew.weber@collins.com
Subject: Re: [Buildroot] [PATCH v5 8/9] package/nxp/qoriq-rcw: introduce BR2_PACKAGE_HOST_QORIQ_RCW_BOOT_MODE for boot mode
Date: Thu, 6 Jan 2022 16:55:41 +0100	[thread overview]
Message-ID: <62235760-30ce-66a6-fe64-1ab11d3604e3@mind.be> (raw)
In-Reply-To: <20200207083857.28058-8-jerry.huang@nxp.com>



On 07/02/2020 09:38, Changming Huang wrote:
> Introduce BR2_PACKAGE_HOST_QORIQ_RCW_BOOT_MODE for the boot mode.
> Because the RCW binary can be stored in different media, for example:
> sd - RCW locate in SD card, boot the board from SD card
> emmc - RCW locate in eMMC chip, boot the board from eMMC chip
> qspi - RCW locate in QSPI flash, boot the board from QSPI flash
> flexspi_nor - RCW locate in flexSPI, boot the board from flexSPI Nor/Nand flash
> 
> Signed-off-by: Changming Huang <jerry.huang@nxp.com>
> ---
> changes since v4:
> no changes.
> 
> changes since v3:
> 1. split this option from board patch.
> ---
>   package/nxp/qoriq-rcw/Config.in.host | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/package/nxp/qoriq-rcw/Config.in.host b/package/nxp/qoriq-rcw/Config.in.host
> index 9bf55894e8..7f5fbb3202 100644
> --- a/package/nxp/qoriq-rcw/Config.in.host
> +++ b/package/nxp/qoriq-rcw/Config.in.host
> @@ -37,4 +37,10 @@ config BR2_PACKAGE_HOST_QORIQ_RCW_BIN
>   
>   	  If this option is empty, no rcw file is used.
>   
> +config BR2_PACKAGE_HOST_QORIQ_RCW_BOOT_MODE

  You introduce this symbol but it is not used anywhere. So what is the point?

  I marked it as rejected.

  Regards,
  Arnout

> +	string "QorIQ RCW Boot mode"
> +	depends on !BR2_PACKAGE_HOST_QORIQ_RCW_CUSTOM_PATH
> +	help
> +	  Specify the boot mode, for example, sd, emmc, flexspi_nor.
> +
>   endif
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-01-06 15:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07  8:38 [Buildroot] [PATCH v5 1/9] package/nxp: new package directory Changming Huang
2020-02-07  8:38 ` [Buildroot] [PATCH v5 2/9] package/qoriq-rcw: move rcw into nxp and rename it Changming Huang
2020-04-14  9:35   ` Heiko Thiery
2020-12-16 21:02   ` Yann E. MORIN
2020-02-07  8:38 ` [Buildroot] [PATCH v5 3/9] package/qoriq-rcw: bump to version LSDK-19.09 Changming Huang
2020-02-07  8:38 ` [Buildroot] [PATCH v5 4/9] package/qoriq-rcw: add target rcw binary support Changming Huang
2022-01-06 14:48   ` Arnout Vandecappelle
2020-02-07  8:38 ` [Buildroot] [PATCH v5 5/9] boot/arm-trusted-firmware: allow additional make dependencies Changming Huang
2022-01-06 15:05   ` Arnout Vandecappelle
2020-02-07  8:38 ` [Buildroot] [PATCH v5 6/9] package/qoriq-cadence-dp-firmware: new package Changming Huang
2022-01-06 15:14   ` Michael Walle
2022-01-06 15:19   ` Arnout Vandecappelle
2020-02-07  8:38 ` [Buildroot] [PATCH v5 7/9] package/qoriq-rcw:Enable IIC5_PMUX and CLK_OUT_PMUX for GPIO Changming Huang
2022-01-06 15:54   ` Arnout Vandecappelle
2020-02-07  8:38 ` [Buildroot] [PATCH v5 8/9] package/nxp/qoriq-rcw: introduce BR2_PACKAGE_HOST_QORIQ_RCW_BOOT_MODE for boot mode Changming Huang
2022-01-06 15:55   ` Arnout Vandecappelle [this message]
2020-02-07  8:38 ` [Buildroot] [PATCH v5 9/9] board/nxp/ls1028ardb: new board Changming Huang
2022-01-06 16:27   ` Arnout Vandecappelle
2022-01-06 14:45 ` [Buildroot] [PATCH v5 1/9] package/nxp: new package directory Arnout Vandecappelle
2022-01-06 15:00   ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62235760-30ce-66a6-fe64-1ab11d3604e3@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    --cc=geomatsi@gmail.com \
    --cc=heiko.thiery@gmail.com \
    --cc=jerry.huang@nxp.com \
    --cc=matthew.weber@collins.com \
    --cc=michael@walle.cc \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox