Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: Changming Huang <jerry.huang@nxp.com>, buildroot@busybox.net
Cc: michael@walle.cc, matthew.weber@collins.com,
	thomas.petazzoni@bootlin.com, geomatsi@gmail.com,
	heiko.thiery@gmail.com
Subject: Re: [Buildroot] [PATCH v5 7/9] package/qoriq-rcw:Enable IIC5_PMUX and CLK_OUT_PMUX for GPIO
Date: Thu, 6 Jan 2022 16:54:51 +0100	[thread overview]
Message-ID: <835d05ab-20ed-8445-a2ef-285760b215a3@mind.be> (raw)
In-Reply-To: <20200207083857.28058-7-jerry.huang@nxp.com>



On 07/02/2020 09:38, Changming Huang wrote:
> From: Jerry Huang <jerry.huang@nxp.com>
> 
> Because GPIO is used as interrupt for eNETC PHY and Micro-bus,
> IIC5_PMUX and CLK_OUT_PMUX are enabled for GPIO.

  This sounds like something really board specific, which should be applied 
upstream first and lacking that, it's IMHO better to use BR2_GLOBAL_PATCH_DIR 
and do it in the board-specific defconfig instead of patching qoriq-rcw package.

  In addition, qoriq-rcw has been updated so the patch maybe doesn't apply any more.

  Therefore, I marked this one as Rejected.

  Regards,
  Arnout

> 
> Signed-off-by: Jerry Huang <jerry.huang@nxp.com>
> ---
> changes since v4:
> no changes.
> 
> changes since v3:
> no changes.
> 
> changes since v2:
> no changes.
> 
> changes since v1:
> 1. change to unconditional for these two patches.
> ---
>   ...b-Enable-IIC5_PMUX-for-GPIO-function.patch | 42 +++++++++++++++++++
>   ...nable-CLK_OUT_PMUX-for-GPIO-function.patch | 40 ++++++++++++++++++
>   2 files changed, 82 insertions(+)
>   create mode 100644 package/nxp/qoriq-rcw/0001-ls1028ardb-Enable-IIC5_PMUX-for-GPIO-function.patch
>   create mode 100644 package/nxp/qoriq-rcw/0002-ls1028ardb-Enable-CLK_OUT_PMUX-for-GPIO-function.patch
> 
> diff --git a/package/nxp/qoriq-rcw/0001-ls1028ardb-Enable-IIC5_PMUX-for-GPIO-function.patch b/package/nxp/qoriq-rcw/0001-ls1028ardb-Enable-IIC5_PMUX-for-GPIO-function.patch
> new file mode 100644
> index 0000000000..21c6c84cbd
> --- /dev/null
> +++ b/package/nxp/qoriq-rcw/0001-ls1028ardb-Enable-IIC5_PMUX-for-GPIO-function.patch
> @@ -0,0 +1,42 @@
> +From 33b403cee1fa215927bc65dc14baf35a2fdbe7b3 Mon Sep 17 00:00:00 2001
> +From: Jerry Huang <jerry.huang@nxp.com>
> +Date: Thu, 19 Sep 2019 12:12:20 +0800
> +Subject: [PATCH 1/2] ls1028ardb: Enable IIC5_PMUX for GPIO function
> +
> +Set IIC5_PMUX = 1 to enable GPIO function.
> +
> +Signed-off-by: Jianchao Wang <jianchao.wang@nxp.com>
> +Signed-off-by: Jerry Huang <jerry.huang@nxp.com>
> +---
> + ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw | 2 +-
> + ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw   | 2 +-
> + 2 files changed, 2 insertions(+), 2 deletions(-)
> +
> +diff --git a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw
> +index b46ea2e..5466a63 100644
> +--- a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw
> ++++ b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw
> +@@ -26,7 +26,7 @@ SYSCLK_FREQ=600
> + IIC2_PMUX=6
> + IIC3_PMUX=2
> + IIC4_PMUX=2
> +-IIC5_PMUX=2
> ++IIC5_PMUX=1
> + IIC6_PMUX=2
> + CLK_OUT_PMUX=2
> + EC1_SAI4_5_PMUX=5
> +diff --git a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw
> +index 04e2208..1908d8c 100644
> +--- a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw
> ++++ b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw
> +@@ -26,7 +26,7 @@ SYSCLK_FREQ=600
> + IIC2_PMUX=6
> + IIC3_PMUX=2
> + IIC4_PMUX=2
> +-IIC5_PMUX=2
> ++IIC5_PMUX=1
> + IIC6_PMUX=3
> + CLK_OUT_PMUX=2
> + EC1_SAI4_5_PMUX=5
> +--
> +2.17.1
> diff --git a/package/nxp/qoriq-rcw/0002-ls1028ardb-Enable-CLK_OUT_PMUX-for-GPIO-function.patch b/package/nxp/qoriq-rcw/0002-ls1028ardb-Enable-CLK_OUT_PMUX-for-GPIO-function.patch
> new file mode 100644
> index 0000000000..4f00541d69
> --- /dev/null
> +++ b/package/nxp/qoriq-rcw/0002-ls1028ardb-Enable-CLK_OUT_PMUX-for-GPIO-function.patch
> @@ -0,0 +1,40 @@
> +From 4a3c9ea5d0c7bf8eec8cb6276d6f4d940f3946db Mon Sep 17 00:00:00 2001
> +From: Jerry Huang <jerry.huang@nxp.com>
> +Date: Thu, 19 Sep 2019 12:13:48 +0800
> +Subject: [PATCH 2/2] ls1028ardb/rcw: Enable CLK_OUT_PMUX for GPIO function
> +
> +Signed-off-by: Jianchao Wang <jianchao.wang@nxp.com>
> +Signed-off-by: Jerry Huang <jerry.huang@nxp.com>
> +---
> + ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw | 2 +-
> + ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw   | 2 +-
> + 2 files changed, 2 insertions(+), 2 deletions(-)
> +
> +diff --git a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw
> +index 5466a63..a5ed4d4 100644
> +--- a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw
> ++++ b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw
> +@@ -28,7 +28,7 @@ IIC3_PMUX=2
> + IIC4_PMUX=2
> + IIC5_PMUX=1
> + IIC6_PMUX=2
> +-CLK_OUT_PMUX=2
> ++CLK_OUT_PMUX=1
> + EC1_SAI4_5_PMUX=5
> + EC1_SAI3_6_PMUX=5
> + USB3_CLK_FSEL=39
> +diff --git a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw
> +index 1908d8c..c930b83 100644
> +--- a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw
> ++++ b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw
> +@@ -28,7 +28,7 @@ IIC3_PMUX=2
> + IIC4_PMUX=2
> + IIC5_PMUX=1
> + IIC6_PMUX=3
> +-CLK_OUT_PMUX=2
> ++CLK_OUT_PMUX=1
> + EC1_SAI4_5_PMUX=5
> + EC1_SAI3_6_PMUX=5
> + USB3_CLK_FSEL=39
> +--
> +2.17.1
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-01-06 15:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07  8:38 [Buildroot] [PATCH v5 1/9] package/nxp: new package directory Changming Huang
2020-02-07  8:38 ` [Buildroot] [PATCH v5 2/9] package/qoriq-rcw: move rcw into nxp and rename it Changming Huang
2020-04-14  9:35   ` Heiko Thiery
2020-12-16 21:02   ` Yann E. MORIN
2020-02-07  8:38 ` [Buildroot] [PATCH v5 3/9] package/qoriq-rcw: bump to version LSDK-19.09 Changming Huang
2020-02-07  8:38 ` [Buildroot] [PATCH v5 4/9] package/qoriq-rcw: add target rcw binary support Changming Huang
2022-01-06 14:48   ` Arnout Vandecappelle
2020-02-07  8:38 ` [Buildroot] [PATCH v5 5/9] boot/arm-trusted-firmware: allow additional make dependencies Changming Huang
2022-01-06 15:05   ` Arnout Vandecappelle
2020-02-07  8:38 ` [Buildroot] [PATCH v5 6/9] package/qoriq-cadence-dp-firmware: new package Changming Huang
2022-01-06 15:14   ` Michael Walle
2022-01-06 15:19   ` Arnout Vandecappelle
2020-02-07  8:38 ` [Buildroot] [PATCH v5 7/9] package/qoriq-rcw:Enable IIC5_PMUX and CLK_OUT_PMUX for GPIO Changming Huang
2022-01-06 15:54   ` Arnout Vandecappelle [this message]
2020-02-07  8:38 ` [Buildroot] [PATCH v5 8/9] package/nxp/qoriq-rcw: introduce BR2_PACKAGE_HOST_QORIQ_RCW_BOOT_MODE for boot mode Changming Huang
2022-01-06 15:55   ` Arnout Vandecappelle
2020-02-07  8:38 ` [Buildroot] [PATCH v5 9/9] board/nxp/ls1028ardb: new board Changming Huang
2022-01-06 16:27   ` Arnout Vandecappelle
2022-01-06 14:45 ` [Buildroot] [PATCH v5 1/9] package/nxp: new package directory Arnout Vandecappelle
2022-01-06 15:00   ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835d05ab-20ed-8445-a2ef-285760b215a3@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    --cc=geomatsi@gmail.com \
    --cc=heiko.thiery@gmail.com \
    --cc=jerry.huang@nxp.com \
    --cc=matthew.weber@collins.com \
    --cc=michael@walle.cc \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox