From: Stefan Agner <stefan@agner.ch>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: dominique.tronche@eviden.com, christian@aperture.us,
buildroot@buildroot.org
Subject: Re: [Buildroot] [git commit branch/2023.02.x] package/go: bump to v1.19.13
Date: Thu, 14 Sep 2023 23:02:58 +0200 [thread overview]
Message-ID: <7a8bdce8aec8f95c3039172cf02ab7d9@agner.ch> (raw)
In-Reply-To: <87cyykv62q.fsf@48ers.dk>
On 2023-09-14 22:43, Peter Korsgaard wrote:
>>>>>> "Stefan" == Stefan Agner <stefan@agner.ch> writes:
>
> > On 2023-09-14 20:57, Peter Korsgaard wrote:
> >>>>>>> "Stefan" == Stefan Agner <stefan@agner.ch> writes:
> >>
> >> > go1.19.13 (released 2023-09-06) includes a couple of bug fixes. In
> >> > particular it fixes a bug introduced in with the update o v1.19.11
> >> > which broke http using a unix socket addressing.
> >>
> >> > Signed-off-by: Stefan Agner <stefan@agner.ch>
> >>
> >> Committed to 2023.02.x and 2023.05.x, thanks.
> >>
> >> I take it that this means we can again drop the recent docker-cli /
> >> docker-engine fixes to workaround the HTTP header issue?
>
> > By "recent docker-cli / docker-engine fixes" you mean the bump to
> > v24.0.x? Then yes, those can be dropped.
>
> No, the backports of the workaround for the new go behaviour, E.G.:
>
> https://gitlab.com/buildroot.org/buildroot/-/commit/d0ab8a869dbc5724a758f9777cafc1e12a343786
> https://gitlab.com/buildroot.org/buildroot/-/commit/ff72ac444311f45028381207df65d6538a7b12c8
>
Oh I see, wasn't aware about those two commits.
But yes, from what I can tell, they address the same problem and are not
strictly required anymore.
> > Or in other words, the version of Docker CLI/Engine present in 2023.02.4
> > works fine with the new Go version.
>
> OK, I will revert the two above commits then again.
Perfect, thanks!
--
Stefan
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-09-14 21:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 20:22 [Buildroot] [git commit branch/2023.02.x] package/go: bump to v1.19.13 Stefan Agner
2023-09-14 18:57 ` Peter Korsgaard
2023-09-14 19:44 ` Stefan Agner
2023-09-14 20:43 ` Peter Korsgaard
2023-09-14 21:02 ` Stefan Agner [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-09-14 18:55 Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a8bdce8aec8f95c3039172cf02ab7d9@agner.ch \
--to=stefan@agner.ch \
--cc=buildroot@buildroot.org \
--cc=christian@aperture.us \
--cc=dominique.tronche@eviden.com \
--cc=peter@korsgaard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox