Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [git commit branch/2023.02.x] package/go: bump to v1.19.13
@ 2023-09-13 20:22 Stefan Agner
  2023-09-14 18:57 ` Peter Korsgaard
  0 siblings, 1 reply; 6+ messages in thread
From: Stefan Agner @ 2023-09-13 20:22 UTC (permalink / raw)
  To: buildroot; +Cc: dominique.tronche, Stefan Agner, christian

go1.19.13 (released 2023-09-06) includes a couple of bug fixes. In
particular it fixes a bug introduced in with the update o v1.19.11
which broke http using a unix socket addressing.

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 package/go/go.hash | 2 +-
 package/go/go.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/go/go.hash b/package/go/go.hash
index ac8499e7dc..d61663cac9 100644
--- a/package/go/go.hash
+++ b/package/go/go.hash
@@ -1,3 +1,3 @@
 # From https://go.dev/dl
-sha256  ee5d50e0a7fd74ba1b137cb879609aaaef9880bf72b5d1742100e38ae72bb557  go1.19.12.src.tar.gz
+sha256  ccf36b53fb0024a017353c3ddb22c1f00bc7a8073c6aac79042da24ee34434d3  go1.19.13.src.tar.gz
 sha256  2d36597f7117c38b006835ae7f537487207d8ec407aa9d9980794b2030cbc067  LICENSE
diff --git a/package/go/go.mk b/package/go/go.mk
index 9189032ba8..ea2a46f36c 100644
--- a/package/go/go.mk
+++ b/package/go/go.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GO_VERSION = 1.19.12
+GO_VERSION = 1.19.13
 GO_SITE = https://storage.googleapis.com/golang
 GO_SOURCE = go$(GO_VERSION).src.tar.gz
 
-- 
2.42.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [git commit branch/2023.02.x] package/go: bump to v1.19.13
@ 2023-09-14 18:55 Peter Korsgaard
  0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2023-09-14 18:55 UTC (permalink / raw)
  To: buildroot

commit: https://git.buildroot.net/buildroot/commit/?id=baa0fe9ec56ca08b92d9413a3a2b9eabfa80f883
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/2023.02.x

go1.19.13 (released 2023-09-06) includes a couple of bug fixes.  In
particular it fixes a bug introduced with the update to v1.19.11 which
broke http using a unix socket addressing.

Signed-off-by: Stefan Agner <stefan@agner.ch>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/go/go.hash | 2 +-
 package/go/go.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/go/go.hash b/package/go/go.hash
index ac8499e7dc..d61663cac9 100644
--- a/package/go/go.hash
+++ b/package/go/go.hash
@@ -1,3 +1,3 @@
 # From https://go.dev/dl
-sha256  ee5d50e0a7fd74ba1b137cb879609aaaef9880bf72b5d1742100e38ae72bb557  go1.19.12.src.tar.gz
+sha256  ccf36b53fb0024a017353c3ddb22c1f00bc7a8073c6aac79042da24ee34434d3  go1.19.13.src.tar.gz
 sha256  2d36597f7117c38b006835ae7f537487207d8ec407aa9d9980794b2030cbc067  LICENSE
diff --git a/package/go/go.mk b/package/go/go.mk
index 9189032ba8..ea2a46f36c 100644
--- a/package/go/go.mk
+++ b/package/go/go.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GO_VERSION = 1.19.12
+GO_VERSION = 1.19.13
 GO_SITE = https://storage.googleapis.com/golang
 GO_SOURCE = go$(GO_VERSION).src.tar.gz
 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [Buildroot] [git commit branch/2023.02.x] package/go: bump to v1.19.13
  2023-09-13 20:22 [Buildroot] [git commit branch/2023.02.x] package/go: bump to v1.19.13 Stefan Agner
@ 2023-09-14 18:57 ` Peter Korsgaard
  2023-09-14 19:44   ` Stefan Agner
  0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2023-09-14 18:57 UTC (permalink / raw)
  To: Stefan Agner; +Cc: dominique.tronche, christian, buildroot

>>>>> "Stefan" == Stefan Agner <stefan@agner.ch> writes:

 > go1.19.13 (released 2023-09-06) includes a couple of bug fixes. In
 > particular it fixes a bug introduced in with the update o v1.19.11
 > which broke http using a unix socket addressing.

 > Signed-off-by: Stefan Agner <stefan@agner.ch>

Committed to 2023.02.x and 2023.05.x, thanks.

I take it that this means we can again drop the recent docker-cli /
docker-engine fixes to workaround the HTTP header issue?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Buildroot] [git commit branch/2023.02.x] package/go: bump to v1.19.13
  2023-09-14 18:57 ` Peter Korsgaard
@ 2023-09-14 19:44   ` Stefan Agner
  2023-09-14 20:43     ` Peter Korsgaard
  0 siblings, 1 reply; 6+ messages in thread
From: Stefan Agner @ 2023-09-14 19:44 UTC (permalink / raw)
  To: Peter Korsgaard; +Cc: dominique.tronche, christian, buildroot

On 2023-09-14 20:57, Peter Korsgaard wrote:
>>>>>> "Stefan" == Stefan Agner <stefan@agner.ch> writes:
> 
>  > go1.19.13 (released 2023-09-06) includes a couple of bug fixes. In
>  > particular it fixes a bug introduced in with the update o v1.19.11
>  > which broke http using a unix socket addressing.
> 
>  > Signed-off-by: Stefan Agner <stefan@agner.ch>
> 
> Committed to 2023.02.x and 2023.05.x, thanks.
> 
> I take it that this means we can again drop the recent docker-cli /
> docker-engine fixes to workaround the HTTP header issue?

By "recent docker-cli / docker-engine fixes" you mean the bump to
v24.0.x? Then yes, those can be dropped.

Or in other words, the version of Docker CLI/Engine present in 2023.02.4
works fine with the new Go version.

--
Stefan
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Buildroot] [git commit branch/2023.02.x] package/go: bump to v1.19.13
  2023-09-14 19:44   ` Stefan Agner
@ 2023-09-14 20:43     ` Peter Korsgaard
  2023-09-14 21:02       ` Stefan Agner
  0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2023-09-14 20:43 UTC (permalink / raw)
  To: Stefan Agner; +Cc: dominique.tronche, christian, buildroot

>>>>> "Stefan" == Stefan Agner <stefan@agner.ch> writes:

 > On 2023-09-14 20:57, Peter Korsgaard wrote:
 >>>>>>> "Stefan" == Stefan Agner <stefan@agner.ch> writes:
 >> 
 >> > go1.19.13 (released 2023-09-06) includes a couple of bug fixes. In
 >> > particular it fixes a bug introduced in with the update o v1.19.11
 >> > which broke http using a unix socket addressing.
 >> 
 >> > Signed-off-by: Stefan Agner <stefan@agner.ch>
 >> 
 >> Committed to 2023.02.x and 2023.05.x, thanks.
 >> 
 >> I take it that this means we can again drop the recent docker-cli /
 >> docker-engine fixes to workaround the HTTP header issue?

 > By "recent docker-cli / docker-engine fixes" you mean the bump to
 > v24.0.x? Then yes, those can be dropped.

No, the backports of the workaround for the new go behaviour, E.G.:

https://gitlab.com/buildroot.org/buildroot/-/commit/d0ab8a869dbc5724a758f9777cafc1e12a343786
https://gitlab.com/buildroot.org/buildroot/-/commit/ff72ac444311f45028381207df65d6538a7b12c8

 > Or in other words, the version of Docker CLI/Engine present in 2023.02.4
 > works fine with the new Go version.

OK, I will revert the two above commits then again.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Buildroot] [git commit branch/2023.02.x] package/go: bump to v1.19.13
  2023-09-14 20:43     ` Peter Korsgaard
@ 2023-09-14 21:02       ` Stefan Agner
  0 siblings, 0 replies; 6+ messages in thread
From: Stefan Agner @ 2023-09-14 21:02 UTC (permalink / raw)
  To: Peter Korsgaard; +Cc: dominique.tronche, christian, buildroot

On 2023-09-14 22:43, Peter Korsgaard wrote:
>>>>>> "Stefan" == Stefan Agner <stefan@agner.ch> writes:
> 
>  > On 2023-09-14 20:57, Peter Korsgaard wrote:
>  >>>>>>> "Stefan" == Stefan Agner <stefan@agner.ch> writes:
>  >> 
>  >> > go1.19.13 (released 2023-09-06) includes a couple of bug fixes. In
>  >> > particular it fixes a bug introduced in with the update o v1.19.11
>  >> > which broke http using a unix socket addressing.
>  >> 
>  >> > Signed-off-by: Stefan Agner <stefan@agner.ch>
>  >> 
>  >> Committed to 2023.02.x and 2023.05.x, thanks.
>  >> 
>  >> I take it that this means we can again drop the recent docker-cli /
>  >> docker-engine fixes to workaround the HTTP header issue?
> 
>  > By "recent docker-cli / docker-engine fixes" you mean the bump to
>  > v24.0.x? Then yes, those can be dropped.
> 
> No, the backports of the workaround for the new go behaviour, E.G.:
> 
> https://gitlab.com/buildroot.org/buildroot/-/commit/d0ab8a869dbc5724a758f9777cafc1e12a343786
> https://gitlab.com/buildroot.org/buildroot/-/commit/ff72ac444311f45028381207df65d6538a7b12c8
> 

Oh I see, wasn't aware about those two commits.

But yes, from what I can tell, they address the same problem and are not
strictly required anymore.

>  > Or in other words, the version of Docker CLI/Engine present in 2023.02.4
>  > works fine with the new Go version.
> 
> OK, I will revert the two above commits then again.

Perfect, thanks!

--
Stefan

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-09-14 21:04 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-13 20:22 [Buildroot] [git commit branch/2023.02.x] package/go: bump to v1.19.13 Stefan Agner
2023-09-14 18:57 ` Peter Korsgaard
2023-09-14 19:44   ` Stefan Agner
2023-09-14 20:43     ` Peter Korsgaard
2023-09-14 21:02       ` Stefan Agner
  -- strict thread matches above, loose matches on Subject: below --
2023-09-14 18:55 Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox