From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2, 1/1] package/supertux: fix build with RELRO
Date: Sat, 3 Oct 2020 21:40:15 +0200 [thread overview]
Message-ID: <8227afb0-d29f-4ab8-93b2-eef84ccfd0da@gmail.com> (raw)
In-Reply-To: <87zh58y9vb.fsf@dell.be.48ers.dk>
Hello Fabrice,
Le 29/09/2020 ? 15:45, Peter Korsgaard a ?crit?:
>>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
>
> > Disable static building of external/squirrel to fix the following build
> > failure with RELRO:
>
> > /home/peko/autobuild/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/x86_64-buildroot-linux-musl/8.3.0/../../../../x86_64-buildroot-linux-musl/bin/ld:
> > CMakeFiles/sq_static.dir/sq.c.o: relocation R_X86_64_32 against
> > `.rodata.str1.8' can not be used when making a PIE object; recompile
> > with -fPIC
> > /home/peko/autobuild/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/x86_64-buildroot-linux-musl/8.3.0/../../../../x86_64-buildroot-linux-musl/bin/ld:
> > final link failed: nonrepresentable section on output
> > collect2: error: ld returned 1 exit status
>
> > Fixes:
> > - http://autobuild.buildroot.org/results/46e8f5e622ce450a89bc6d70f4bfd38182557901
> > - http://autobuild.buildroot.org/results/a43720492d817e4555d728546da9114e3ccba952
>
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> > Changes v1 -> v2 (after review of Thomas Petazzoni):
> > - Disable static building of external/squirrel instead of adding -fPIC
>
> Committed to 2020.02.x, 2020.05.x and 2020.08.x, thanks.
>
This patch break supertux because libsquirrel.so.0 and libsqstdlib.so.0 are
missing in TARGET_DIR.
I believe, such bundled libraries are meant to be linked statically into supertux.
We need to revert this patch.
Best regards,
Romain
next prev parent reply other threads:[~2020-10-03 19:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 20:33 [Buildroot] [PATCH v2,1/1] package/supertux: fix build with RELRO Fabrice Fontaine
2020-09-19 19:15 ` [Buildroot] [PATCH v2, 1/1] " Thomas Petazzoni
2020-09-29 13:45 ` Peter Korsgaard
2020-10-03 19:40 ` Romain Naour [this message]
2020-10-03 19:52 ` Fabrice Fontaine
2020-10-03 20:02 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8227afb0-d29f-4ab8-93b2-eef84ccfd0da@gmail.com \
--to=romain.naour@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox