From: Esben Haabendal <esben@geanix.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] package/python-kiwisolver: new package
Date: Tue, 17 Sep 2019 10:46:52 +0200 [thread overview]
Message-ID: <871rwfe2df.fsf@geanix.com> (raw)
In-Reply-To: <87y2yo40y7.fsf@geanix.com> (Esben Haabendal's message of "Mon, 16 Sep 2019 19:15:28 +0200")
Esben Haabendal <esben@geanix.com> writes:
> Yegor Yefremov <yegorslists@googlemail.com> writes:
>
>>> diff --git a/package/python-kiwisolver/Config.in b/package/python-kiwisolver/Config.in
>>> new file mode 100644
>>> index 000000000000..d3ce857bac2f
>>> --- /dev/null
>>> +++ b/package/python-kiwisolver/Config.in
>>> @@ -0,0 +1,17 @@
>>> +config BR2_PACKAGE_PYTHON_KIWISOLVER
>>> + bool "python-kiwisolver"
>>> + depends on BR2_INSTALL_LIBSTDCPP
>>> + depends on BR2_PACKAGE_PYTHON3
>>
>> Basically the patch looks good. But setup.py says both Py2 and Py3 are
>> supported.
>
> I will try and see if it builds for python 2 also.
It builds with Python 2 just fine. I will send a new version with
support for Python 2 added.
>> Other than that you can add my
>>
>> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> for the next version.
>>
>> Yegor
>
> /Esben
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2019-09-17 8:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 12:13 [Buildroot] [PATCH 1/2] package/python-kiwisolver: new package Esben Haabendal
2019-09-16 12:13 ` [Buildroot] [PATCH 2/2] package/python-matplotlib: add kiwisolver dependency Esben Haabendal
2019-09-16 12:40 ` [Buildroot] [PATCH 1/2] package/python-kiwisolver: new package Yegor Yefremov
2019-09-16 13:31 ` [Buildroot] [PATCH v2 " Esben Haabendal
2019-09-16 13:31 ` [Buildroot] [PATCH v2 2/2] package/python-matplotlib: add kiwisolver dependency Esben Haabendal
2019-09-17 7:05 ` Yegor Yefremov
2019-09-16 16:17 ` [Buildroot] [PATCH v2 1/2] package/python-kiwisolver: new package Yegor Yefremov
2019-09-16 17:15 ` Esben Haabendal
2019-09-17 8:46 ` Esben Haabendal [this message]
2019-09-16 17:47 ` Esben Haabendal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rwfe2df.fsf@geanix.com \
--to=esben@geanix.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox