* [Buildroot] [PATCH 1/2] package/python-kiwisolver: new package
@ 2019-09-16 12:13 Esben Haabendal
2019-09-16 12:13 ` [Buildroot] [PATCH 2/2] package/python-matplotlib: add kiwisolver dependency Esben Haabendal
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Esben Haabendal @ 2019-09-16 12:13 UTC (permalink / raw)
To: buildroot
Signed-off-by: Esben Haabendal <esben@geanix.com>
---
package/Config.in | 1 +
package/python-kiwisolver/Config.in | 17 +++++++++++++++++
package/python-kiwisolver/python-kiwisolver.mk | 7 +++++++
3 files changed, 25 insertions(+)
create mode 100644 package/python-kiwisolver/Config.in
create mode 100644 package/python-kiwisolver/python-kiwisolver.mk
diff --git a/package/Config.in b/package/Config.in
index 9336261c5d9e..dddce6636168 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -933,6 +933,7 @@ menu "External python modules"
source "package/python-jsonmodels/Config.in"
source "package/python-jsonschema/Config.in"
source "package/python-keyring/Config.in"
+ source "package/python-kiwisolver/Config.in"
source "package/python-libconfig/Config.in"
source "package/python-libusb1/Config.in"
source "package/python-lmdb/Config.in"
diff --git a/package/python-kiwisolver/Config.in b/package/python-kiwisolver/Config.in
new file mode 100644
index 000000000000..d3ce857bac2f
--- /dev/null
+++ b/package/python-kiwisolver/Config.in
@@ -0,0 +1,17 @@
+config BR2_PACKAGE_PYTHON_KIWISOLVER
+ bool "python-kiwisolver"
+ depends on BR2_INSTALL_LIBSTDCPP
+ depends on BR2_PACKAGE_PYTHON3
+ help
+ Kiwi is an efficient C++ implementation of the Cassowary constraint
+ solving algorithm. Kiwi is an implementation of the algorithm based
+ on the seminal Cassowary paper. It is not a refactoring of the
+ original C++ solver. Kiwi has been designed from the ground up to be
+ lightweight and fast. Kiwi ranges from 10x to 500x faster than the
+ original Cassowary solver with typical use cases gaining a 40x
+ improvement. Memory savings are consistently > 5x.
+
+ https://github.com/nucleic/kiwi
+
+comment "python-kiwisolver needs a toolchain w/ C++"
+ depends on !BR2_INSTALL_LIBSTDCPP
diff --git a/package/python-kiwisolver/python-kiwisolver.mk b/package/python-kiwisolver/python-kiwisolver.mk
new file mode 100644
index 000000000000..96019fc29328
--- /dev/null
+++ b/package/python-kiwisolver/python-kiwisolver.mk
@@ -0,0 +1,7 @@
+PYTHON_KIWISOLVER_VERSION = 1.1.0
+PYTHON_KIWISOLVER_SITE = $(call github,nucleic,kiwi,$(PYTHON_KIWISOLVER_VERSION))
+PYTHON_KIWISOLVER_LICENSE = BSD-3-Clause
+PYTHON_KIWISOLVER_LICENSE_FILES = LICENSE
+PYTHON_KIWISOLVER_SETUP_TYPE = setuptools
+
+$(eval $(python-package))
--
2.23.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Buildroot] [PATCH 2/2] package/python-matplotlib: add kiwisolver dependency
2019-09-16 12:13 [Buildroot] [PATCH 1/2] package/python-kiwisolver: new package Esben Haabendal
@ 2019-09-16 12:13 ` Esben Haabendal
2019-09-16 12:40 ` [Buildroot] [PATCH 1/2] package/python-kiwisolver: new package Yegor Yefremov
2019-09-16 13:31 ` [Buildroot] [PATCH v2 " Esben Haabendal
2 siblings, 0 replies; 10+ messages in thread
From: Esben Haabendal @ 2019-09-16 12:13 UTC (permalink / raw)
To: buildroot
This is needed by matplotlib.pyplot, and is also documented at
https://matplotlib.org/users/installing.html#building-on-linux
Signed-off-by: Esben Haabendal <esben@geanix.com>
---
package/python-matplotlib/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/python-matplotlib/Config.in b/package/python-matplotlib/Config.in
index 07160affd043..e6ed8cda2f28 100644
--- a/package/python-matplotlib/Config.in
+++ b/package/python-matplotlib/Config.in
@@ -9,6 +9,7 @@ config BR2_PACKAGE_PYTHON_MATPLOTLIB
select BR2_PACKAGE_PYTHON_CYCLER
select BR2_PACKAGE_PYTHON_SETUPTOOLS # runtime
select BR2_PACKAGE_PYTHON_DATEUTIL # runtime
+ select BR2_PACKAGE_PYTHON_KIWISOLVER # runtime
select BR2_PACKAGE_PYTHON_NUMPY # runtime
select BR2_PACKAGE_PYTHON_PYPARSING # runtime
select BR2_PACKAGE_PYTHON3_ZLIB # runtime
--
2.23.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] package/python-kiwisolver: new package
2019-09-16 12:13 [Buildroot] [PATCH 1/2] package/python-kiwisolver: new package Esben Haabendal
2019-09-16 12:13 ` [Buildroot] [PATCH 2/2] package/python-matplotlib: add kiwisolver dependency Esben Haabendal
@ 2019-09-16 12:40 ` Yegor Yefremov
2019-09-16 13:31 ` [Buildroot] [PATCH v2 " Esben Haabendal
2 siblings, 0 replies; 10+ messages in thread
From: Yegor Yefremov @ 2019-09-16 12:40 UTC (permalink / raw)
To: buildroot
On Mon, Sep 16, 2019 at 2:20 PM Esben Haabendal <esben@geanix.com> wrote:
>
> Signed-off-by: Esben Haabendal <esben@geanix.com>
> ---
An entry in the DEVELOPERS file is missing.
> package/Config.in | 1 +
> package/python-kiwisolver/Config.in | 17 +++++++++++++++++
> package/python-kiwisolver/python-kiwisolver.mk | 7 +++++++
package/python-kiwisolver/python-kiwisolver.hash file with license
file and source archive file hashes is missing.
Yegor
> 3 files changed, 25 insertions(+)
> create mode 100644 package/python-kiwisolver/Config.in
> create mode 100644 package/python-kiwisolver/python-kiwisolver.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 9336261c5d9e..dddce6636168 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -933,6 +933,7 @@ menu "External python modules"
> source "package/python-jsonmodels/Config.in"
> source "package/python-jsonschema/Config.in"
> source "package/python-keyring/Config.in"
> + source "package/python-kiwisolver/Config.in"
> source "package/python-libconfig/Config.in"
> source "package/python-libusb1/Config.in"
> source "package/python-lmdb/Config.in"
> diff --git a/package/python-kiwisolver/Config.in b/package/python-kiwisolver/Config.in
> new file mode 100644
> index 000000000000..d3ce857bac2f
> --- /dev/null
> +++ b/package/python-kiwisolver/Config.in
> @@ -0,0 +1,17 @@
> +config BR2_PACKAGE_PYTHON_KIWISOLVER
> + bool "python-kiwisolver"
> + depends on BR2_INSTALL_LIBSTDCPP
> + depends on BR2_PACKAGE_PYTHON3
> + help
> + Kiwi is an efficient C++ implementation of the Cassowary constraint
> + solving algorithm. Kiwi is an implementation of the algorithm based
> + on the seminal Cassowary paper. It is not a refactoring of the
> + original C++ solver. Kiwi has been designed from the ground up to be
> + lightweight and fast. Kiwi ranges from 10x to 500x faster than the
> + original Cassowary solver with typical use cases gaining a 40x
> + improvement. Memory savings are consistently > 5x.
> +
> + https://github.com/nucleic/kiwi
> +
> +comment "python-kiwisolver needs a toolchain w/ C++"
> + depends on !BR2_INSTALL_LIBSTDCPP
> diff --git a/package/python-kiwisolver/python-kiwisolver.mk b/package/python-kiwisolver/python-kiwisolver.mk
> new file mode 100644
> index 000000000000..96019fc29328
> --- /dev/null
> +++ b/package/python-kiwisolver/python-kiwisolver.mk
> @@ -0,0 +1,7 @@
> +PYTHON_KIWISOLVER_VERSION = 1.1.0
> +PYTHON_KIWISOLVER_SITE = $(call github,nucleic,kiwi,$(PYTHON_KIWISOLVER_VERSION))
> +PYTHON_KIWISOLVER_LICENSE = BSD-3-Clause
> +PYTHON_KIWISOLVER_LICENSE_FILES = LICENSE
> +PYTHON_KIWISOLVER_SETUP_TYPE = setuptools
> +
> +$(eval $(python-package))
> --
> 2.23.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/2] package/python-kiwisolver: new package
2019-09-16 12:13 [Buildroot] [PATCH 1/2] package/python-kiwisolver: new package Esben Haabendal
2019-09-16 12:13 ` [Buildroot] [PATCH 2/2] package/python-matplotlib: add kiwisolver dependency Esben Haabendal
2019-09-16 12:40 ` [Buildroot] [PATCH 1/2] package/python-kiwisolver: new package Yegor Yefremov
@ 2019-09-16 13:31 ` Esben Haabendal
2019-09-16 13:31 ` [Buildroot] [PATCH v2 2/2] package/python-matplotlib: add kiwisolver dependency Esben Haabendal
2019-09-16 16:17 ` [Buildroot] [PATCH v2 1/2] package/python-kiwisolver: new package Yegor Yefremov
2 siblings, 2 replies; 10+ messages in thread
From: Esben Haabendal @ 2019-09-16 13:31 UTC (permalink / raw)
To: buildroot
Signed-off-by: Esben Haabendal <esben@geanix.com>
---
DEVELOPERS | 1 +
package/Config.in | 1 +
package/python-kiwisolver/Config.in | 17 +++++++++++++++++
.../python-kiwisolver/python-kiwisolver.hash | 3 +++
package/python-kiwisolver/python-kiwisolver.mk | 7 +++++++
5 files changed, 29 insertions(+)
create mode 100644 package/python-kiwisolver/Config.in
create mode 100644 package/python-kiwisolver/python-kiwisolver.hash
create mode 100644 package/python-kiwisolver/python-kiwisolver.mk
diff --git a/DEVELOPERS b/DEVELOPERS
index 3b1d03c82684..583a65b14ba9 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -719,6 +719,7 @@ F: package/szip/
N: Esben Haabendal <esben@haabendal.dk>
F: boot/gummiboot/
+F: package/python-kiwisolver/
N: Etienne Carriere <etienne.carriere@linaro.org>
F: boot/optee-os/
diff --git a/package/Config.in b/package/Config.in
index 9336261c5d9e..dddce6636168 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -933,6 +933,7 @@ menu "External python modules"
source "package/python-jsonmodels/Config.in"
source "package/python-jsonschema/Config.in"
source "package/python-keyring/Config.in"
+ source "package/python-kiwisolver/Config.in"
source "package/python-libconfig/Config.in"
source "package/python-libusb1/Config.in"
source "package/python-lmdb/Config.in"
diff --git a/package/python-kiwisolver/Config.in b/package/python-kiwisolver/Config.in
new file mode 100644
index 000000000000..d3ce857bac2f
--- /dev/null
+++ b/package/python-kiwisolver/Config.in
@@ -0,0 +1,17 @@
+config BR2_PACKAGE_PYTHON_KIWISOLVER
+ bool "python-kiwisolver"
+ depends on BR2_INSTALL_LIBSTDCPP
+ depends on BR2_PACKAGE_PYTHON3
+ help
+ Kiwi is an efficient C++ implementation of the Cassowary constraint
+ solving algorithm. Kiwi is an implementation of the algorithm based
+ on the seminal Cassowary paper. It is not a refactoring of the
+ original C++ solver. Kiwi has been designed from the ground up to be
+ lightweight and fast. Kiwi ranges from 10x to 500x faster than the
+ original Cassowary solver with typical use cases gaining a 40x
+ improvement. Memory savings are consistently > 5x.
+
+ https://github.com/nucleic/kiwi
+
+comment "python-kiwisolver needs a toolchain w/ C++"
+ depends on !BR2_INSTALL_LIBSTDCPP
diff --git a/package/python-kiwisolver/python-kiwisolver.hash b/package/python-kiwisolver/python-kiwisolver.hash
new file mode 100644
index 000000000000..9cdb27002cf2
--- /dev/null
+++ b/package/python-kiwisolver/python-kiwisolver.hash
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256 48168c0ace18319c649e31907f6d8586f648e503560f506f128798b99393bcdb python-kiwisolver-1.1.0.tar.gz
+sha256 95c32f73d43fa54d8146badbcbd73b83acb7fa2cc81a7cef7784b3cd33b146a0 LICENSE
diff --git a/package/python-kiwisolver/python-kiwisolver.mk b/package/python-kiwisolver/python-kiwisolver.mk
new file mode 100644
index 000000000000..96019fc29328
--- /dev/null
+++ b/package/python-kiwisolver/python-kiwisolver.mk
@@ -0,0 +1,7 @@
+PYTHON_KIWISOLVER_VERSION = 1.1.0
+PYTHON_KIWISOLVER_SITE = $(call github,nucleic,kiwi,$(PYTHON_KIWISOLVER_VERSION))
+PYTHON_KIWISOLVER_LICENSE = BSD-3-Clause
+PYTHON_KIWISOLVER_LICENSE_FILES = LICENSE
+PYTHON_KIWISOLVER_SETUP_TYPE = setuptools
+
+$(eval $(python-package))
--
2.23.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 2/2] package/python-matplotlib: add kiwisolver dependency
2019-09-16 13:31 ` [Buildroot] [PATCH v2 " Esben Haabendal
@ 2019-09-16 13:31 ` Esben Haabendal
2019-09-17 7:05 ` Yegor Yefremov
2019-09-16 16:17 ` [Buildroot] [PATCH v2 1/2] package/python-kiwisolver: new package Yegor Yefremov
1 sibling, 1 reply; 10+ messages in thread
From: Esben Haabendal @ 2019-09-16 13:31 UTC (permalink / raw)
To: buildroot
This is needed by matplotlib.pyplot, and is also documented at
https://matplotlib.org/users/installing.html#building-on-linux
Signed-off-by: Esben Haabendal <esben@geanix.com>
---
package/python-matplotlib/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/python-matplotlib/Config.in b/package/python-matplotlib/Config.in
index 07160affd043..e6ed8cda2f28 100644
--- a/package/python-matplotlib/Config.in
+++ b/package/python-matplotlib/Config.in
@@ -9,6 +9,7 @@ config BR2_PACKAGE_PYTHON_MATPLOTLIB
select BR2_PACKAGE_PYTHON_CYCLER
select BR2_PACKAGE_PYTHON_SETUPTOOLS # runtime
select BR2_PACKAGE_PYTHON_DATEUTIL # runtime
+ select BR2_PACKAGE_PYTHON_KIWISOLVER # runtime
select BR2_PACKAGE_PYTHON_NUMPY # runtime
select BR2_PACKAGE_PYTHON_PYPARSING # runtime
select BR2_PACKAGE_PYTHON3_ZLIB # runtime
--
2.23.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 2/2] package/python-matplotlib: add kiwisolver dependency
2019-09-16 13:31 ` [Buildroot] [PATCH v2 2/2] package/python-matplotlib: add kiwisolver dependency Esben Haabendal
@ 2019-09-17 7:05 ` Yegor Yefremov
0 siblings, 0 replies; 10+ messages in thread
From: Yegor Yefremov @ 2019-09-17 7:05 UTC (permalink / raw)
To: buildroot
On Mon, Sep 16, 2019 at 3:31 PM Esben Haabendal <esben@geanix.com> wrote:
>
> This is needed by matplotlib.pyplot, and is also documented at
> https://matplotlib.org/users/installing.html#building-on-linux
>
> Signed-off-by: Esben Haabendal <esben@geanix.com>
Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> package/python-matplotlib/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/python-matplotlib/Config.in b/package/python-matplotlib/Config.in
> index 07160affd043..e6ed8cda2f28 100644
> --- a/package/python-matplotlib/Config.in
> +++ b/package/python-matplotlib/Config.in
> @@ -9,6 +9,7 @@ config BR2_PACKAGE_PYTHON_MATPLOTLIB
> select BR2_PACKAGE_PYTHON_CYCLER
> select BR2_PACKAGE_PYTHON_SETUPTOOLS # runtime
> select BR2_PACKAGE_PYTHON_DATEUTIL # runtime
> + select BR2_PACKAGE_PYTHON_KIWISOLVER # runtime
> select BR2_PACKAGE_PYTHON_NUMPY # runtime
> select BR2_PACKAGE_PYTHON_PYPARSING # runtime
> select BR2_PACKAGE_PYTHON3_ZLIB # runtime
> --
> 2.23.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/2] package/python-kiwisolver: new package
2019-09-16 13:31 ` [Buildroot] [PATCH v2 " Esben Haabendal
2019-09-16 13:31 ` [Buildroot] [PATCH v2 2/2] package/python-matplotlib: add kiwisolver dependency Esben Haabendal
@ 2019-09-16 16:17 ` Yegor Yefremov
2019-09-16 17:15 ` Esben Haabendal
2019-09-16 17:47 ` Esben Haabendal
1 sibling, 2 replies; 10+ messages in thread
From: Yegor Yefremov @ 2019-09-16 16:17 UTC (permalink / raw)
To: buildroot
On Mon, Sep 16, 2019 at 3:31 PM Esben Haabendal <esben@geanix.com> wrote:
>
> Signed-off-by: Esben Haabendal <esben@geanix.com>
> ---
> DEVELOPERS | 1 +
> package/Config.in | 1 +
> package/python-kiwisolver/Config.in | 17 +++++++++++++++++
> .../python-kiwisolver/python-kiwisolver.hash | 3 +++
> package/python-kiwisolver/python-kiwisolver.mk | 7 +++++++
> 5 files changed, 29 insertions(+)
> create mode 100644 package/python-kiwisolver/Config.in
> create mode 100644 package/python-kiwisolver/python-kiwisolver.hash
> create mode 100644 package/python-kiwisolver/python-kiwisolver.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 3b1d03c82684..583a65b14ba9 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -719,6 +719,7 @@ F: package/szip/
>
> N: Esben Haabendal <esben@haabendal.dk>
> F: boot/gummiboot/
> +F: package/python-kiwisolver/
>
> N: Etienne Carriere <etienne.carriere@linaro.org>
> F: boot/optee-os/
> diff --git a/package/Config.in b/package/Config.in
> index 9336261c5d9e..dddce6636168 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -933,6 +933,7 @@ menu "External python modules"
> source "package/python-jsonmodels/Config.in"
> source "package/python-jsonschema/Config.in"
> source "package/python-keyring/Config.in"
> + source "package/python-kiwisolver/Config.in"
> source "package/python-libconfig/Config.in"
> source "package/python-libusb1/Config.in"
> source "package/python-lmdb/Config.in"
> diff --git a/package/python-kiwisolver/Config.in b/package/python-kiwisolver/Config.in
> new file mode 100644
> index 000000000000..d3ce857bac2f
> --- /dev/null
> +++ b/package/python-kiwisolver/Config.in
> @@ -0,0 +1,17 @@
> +config BR2_PACKAGE_PYTHON_KIWISOLVER
> + bool "python-kiwisolver"
> + depends on BR2_INSTALL_LIBSTDCPP
> + depends on BR2_PACKAGE_PYTHON3
Basically the patch looks good. But setup.py says both Py2 and Py3 are
supported.
Other than that you can add my
Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
for the next version.
Yegor
> + help
> + Kiwi is an efficient C++ implementation of the Cassowary constraint
> + solving algorithm. Kiwi is an implementation of the algorithm based
> + on the seminal Cassowary paper. It is not a refactoring of the
> + original C++ solver. Kiwi has been designed from the ground up to be
> + lightweight and fast. Kiwi ranges from 10x to 500x faster than the
> + original Cassowary solver with typical use cases gaining a 40x
> + improvement. Memory savings are consistently > 5x.
> +
> + https://github.com/nucleic/kiwi
> +
> +comment "python-kiwisolver needs a toolchain w/ C++"
> + depends on !BR2_INSTALL_LIBSTDCPP
> diff --git a/package/python-kiwisolver/python-kiwisolver.hash b/package/python-kiwisolver/python-kiwisolver.hash
> new file mode 100644
> index 000000000000..9cdb27002cf2
> --- /dev/null
> +++ b/package/python-kiwisolver/python-kiwisolver.hash
> @@ -0,0 +1,3 @@
> +# Locally calculated
> +sha256 48168c0ace18319c649e31907f6d8586f648e503560f506f128798b99393bcdb python-kiwisolver-1.1.0.tar.gz
> +sha256 95c32f73d43fa54d8146badbcbd73b83acb7fa2cc81a7cef7784b3cd33b146a0 LICENSE
> diff --git a/package/python-kiwisolver/python-kiwisolver.mk b/package/python-kiwisolver/python-kiwisolver.mk
> new file mode 100644
> index 000000000000..96019fc29328
> --- /dev/null
> +++ b/package/python-kiwisolver/python-kiwisolver.mk
> @@ -0,0 +1,7 @@
> +PYTHON_KIWISOLVER_VERSION = 1.1.0
> +PYTHON_KIWISOLVER_SITE = $(call github,nucleic,kiwi,$(PYTHON_KIWISOLVER_VERSION))
> +PYTHON_KIWISOLVER_LICENSE = BSD-3-Clause
> +PYTHON_KIWISOLVER_LICENSE_FILES = LICENSE
> +PYTHON_KIWISOLVER_SETUP_TYPE = setuptools
> +
> +$(eval $(python-package))
> --
> 2.23.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/2] package/python-kiwisolver: new package
2019-09-16 16:17 ` [Buildroot] [PATCH v2 1/2] package/python-kiwisolver: new package Yegor Yefremov
@ 2019-09-16 17:15 ` Esben Haabendal
2019-09-17 8:46 ` Esben Haabendal
2019-09-16 17:47 ` Esben Haabendal
1 sibling, 1 reply; 10+ messages in thread
From: Esben Haabendal @ 2019-09-16 17:15 UTC (permalink / raw)
To: buildroot
Yegor Yefremov <yegorslists@googlemail.com> writes:
>> diff --git a/package/python-kiwisolver/Config.in b/package/python-kiwisolver/Config.in
>> new file mode 100644
>> index 000000000000..d3ce857bac2f
>> --- /dev/null
>> +++ b/package/python-kiwisolver/Config.in
>> @@ -0,0 +1,17 @@
>> +config BR2_PACKAGE_PYTHON_KIWISOLVER
>> + bool "python-kiwisolver"
>> + depends on BR2_INSTALL_LIBSTDCPP
>> + depends on BR2_PACKAGE_PYTHON3
>
> Basically the patch looks good. But setup.py says both Py2 and Py3 are
> supported.
I will try and see if it builds for python 2 also.
> Other than that you can add my
>
> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
>
> for the next version.
>
> Yegor
/Esben
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/2] package/python-kiwisolver: new package
2019-09-16 17:15 ` Esben Haabendal
@ 2019-09-17 8:46 ` Esben Haabendal
0 siblings, 0 replies; 10+ messages in thread
From: Esben Haabendal @ 2019-09-17 8:46 UTC (permalink / raw)
To: buildroot
Esben Haabendal <esben@geanix.com> writes:
> Yegor Yefremov <yegorslists@googlemail.com> writes:
>
>>> diff --git a/package/python-kiwisolver/Config.in b/package/python-kiwisolver/Config.in
>>> new file mode 100644
>>> index 000000000000..d3ce857bac2f
>>> --- /dev/null
>>> +++ b/package/python-kiwisolver/Config.in
>>> @@ -0,0 +1,17 @@
>>> +config BR2_PACKAGE_PYTHON_KIWISOLVER
>>> + bool "python-kiwisolver"
>>> + depends on BR2_INSTALL_LIBSTDCPP
>>> + depends on BR2_PACKAGE_PYTHON3
>>
>> Basically the patch looks good. But setup.py says both Py2 and Py3 are
>> supported.
>
> I will try and see if it builds for python 2 also.
It builds with Python 2 just fine. I will send a new version with
support for Python 2 added.
>> Other than that you can add my
>>
>> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> for the next version.
>>
>> Yegor
>
> /Esben
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/2] package/python-kiwisolver: new package
2019-09-16 16:17 ` [Buildroot] [PATCH v2 1/2] package/python-kiwisolver: new package Yegor Yefremov
2019-09-16 17:15 ` Esben Haabendal
@ 2019-09-16 17:47 ` Esben Haabendal
1 sibling, 0 replies; 10+ messages in thread
From: Esben Haabendal @ 2019-09-16 17:47 UTC (permalink / raw)
To: buildroot
Yegor Yefremov <yegorslists@googlemail.com> writes:
> Basically the patch looks good. But setup.py says both Py2 and Py3 are
> supported.
>
> Other than that you can add my
>
> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
>
> for the next version.
For this patch only, or the both patches in this series?
/Esben
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-09-17 8:46 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-16 12:13 [Buildroot] [PATCH 1/2] package/python-kiwisolver: new package Esben Haabendal
2019-09-16 12:13 ` [Buildroot] [PATCH 2/2] package/python-matplotlib: add kiwisolver dependency Esben Haabendal
2019-09-16 12:40 ` [Buildroot] [PATCH 1/2] package/python-kiwisolver: new package Yegor Yefremov
2019-09-16 13:31 ` [Buildroot] [PATCH v2 " Esben Haabendal
2019-09-16 13:31 ` [Buildroot] [PATCH v2 2/2] package/python-matplotlib: add kiwisolver dependency Esben Haabendal
2019-09-17 7:05 ` Yegor Yefremov
2019-09-16 16:17 ` [Buildroot] [PATCH v2 1/2] package/python-kiwisolver: new package Yegor Yefremov
2019-09-16 17:15 ` Esben Haabendal
2019-09-17 8:46 ` Esben Haabendal
2019-09-16 17:47 ` Esben Haabendal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox