[Buildroot] [PATCH 1/1] package/tar: fix NLS build

[Buildroot] [PATCH 1/1] package/tar: fix NLS build

[Fabrice Fontaine]

Fix the following build failure raised since bump to version 1.35 in
commit d4d483451f0a305781b94b96c15a6cf4b489cd84:

/home/thomas/autobuild/instance-1/output-1/host/lib/gcc/xtensa-buildroot-linux-uclibc/12.3.0/../../../../xtensa-buildroot-linux-uclibc/bin/ld: buffer.o: in function `bufmap_reset':
buffer.c:(.text+0xe8): undefined reference to `libintl_gettext'

Fixes:
 - http://autobuild.buildroot.org/results/99b05d4b495b6337c6a48ea5a551a3a84c6d2e6b

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/tar/tar.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/tar/tar.mk b/package/tar/tar.mk
index 8a612b6f45..5908b9ec3e 100644
--- a/package/tar/tar.mk
+++ b/package/tar/tar.mk
@@ -19,6 +19,8 @@ TAR_CONF_OPTS = \
 TAR_LICENSE = GPL-3.0+
 TAR_LICENSE_FILES = COPYING
 TAR_CPE_ID_VENDOR = gnu
+TAR_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES)
+TAR_CONF_ENV = LIBS=$(TARGET_NLS_LIBS)
 
 ifeq ($(BR2_PACKAGE_ACL),y)
 TAR_DEPENDENCIES += acl
-- 
2.42.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/tar: fix NLS build

[Arnout Vandecappelle via buildroot]

On 30/10/2023 14:38, Fabrice Fontaine wrote:
> Fix the following build failure raised since bump to version 1.35 in
> commit d4d483451f0a305781b94b96c15a6cf4b489cd84:
> 
> /home/thomas/autobuild/instance-1/output-1/host/lib/gcc/xtensa-buildroot-linux-uclibc/12.3.0/../../../../xtensa-buildroot-linux-uclibc/bin/ld: buffer.o: in function `bufmap_reset':
> buffer.c:(.text+0xe8): undefined reference to `libintl_gettext'
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/99b05d4b495b6337c6a48ea5a551a3a84c6d2e6b
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/tar/tar.mk | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/package/tar/tar.mk b/package/tar/tar.mk
> index 8a612b6f45..5908b9ec3e 100644
> --- a/package/tar/tar.mk
> +++ b/package/tar/tar.mk
> @@ -19,6 +19,8 @@ TAR_CONF_OPTS = \
>   TAR_LICENSE = GPL-3.0+
>   TAR_LICENSE_FILES = COPYING
>   TAR_CPE_ID_VENDOR = gnu
> +TAR_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES)
> +TAR_CONF_ENV = LIBS=$(TARGET_NLS_LIBS)
>   
>   ifeq ($(BR2_PACKAGE_ACL),y)
>   TAR_DEPENDENCIES += acl
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/tar: fix NLS build

[Peter Korsgaard]

>>>>> "Arnout" == Arnout Vandecappelle via buildroot <buildroot@buildroot.org> writes:

 > On 30/10/2023 14:38, Fabrice Fontaine wrote:
 >> Fix the following build failure raised since bump to version 1.35 in
 >> commit d4d483451f0a305781b94b96c15a6cf4b489cd84:
 >> /home/thomas/autobuild/instance-1/output-1/host/lib/gcc/xtensa-buildroot-linux-uclibc/12.3.0/../../../../xtensa-buildroot-linux-uclibc/bin/ld:
 >> buffer.o: in function `bufmap_reset':
 >> buffer.c:(.text+0xe8): undefined reference to `libintl_gettext'
 >> Fixes:
 >> - http://autobuild.buildroot.org/results/99b05d4b495b6337c6a48ea5a551a3a84c6d2e6b
 >> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

 >  Applied to master, thanks.

Is this still needed given that we reverted to tar 1.34?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot