Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/libbytesize: remove pcre2 runtime dependency
Date: Thu, 25 Mar 2021 16:22:46 +0200	[thread overview]
Message-ID: <8735wjl3d5.fsf@tarshish> (raw)
In-Reply-To: <226176cabe249af62546689fbb39de8a7010c329.1616681740.git.stefan@agner.ch>

Hi Stefan,

On Thu, Mar 25 2021, Stefan Agner wrote:
> The library is only required at build time, which is handled by the
> select in Config.in.

The _DEPENDENCIES list is meant to make sure that pcre2 builds before
libbytesize. Config.in select does not guarantee the build order.
Config.in select only makes pcre2 build.

So if pcre2 is required at build time we need it in the _DEPENDENCIES
list.

Am I missing something?

baruch

> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>  package/libbytesize/libbytesize.mk | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/package/libbytesize/libbytesize.mk b/package/libbytesize/libbytesize.mk
> index 0ba380dc74..df54ae84b7 100644
> --- a/package/libbytesize/libbytesize.mk
> +++ b/package/libbytesize/libbytesize.mk
> @@ -14,8 +14,7 @@ LIBBYTESIZE_DEPENDENCIES = \
>  	host-pkgconf \
>  	host-gettext \
>  	gmp \
> -	mpfr \
> -	pcre2
> +	mpfr
>  
>  LIBBYTESIZE_CONF_OPTS += \
>  	--without-python3 \


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2021-03-25 14:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-25 14:17 [Buildroot] [PATCH] package/libbytesize: remove pcre2 runtime dependency Stefan Agner
2021-03-25 14:22 ` Baruch Siach [this message]
2021-03-25 14:40   ` Stefan Agner
2021-03-25 15:39     ` Thomas Petazzoni
2021-03-25 16:41       ` Stefan Agner
2021-03-28 14:52         ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735wjl3d5.fsf@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox