* [Buildroot] [PATCH 1/1] package/systemd: add repart support
@ 2020-03-08 9:16 James Hilliard
2020-03-08 9:25 ` Baruch Siach
2020-03-08 14:17 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: James Hilliard @ 2020-03-08 9:16 UTC (permalink / raw)
To: buildroot
systemd-repart grows and adds partitions to a partition table, based on
the configuration files described in repart.d.
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
package/systemd/Config.in | 9 +++++++++
package/systemd/systemd.mk | 8 +++++++-
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/package/systemd/Config.in b/package/systemd/Config.in
index c727082a1a..64d30f32aa 100644
--- a/package/systemd/Config.in
+++ b/package/systemd/Config.in
@@ -153,6 +153,15 @@ config BR2_PACKAGE_SYSTEMD_BINFMT
http://www.freedesktop.org/software/systemd/man/systemd-binfmt.service.html
+config BR2_PACKAGE_SYSTEMD_REPART
+ bool "enable repart support"
+ select BR2_PACKAGE_OPENSSL
+ help
+ systemd-repart grows and adds partitions to a partition table,
+ based on the configuration files described in repart.d.
+
+ https://www.freedesktop.org/software/systemd/man/systemd-repart.html
+
config BR2_PACKAGE_SYSTEMD_COREDUMP
bool "enable coredump hook"
help
diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
index 1c3b81cfcb..d05541a2f6 100644
--- a/package/systemd/systemd.mk
+++ b/package/systemd/systemd.mk
@@ -41,7 +41,6 @@ SYSTEMD_CONF_OPTS += \
-Dumount-path=/usr/bin/umount \
-Dnobody-group=nogroup \
-Didn=true \
- -Drepart=false \
-Duserdb=false \
-Dhomed=false \
-Dnss-systemd=true
@@ -305,6 +304,13 @@ else
SYSTEMD_CONF_OPTS += -Dlocaled=false
endif
+ifeq ($(BR2_PACKAGE_SYSTEMD_REPART),y)
+SYSTEMD_CONF_OPTS += -Drepart=true
+SYSTEMD_DEPENDENCIES += openssl
+else
+SYSTEMD_CONF_OPTS += -Drepart=false
+endif
+
ifeq ($(BR2_PACKAGE_SYSTEMD_COREDUMP),y)
SYSTEMD_CONF_OPTS += -Dcoredump=true
SYSTEMD_COREDUMP_USER = systemd-coredump -1 systemd-coredump -1 * /var/lib/systemd/coredump - - Core Dumper
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/systemd: add repart support
2020-03-08 9:16 [Buildroot] [PATCH 1/1] package/systemd: add repart support James Hilliard
@ 2020-03-08 9:25 ` Baruch Siach
2020-03-08 9:36 ` James Hilliard
2020-03-08 14:17 ` Thomas Petazzoni
1 sibling, 1 reply; 4+ messages in thread
From: Baruch Siach @ 2020-03-08 9:25 UTC (permalink / raw)
To: buildroot
Hi James,
On Sun, Mar 08 2020, James Hilliard wrote:
> systemd-repart grows and adds partitions to a partition table, based on
> the configuration files described in repart.d.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/systemd/Config.in | 9 +++++++++
> package/systemd/systemd.mk | 8 +++++++-
> 2 files changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/package/systemd/Config.in b/package/systemd/Config.in
> index c727082a1a..64d30f32aa 100644
> --- a/package/systemd/Config.in
> +++ b/package/systemd/Config.in
> @@ -153,6 +153,15 @@ config BR2_PACKAGE_SYSTEMD_BINFMT
>
> http://www.freedesktop.org/software/systemd/man/systemd-binfmt.service.html
>
> +config BR2_PACKAGE_SYSTEMD_REPART
> + bool "enable repart support"
> + select BR2_PACKAGE_OPENSSL
The systemd meson.build indicates that util-linux libfdisk is also
required for repart.
baruch
> + help
> + systemd-repart grows and adds partitions to a partition table,
> + based on the configuration files described in repart.d.
> +
> + https://www.freedesktop.org/software/systemd/man/systemd-repart.html
> +
> config BR2_PACKAGE_SYSTEMD_COREDUMP
> bool "enable coredump hook"
> help
> diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> index 1c3b81cfcb..d05541a2f6 100644
> --- a/package/systemd/systemd.mk
> +++ b/package/systemd/systemd.mk
> @@ -41,7 +41,6 @@ SYSTEMD_CONF_OPTS += \
> -Dumount-path=/usr/bin/umount \
> -Dnobody-group=nogroup \
> -Didn=true \
> - -Drepart=false \
> -Duserdb=false \
> -Dhomed=false \
> -Dnss-systemd=true
> @@ -305,6 +304,13 @@ else
> SYSTEMD_CONF_OPTS += -Dlocaled=false
> endif
>
> +ifeq ($(BR2_PACKAGE_SYSTEMD_REPART),y)
> +SYSTEMD_CONF_OPTS += -Drepart=true
> +SYSTEMD_DEPENDENCIES += openssl
> +else
> +SYSTEMD_CONF_OPTS += -Drepart=false
> +endif
> +
> ifeq ($(BR2_PACKAGE_SYSTEMD_COREDUMP),y)
> SYSTEMD_CONF_OPTS += -Dcoredump=true
> SYSTEMD_COREDUMP_USER = systemd-coredump -1 systemd-coredump -1 * /var/lib/systemd/coredump - - Core Dumper
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread* [Buildroot] [PATCH 1/1] package/systemd: add repart support
2020-03-08 9:25 ` Baruch Siach
@ 2020-03-08 9:36 ` James Hilliard
0 siblings, 0 replies; 4+ messages in thread
From: James Hilliard @ 2020-03-08 9:36 UTC (permalink / raw)
To: buildroot
On Sun, Mar 8, 2020 at 3:25 AM Baruch Siach <baruch@tkos.co.il> wrote:
>
> Hi James,
>
> On Sun, Mar 08 2020, James Hilliard wrote:
> > systemd-repart grows and adds partitions to a partition table, based on
> > the configuration files described in repart.d.
> >
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > ---
> > package/systemd/Config.in | 9 +++++++++
> > package/systemd/systemd.mk | 8 +++++++-
> > 2 files changed, 16 insertions(+), 1 deletion(-)
> >
> > diff --git a/package/systemd/Config.in b/package/systemd/Config.in
> > index c727082a1a..64d30f32aa 100644
> > --- a/package/systemd/Config.in
> > +++ b/package/systemd/Config.in
> > @@ -153,6 +153,15 @@ config BR2_PACKAGE_SYSTEMD_BINFMT
> >
> > http://www.freedesktop.org/software/systemd/man/systemd-binfmt.service.html
> >
> > +config BR2_PACKAGE_SYSTEMD_REPART
> > + bool "enable repart support"
> > + select BR2_PACKAGE_OPENSSL
>
> The systemd meson.build indicates that util-linux libfdisk is also
> required for repart.
This is selected by BR2_PACKAGE_SYSTEMD already since
BR2_PACKAGE_UTIL_LINUX_BINARIES selects
BR2_PACKAGE_UTIL_LINUX_LIBFDISK.
>
> baruch
>
> > + help
> > + systemd-repart grows and adds partitions to a partition table,
> > + based on the configuration files described in repart.d.
> > +
> > + https://www.freedesktop.org/software/systemd/man/systemd-repart.html
> > +
> > config BR2_PACKAGE_SYSTEMD_COREDUMP
> > bool "enable coredump hook"
> > help
> > diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> > index 1c3b81cfcb..d05541a2f6 100644
> > --- a/package/systemd/systemd.mk
> > +++ b/package/systemd/systemd.mk
> > @@ -41,7 +41,6 @@ SYSTEMD_CONF_OPTS += \
> > -Dumount-path=/usr/bin/umount \
> > -Dnobody-group=nogroup \
> > -Didn=true \
> > - -Drepart=false \
> > -Duserdb=false \
> > -Dhomed=false \
> > -Dnss-systemd=true
> > @@ -305,6 +304,13 @@ else
> > SYSTEMD_CONF_OPTS += -Dlocaled=false
> > endif
> >
> > +ifeq ($(BR2_PACKAGE_SYSTEMD_REPART),y)
> > +SYSTEMD_CONF_OPTS += -Drepart=true
> > +SYSTEMD_DEPENDENCIES += openssl
> > +else
> > +SYSTEMD_CONF_OPTS += -Drepart=false
> > +endif
> > +
> > ifeq ($(BR2_PACKAGE_SYSTEMD_COREDUMP),y)
> > SYSTEMD_CONF_OPTS += -Dcoredump=true
> > SYSTEMD_COREDUMP_USER = systemd-coredump -1 systemd-coredump -1 * /var/lib/systemd/coredump - - Core Dumper
>
>
> --
> http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/systemd: add repart support
2020-03-08 9:16 [Buildroot] [PATCH 1/1] package/systemd: add repart support James Hilliard
2020-03-08 9:25 ` Baruch Siach
@ 2020-03-08 14:17 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2020-03-08 14:17 UTC (permalink / raw)
To: buildroot
On Sun, 8 Mar 2020 03:16:40 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> systemd-repart grows and adds partitions to a partition table, based on
> the configuration files described in repart.d.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/systemd/Config.in | 9 +++++++++
> package/systemd/systemd.mk | 8 +++++++-
> 2 files changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/package/systemd/Config.in b/package/systemd/Config.in
> index c727082a1a..64d30f32aa 100644
> --- a/package/systemd/Config.in
> +++ b/package/systemd/Config.in
> @@ -153,6 +153,15 @@ config BR2_PACKAGE_SYSTEMD_BINFMT
>
> http://www.freedesktop.org/software/systemd/man/systemd-binfmt.service.html
>
> +config BR2_PACKAGE_SYSTEMD_REPART
> + bool "enable repart support"
> + select BR2_PACKAGE_OPENSSL
> + help
> + systemd-repart grows and adds partitions to a partition table,
> + based on the configuration files described in repart.d.
> +
> + https://www.freedesktop.org/software/systemd/man/systemd-repart.html
Alphabetic sorting of options was not respected here, so I've moved
this option.
I've also added an explicit select of libfdisk, as suggested by Baruch.
Even though it is implied by the top-level option, making it explicit
doesn't hurt.
Applied to next with those changes. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-08 14:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-08 9:16 [Buildroot] [PATCH 1/1] package/systemd: add repart support James Hilliard
2020-03-08 9:25 ` Baruch Siach
2020-03-08 9:36 ` James Hilliard
2020-03-08 14:17 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox