Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] wireguard: needs 3.10+ kernel
Date: Thu, 05 Oct 2017 22:53:15 +0200	[thread overview]
Message-ID: <87376xgvus.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <0fb02bba-856e-2721-a482-37831b3a85fd@mind.be> (Arnout Vandecappelle's message of "Thu, 5 Oct 2017 21:51:01 +0200")

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

Hi,

 >> That was my first thought as well, but it doesn't make much sense to
 >> build the user space part if the kernel is too old,

 >  That's true indeed, could you add that reasoning to the commit message? Then
 > there's no need to complicate the dependency.

 >> and I couldn't come
 >> up with a good and clear wording for the comment - So I opted to keep it
 >> simple.
 >> 
 >> But we can change it if you feel strongly about it. What do you suggest
 >> for the comment text?

 > 	# kernel module requires 3.10+, userspace makes no sense without it

Committed with these fixes, thanks.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2017-10-05 20:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-03  8:04 [Buildroot] [PATCH] wireguard: needs 3.10+ kernel Peter Korsgaard
2017-10-05 18:44 ` Arnout Vandecappelle
2017-10-05 19:46   ` Peter Korsgaard
2017-10-05 19:51     ` Arnout Vandecappelle
2017-10-05 20:53       ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87376xgvus.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox