Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] wireguard: needs 3.10+ kernel
Date: Thu, 05 Oct 2017 21:46:58 +0200	[thread overview]
Message-ID: <8760btidhp.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <0b87fcfb-da25-7574-3c7e-e3929383df71@mind.be> (Arnout Vandecappelle's message of "Thu, 5 Oct 2017 20:44:47 +0200")

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

 >  Hi Peter,
 >  Looks like I don't manage to apply any of your patches today :-)

 > On 03-10-17 10:04, Peter Korsgaard wrote:
 >> The dependency is actually only for the kernel module (and thus on the
 >> runtime kernel version rather than kernel headers), but as we don't know the
 >> runtime version in kconfig this will have to do.
 >> 
 >> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
 >> ---
 >> package/wireguard/Config.in | 4 ++++
 >> 1 file changed, 4 insertions(+)
 >> 
 >> diff --git a/package/wireguard/Config.in b/package/wireguard/Config.in
 >> index 0321755db3..acce6663ba 100644
 >> --- a/package/wireguard/Config.in
 >> +++ b/package/wireguard/Config.in
 >> @@ -1,5 +1,6 @@
 >> config BR2_PACKAGE_WIREGUARD
 >> bool "wireguard"
 >> +	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10

 >  The kernel module is only built if BR2_LINUX_KERNEL=y, so shouldn't this be

 > 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10 || !BR2_LINUX_KERNEL

That was my first thought as well, but it doesn't make much sense to
build the user space part if the kernel is too old, and I couldn't come
up with a good and clear wording for the comment - So I opted to keep it
simple.

But we can change it if you feel strongly about it. What do you suggest
for the comment text?

 > ? And of course in the comment as well.

 >  In addition, I think you should add the (abbreviated) contents of the commit
 > message as a comment here, otherwise it's not at all clear.

Ok, I can do that when applying.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2017-10-05 19:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-03  8:04 [Buildroot] [PATCH] wireguard: needs 3.10+ kernel Peter Korsgaard
2017-10-05 18:44 ` Arnout Vandecappelle
2017-10-05 19:46   ` Peter Korsgaard [this message]
2017-10-05 19:51     ` Arnout Vandecappelle
2017-10-05 20:53       ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8760btidhp.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox