* [Buildroot] [PATCH] whois: add extra libs for libiconv
@ 2014-06-26 10:05 Gustavo Zacarias
2014-06-26 12:43 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo Zacarias @ 2014-06-26 10:05 UTC (permalink / raw)
To: buildroot
The main makefile doesn't check/do anything about linking properly, so
add -liconv to LIBS when it's used. Fixes:
http://autobuild.buildroot.net/results/7e5/7e551efacfa16b9e1915748a2f66fd1021d5bb49/
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
package/whois/whois.mk | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/package/whois/whois.mk b/package/whois/whois.mk
index 91450f6..4c40481 100644
--- a/package/whois/whois.mk
+++ b/package/whois/whois.mk
@@ -10,17 +10,19 @@ WHOIS_SOURCE = whois_$(WHOIS_VERSION).tar.xz
# take precedence over busybox implementation
WHOIS_DEPENDENCIES = host-gettext $(if $(BR2_PACKAGE_BUSYBOX),busybox)
WHOIS_MAKE_ENV = $(TARGET_MAKE_ENV)
-WHOIS_MAKE_OPT = CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)"
+WHOIS_MAKE_OPT = CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)" \
+ LIBS="$(WHOIS_EXTRA_LIBS)"
WHOIS_LICENSE = GPLv2+
WHOIS_LICENSE_FILES = COPYING
ifeq ($(BR2_NEEDS_GETTEXT),y)
WHOIS_DEPENDENCIES += gettext
-WHOIS_MAKE_OPT += LIBS="-lintl"
+WHOIS_EXTRA_LIBS += -lintl
endif
ifeq ($(BR2_PACKAGE_LIBICONV),y)
WHOIS_DEPENDENCIES += libiconv
+WHOIS_EXTRA_LIBS += -liconv
WHOIS_MAKE_ENV += HAVE_ICONV=1
endif
--
1.8.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] whois: add extra libs for libiconv
2014-06-26 10:05 [Buildroot] [PATCH] whois: add extra libs for libiconv Gustavo Zacarias
@ 2014-06-26 12:43 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2014-06-26 12:43 UTC (permalink / raw)
To: buildroot
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:
> The main makefile doesn't check/do anything about linking properly, so
> add -liconv to LIBS when it's used. Fixes:
> http://autobuild.buildroot.net/results/7e5/7e551efacfa16b9e1915748a2f66fd1021d5bb49/
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-26 12:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-26 10:05 [Buildroot] [PATCH] whois: add extra libs for libiconv Gustavo Zacarias
2014-06-26 12:43 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox