[Buildroot] [PATCH v2] directfb: Make imlib2 support optional

[Buildroot] [PATCH v2] directfb: Make imlib2 support optional

[Markos Chandras]

From: Markos Chandras <markos.chandras@imgtec.com>

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
Changes since v1:
- Make imlib2 support optional
---
 package/directfb/Config.in   | 5 +++++
 package/directfb/directfb.mk | 8 ++++++++
 2 files changed, 13 insertions(+)

diff --git a/package/directfb/Config.in b/package/directfb/Config.in
index b9ff5f9..a6bfb6b 100644
--- a/package/directfb/Config.in
+++ b/package/directfb/Config.in
@@ -100,6 +100,11 @@ config BR2_PACKAGE_DIRECTFB_GIF
 	bool "enable GIF support"
 	default y
 
+config BR2_PACKAGE_DIRECTFB_IMLIB2
+	bool "enable IMLIB2 support"
+	default y
+	select BR2_PACKAGE_IMLIB2
+
 config BR2_PACKAGE_DIRECTFB_JPEG
 	bool "enable JPEG support"
 	default y
diff --git a/package/directfb/directfb.mk b/package/directfb/directfb.mk
index 5ead084..e5a423d 100644
--- a/package/directfb/directfb.mk
+++ b/package/directfb/directfb.mk
@@ -108,6 +108,14 @@ else
 DIRECTFB_CONF_OPT += --disable-jpeg
 endif
 
+ifeq ($(BR2_PACKAGE_DIRECTFB_IMLIB2),y)
+DIRECTFB_CONF_OPT += --enable-imlib2
+DIRECTFB_DEPENDENCIES += imlib2
+DIRECTFB_CONF_ENV += ac_cv_path_IMLIB2_CONFIG=$(STAGING_DIR)/usr/bin/imlib2-config
+else
+DIRECTFB_CONF_OPT += --disable-imlib2
+endif
+
 ifeq ($(BR2_PACKAGE_DIRECTFB_DITHER_RGB16),y)
 DIRECTFB_CONF_OPT += --with-dither-rgb16=advanced
 else
-- 
1.8.2.1

[Buildroot] [PATCH v2] directfb: Make imlib2 support optional

[Markos Chandras]

On 21 May 2013 10:29, Markos Chandras <markos.chandras@gmail.com> wrote:
> From: Markos Chandras <markos.chandras@imgtec.com>
>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> ---
> Changes since v1:
> - Make imlib2 support optional
> ---
>  package/directfb/Config.in   | 5 +++++
>  package/directfb/directfb.mk | 8 ++++++++
>  2 files changed, 13 insertions(+)
>
> diff --git a/package/directfb/Config.in b/package/directfb/Config.in
> index b9ff5f9..a6bfb6b 100644
> --- a/package/directfb/Config.in
> +++ b/package/directfb/Config.in
> @@ -100,6 +100,11 @@ config BR2_PACKAGE_DIRECTFB_GIF
>         bool "enable GIF support"
>         default y
>
> +config BR2_PACKAGE_DIRECTFB_IMLIB2
> +       bool "enable IMLIB2 support"
> +       default y
> +       select BR2_PACKAGE_IMLIB2
> +
>  config BR2_PACKAGE_DIRECTFB_JPEG
>         bool "enable JPEG support"
>         default y
> diff --git a/package/directfb/directfb.mk b/package/directfb/directfb.mk
> index 5ead084..e5a423d 100644
> --- a/package/directfb/directfb.mk
> +++ b/package/directfb/directfb.mk
> @@ -108,6 +108,14 @@ else
>  DIRECTFB_CONF_OPT += --disable-jpeg
>  endif
>
> +ifeq ($(BR2_PACKAGE_DIRECTFB_IMLIB2),y)
> +DIRECTFB_CONF_OPT += --enable-imlib2
> +DIRECTFB_DEPENDENCIES += imlib2
> +DIRECTFB_CONF_ENV += ac_cv_path_IMLIB2_CONFIG=$(STAGING_DIR)/usr/bin/imlib2-config
> +else
> +DIRECTFB_CONF_OPT += --disable-imlib2
> +endif
> +
>  ifeq ($(BR2_PACKAGE_DIRECTFB_DITHER_RGB16),y)
>  DIRECTFB_CONF_OPT += --with-dither-rgb16=advanced
>  else
> --
> 1.8.2.1
>
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

Hi,

Any comments about this patch?

--
Regards,
Markos Chandras

[Buildroot] [PATCH v2] directfb: Make imlib2 support optional

[Peter Korsgaard]

>>>>> "Markos" == Markos Chandras <markos.chandras@gmail.com> writes:

Regarding subject - That's not really what the patch does, it adds
optional imlib2 support.

 Markos> From: Markos Chandras <markos.chandras@imgtec.com>
 Markos> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
 Markos> ---
 Markos> Changes since v1:
 Markos> - Make imlib2 support optional
 Markos> ---
 Markos>  package/directfb/Config.in   | 5 +++++
 Markos>  package/directfb/directfb.mk | 8 ++++++++
 Markos>  2 files changed, 13 insertions(+)

 Markos> diff --git a/package/directfb/Config.in b/package/directfb/Config.in
 Markos> index b9ff5f9..a6bfb6b 100644
 Markos> --- a/package/directfb/Config.in
 Markos> +++ b/package/directfb/Config.in
 Markos> @@ -100,6 +100,11 @@ config BR2_PACKAGE_DIRECTFB_GIF
 Markos>  	bool "enable GIF support"
 Markos>  	default y
 
 Markos> +config BR2_PACKAGE_DIRECTFB_IMLIB2
 Markos> +	bool "enable IMLIB2 support"
 Markos> +	default y
 Markos> +	select BR2_PACKAGE_IMLIB2

Directfb didn't use to pull in imlib2, and it apparently wasn't
critical, so I've dropped the 'default y'.

Committed with that fixed, thanks.

-- 
Bye, Peter Korsgaard