Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] commiting patches
Date: Thu, 30 Dec 2010 21:54:51 +0100	[thread overview]
Message-ID: <8739pfhtgk.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20101230063005.15755osot9w5qwco@www.home.zuerker.org> (Heiko Zuerker's message of "Thu, 30 Dec 2010 06:30:05 -0600")

>>>>> "Heiko" == Heiko Zuerker <heiko@zuerker.org> writes:

 Heiko> Hey,

 Heiko> I was wondering for a while, what are the criterias for patches
 Heiko> to be applied to buildroot.
 Heiko> Some of them seem to get applied right away, others were sent in a
 Heiko> month or two ago and don't. I understand that some probably will never
 Heiko> get applied, but will there be a "sorry dude, but..." email?

I'm not following any strict procedure, but I do try to sooner or later
get around to review all patches. Understand that I do this in my spare
time, so turnaround time can sometimes be slow.

I mainly try to handle the patches in fifo mode, but I do also skim new
mails. This is both because sometimes updates are sent, and sometimes I
see trivial patches that can be handled when I have 5 min spare or
important bugfixes.

It's a big help when other developers help with the review and send
their ack/nacks (thanks for this!), so those patches are often handled
earlier than others.

But I can still forget about patches, so if you haven't had any feedback
for a week or two, please check if it still applies and send a followup
mail.

It might be politically incorrect, but the patch author also does
matter. If the patch is from a regular contributor who normally does
good work, then I know I don't need to review in as much details as if
it's from a complete stranger - So a good way of getting your own
patches applied faster is to help reviewing other patches ;)

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2010-12-30 20:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-30 12:30 [Buildroot] commiting patches Heiko Zuerker
2010-12-30 18:18 ` Yann E. MORIN
2010-12-30 20:58   ` Peter Korsgaard
2010-12-30 20:54 ` Peter Korsgaard [this message]
2010-12-30 21:04   ` Daniel Nyström
2010-12-30 21:24     ` Sam Ravnborg
2010-12-30 22:07     ` Peter Korsgaard
2010-12-30 22:22       ` Daniel Nyström
2010-12-30 22:25         ` Peter Korsgaard
2010-12-30 22:24       ` Heiko Zuerker
2010-12-30 22:30         ` Peter Korsgaard
2010-12-30 22:39           ` Bryan Hundven
2010-12-30 21:38   ` Heiko Zuerker
2011-01-03  8:08   ` Thomas Petazzoni
2011-01-03  8:32     ` Peter Korsgaard
2011-01-03 13:47       ` Heiko Zuerker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8739pfhtgk.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox