[Buildroot] [Bug 163] New: Xtensa architecrute port

[Buildroot] [Bug 163] New: Xtensa architecrute port

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=163

              Host: GNU/Linux X86
            Target: Xtensa
             Build: current
           Summary: Xtensa architecrute port
           Product: buildroot
           Version: unspecified
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: enhancement
          Priority: P3
         Component: Other
        AssignedTo: unassigned at buildroot.uclibc.org
        ReportedBy: maxim2405 at gmail.com
                CC: buildroot at uclibc.org
   Estimated Hours: 0.0


I would like to submit an Xtensa architecture port to BUILDROOT repository.
The submission assumes a set of patches. Most of them are
architecture-specific.

Xtensa is a family of configurable and extensible
processors, which have been on the IP market for quite some
time now. For those of you who are interested, please, look at

            http://www.tensilica.com/

Maxim Grigoriev


-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 163] Xtensa architecrute port

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=163





--- Comment #1 from Maxim Grigoriev <maxim2405@gmail.com>  2009-03-09 20:22:16 UTC ---
Created an attachment (id=115)
 --> (https://bugs.busybox.net/attachment.cgi?id=115)
This is the first patch in a set of Xtensa port patches

      Xtensa BUILDROOT uses a concept of source overlays,
      which are necessary because Xtensa processors are
      configurable and extensible. Xtensa tools, e.g.
      gcc, gdb, and binutils, use source overlays, which
      can not be substituted by the current BUILDROOT
      patching mechanism. This update makes patch-kernel.sh
      script capable of handling these overlays.


-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 163] Xtensa architecture port

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=163


Maxim Grigoriev <maxim2405@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Xtensa architecrute port    |Xtensa architecture port




-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 163] Xtensa architecture port

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=163


Bernhard <rep.dot.nop@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Build|current                     |
               Host|GNU/Linux X86               |
             Target|Xtensa                      |xtensa-*-*




--- Comment #2 from Bernhard <rep.dot.nop@gmail.com>  2009-03-10 16:09:34 UTC ---
Host, Target, Build are the respective triplets.


-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 163] Xtensa architecture port

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=163





--- Comment #3 from Bernhard <rep.dot.nop@gmail.com>  2009-03-10 16:14:23 UTC ---
First, there are superfluous trailing ';' chars in your patch.

Does this:
+       uncomp="tar cf - --exclude=.svn --no-anchored -C";
work with busybox's tar?

What is "uparm" ment to be? Please use a more descriptive name.

Last, can you give some examples that show why you need these changes?


-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 163] Xtensa architecture port

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=163





--- Comment #4 from Maxim Grigoriev <maxim2405@gmail.com>  2009-03-10 22:46:01 UTC ---
Created an attachment (id=131)
 --> (https://bugs.busybox.net/attachment.cgi?id=131)
Improved and extended patch for patch-kernal.sh and toolchain Makefiles

>> --- Comment #3 from Bernhard <rep.dot.nop@gmail.com>  2009-03-10 16:14:23 UTC ---

Thanks much for your comments, Bernhard.
I've attached a new extended patch. I made it more self-explanatory
and consistent by adding binutils/gcc/gdb Makefiles' updates related
to our toolchain/patch-kernel.sh changes.

>>  First, there are superfluous trailing ';' chars in your patch.

Removed.

>> Does this:
>> +       uncomp="tar cf - --exclude=.svn --no-anchored -C";
>> work with busybox's tar?

Given that busybox tar is 1.18, I say "Yes". It works.
I was not able to build my busybox TAR package because of the build errors.
But, I checked it on my x86-linux box after installing GNU/TAR 1.18.

>> What is "uparm" meant to be? Please use a more descriptive name.

It's been replaced by "uncomp_parm" in the new patch.

>> Last, can you give some examples that show why you need these changes?

Applying Xtensa source overlays could be done without changing patch-kernel.sh,
but they would result in much more extensive changes to other Makefiles.
This change to patch-kernel.sh is the simplest and most elegant way
we found of applying source overlays.  It simply expands patch-kernel.sh to
handle tar files, and thus patch not just files, but also source trees.

Isn't it nice ? Can other BUILDROOT users find it useful ?

An example might be Xtensa overlay support for GDB.  With this change
to patch-kernel.sh, all we needed to edit in toolchain/gdb/gdb.mk was
to add a conditional include:

  ifneq ($(filter xtensa%,$(ARCH)),)
  include target/xtensa/patch.in
  GDB_PATCH_EXTRA:=$(call XTENSA_PATCH,gdb,$(GDB_PATCH_DIR),. ..)
  endif

and add $(GDB_PATCH_EXTRA) to the list of what patch-kernel.sh patches:

  <      toolchain/patch-kernel.sh $(GDB_DIR) $(GDB_PATCH_DIR) \*.patch
  --
  >      toolchain/patch-kernel.sh $(GDB_DIR) $(GDB_PATCH_DIR) \*.patch
$(GDB_PATCH_EXTRA)

The alternative is to add an Xtensa-specific line(s) to the gdb-unpacked
rule, which didn't seem quite as kosher.

Thanks,
-- Maxim


-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 163] Xtensa architecture port

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=163


Maxim Grigoriev <maxim2405@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|xtensa-*-*                  |xtensa*-*-*




-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 163] Xtensa architecture port

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=163





--- Comment #5 from Maxim Grigoriev <maxim2405@gmail.com>  2009-05-09 00:05:55 UTC ---
Created an attachment (id=299)
 --> (https://bugs.busybox.net/attachment.cgi?id=299)
Add Xtensa support to the top Buildroot Makefile


-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 163] Xtensa architecture port

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=163





--- Comment #6 from Maxim Grigoriev <maxim2405@gmail.com>  2009-05-09 00:06:40 UTC ---
Created an attachment (id=301)
 --> (https://bugs.busybox.net/attachment.cgi?id=301)
Add Xtensa support to Buildroot uClibc


-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 163] Xtensa architecture port

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=163





--- Comment #7 from Maxim Grigoriev <maxim2405@gmail.com>  2009-05-09 00:18:20 UTC ---
Created an attachment (id=303)
 --> (https://bugs.busybox.net/attachment.cgi?id=303)
Add Xtensa to Buildroot projects


-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 163] Xtensa architecture port

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=163





--- Comment #8 from Maxim Grigoriev <maxim2405@gmail.com>  2009-05-09 01:29:30 UTC ---
Created an attachment (id=305)
 --> (https://bugs.busybox.net/attachment.cgi?id=305)
Add Xtensa target to Buildroot

The list of files added/updated :

target/Config.in.arch
target/Makefile.in
target/xtensa/...
target/device/Config.in
target/device/xtensa/...


-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 163] Xtensa architecture port

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=163





--- Comment #9 from Maxim Grigoriev <maxim2405@gmail.com>  2009-05-09 01:59:06 UTC ---
Created an attachment (id=307)
 --> (https://bugs.busybox.net/attachment.cgi?id=307)
Add Xtensa to Buildroot packages

Touches 

package/gnuconfig/...
package/Makefile.in


-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 163] Xtensa architecture port

[Maxim Grigoriev]

Hello Buildroot maintainers and developers,

Last Friday, I finished submitting Xtensa Buildroot support :
All the patches are attached to

    https://bugs.busybox.net/show_bug.cgi?id=163

Can anybody, please, give me a clue on how good the chances are
these patches will be reviewed anytime soon ?

Thanks,
-- Maxim

[Buildroot] [Bug 163] Xtensa architecture port

[Peter Korsgaard]

>>>>> "Maxim" == Maxim Grigoriev <maxim@tensilica.com> writes:

 Maxim> Hello Buildroot maintainers and developers,
 Maxim> Last Friday, I finished submitting Xtensa Buildroot support :
 Maxim> All the patches are attached to

 Maxim>    https://bugs.busybox.net/show_bug.cgi?id=163

 Maxim> Can anybody, please, give me a clue on how good the chances are
 Maxim> these patches will be reviewed anytime soon ?

Sorry for the slow response on this. We're right now busy getting
2009.05 released, but I'll commit the patches once that's out unless
someone complains..

-- 
Bye, Peter Korsgaard

[Buildroot] [Bug 163] Xtensa architecture port

[Marc Gauthier]

Peter Korsgaard wrote:
> >>>>> "Maxim" == Maxim Grigoriev <maxim@tensilica.com> writes:
>
>  Maxim> Hello Buildroot maintainers and developers,
>  Maxim> Last Friday, I finished submitting Xtensa Buildroot support :
>  Maxim> All the patches are attached to
>
>  Maxim>    https://bugs.busybox.net/show_bug.cgi?id=163
>
>  Maxim> Can anybody, please, give me a clue on how good the
> chances are
>  Maxim> these patches will be reviewed anytime soon ?
>
> Sorry for the slow response on this. We're right now busy getting
> 2009.05 released, but I'll commit the patches once that's out unless
> someone complains..


Cool, thank you!

-Marc

[Buildroot] [Bug 163] Xtensa architecture port

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=163





--- Comment #10 from Peter Korsgaard <jacmet@uclibc.org>  2009-07-24 05:55:55 UTC ---
finally committed, thanks!


-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 163] Xtensa architecture port

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=163





--- Comment #11 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com>  2009-07-24 08:53:40 UTC ---
Peter, I don't think you committed the Xtensa support. Probably your comment
was related to another bug entry ?


-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 163] Xtensa architecture port

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=163


Peter Korsgaard <jacmet@uclibc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #12 from Peter Korsgaard <jacmet@uclibc.org>  2009-07-24 12:50:12 UTC ---
(In reply to comment #11)
> Peter, I don't think you committed the Xtensa support. Probably your comment
> was related to another bug entry ?

ehh, no - I committed the 6 patches this morning. The last one is

http://git.buildroot.net/buildroot/commit/?id=edb5ca9c529804c449a5ff3a11607bd26eef394b



-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.