[Buildroot] [git commit] package/petitboot: fix ordering of comments and sub-options

[Buildroot] [git commit] package/petitboot: fix ordering of comments and sub-options

[Thomas Petazzoni via buildroot]

commit: https://git.buildroot.net/buildroot/commit/?id=06dcbdf8ad3d55b92df4bc3ded82c08e21cbb60e
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Currently, the comment about availability is between the package main
symbol and its suboptions, breaking the threading in menuconfig.

Invert the order, and move the comment last. Also enclose the suboptions
between an if-block, as it is more customary.

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/petitboot/Config.in | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/package/petitboot/Config.in b/package/petitboot/Config.in
index 93ed3642c3..f931ab91cd 100644
--- a/package/petitboot/Config.in
+++ b/package/petitboot/Config.in
@@ -19,17 +19,20 @@ config BR2_PACKAGE_PETITBOOT
 
 	  http://www.kernel.org/pub/linux/kernel/people/geoff/petitboot/petitboot.html
 
-comment "petitboot needs a toolchain w/ wchar, dynamic library, threads, udev /dev management"
-	depends on BR2_PACKAGE_KEXEC_ARCH_SUPPORTS
-	depends on BR2_USE_MMU
-	depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS || \
-		!BR2_TOOLCHAIN_HAS_THREADS || \
-		!BR2_PACKAGE_HAS_UDEV
+if BR2_PACKAGE_PETITBOOT
 
 config BR2_PACKAGE_PETITBOOT_GETTY_PORT
 	string "TTY port(s)"
 	default "console"
-	depends on BR2_PACKAGE_PETITBOOT
 	help
 	  Specify a space-separated list of ports to run the petitboot
 	  UI on. Wildcards are allowed. Example: "hvc* ttys0 ttyS*"
+
+endif # BR2_PACKAGE_PETITBOOT
+
+comment "petitboot needs a toolchain w/ wchar, dynamic library, threads, udev /dev management"
+	depends on BR2_PACKAGE_KEXEC_ARCH_SUPPORTS
+	depends on BR2_USE_MMU
+	depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS || \
+		!BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_PACKAGE_HAS_UDEV
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [git commit] package/petitboot: fix ordering of comments and sub-options

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:

 > commit: https://git.buildroot.net/buildroot/commit/?id=06dcbdf8ad3d55b92df4bc3ded82c08e21cbb60e
 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

 > Currently, the comment about availability is between the package main
 > symbol and its suboptions, breaking the threading in menuconfig.

 > Invert the order, and move the comment last. Also enclose the suboptions
 > between an if-block, as it is more customary.

 > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot