[Buildroot] [PATCH 1/1] package/lvm2: fix libaio handling

[Buildroot] [PATCH 1/1] package/lvm2: fix libaio handling

[Fabrice Fontaine]

libaio is only needed for standard install

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/lvm2/Config.in | 2 +-
 package/lvm2/lvm2.mk   | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/lvm2/Config.in b/package/lvm2/Config.in
index 577a90656a..e1df71ee2f 100644
--- a/package/lvm2/Config.in
+++ b/package/lvm2/Config.in
@@ -3,7 +3,6 @@ config BR2_PACKAGE_LVM2
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_USE_MMU # needs fork()
 	depends on !BR2_STATIC_LIBS # It fails to build statically
-	select BR2_PACKAGE_LIBAIO
 	help
 	  This is LVM2, the rewrite of The Linux Logical Volume Manager.
 	  LVM supports enterprise level volume management of disk and
@@ -26,6 +25,7 @@ if BR2_PACKAGE_LVM2
 
 config BR2_PACKAGE_LVM2_STANDARD_INSTALL
 	bool "standard install instead of only dmsetup"
+	select BR2_PACKAGE_LIBAIO
 	default y
 	help
 	  Install the standard suite of lvm2 programs. When this option
diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
index 9caf99eb9b..474ea30bdc 100644
--- a/package/lvm2/lvm2.mk
+++ b/package/lvm2/lvm2.mk
@@ -25,7 +25,7 @@ LVM2_CONF_OPTS += \
 	--disable-nls \
 	--with-symvers=no
 
-LVM2_DEPENDENCIES += host-pkgconf libaio
+LVM2_DEPENDENCIES += host-pkgconf
 
 # LVM2 uses autoconf, but not automake, and the build system does not
 # take into account the toolchain passed at configure time.
@@ -49,6 +49,7 @@ LVM2_CONF_OPTS += --disable-selinux
 endif
 
 ifeq ($(BR2_PACKAGE_LVM2_STANDARD_INSTALL),y)
+LVM2_DEPENDENCIES += libaio
 LVM2_INSTALL_STAGING_OPTS += install
 LVM2_INSTALL_TARGET_OPTS += install
 ifeq ($(BR2_INIT_SYSTEMD),y)
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/lvm2: fix libaio handling

[Yann E. MORIN]

Fabrice, All,

On 2024-01-07 15:19 +0100, Fabrice Fontaine spake thusly:
> libaio is only needed for standard install
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/lvm2/Config.in | 2 +-
>  package/lvm2/lvm2.mk   | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/lvm2/Config.in b/package/lvm2/Config.in
> index 577a90656a..e1df71ee2f 100644
> --- a/package/lvm2/Config.in
> +++ b/package/lvm2/Config.in
> @@ -3,7 +3,6 @@ config BR2_PACKAGE_LVM2
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	depends on BR2_USE_MMU # needs fork()
>  	depends on !BR2_STATIC_LIBS # It fails to build statically
> -	select BR2_PACKAGE_LIBAIO

    $ ./utils/docker-run make check-package
    package/lvm2/Config.in:29: attributes order: type, default, depends on, select, help (http://nightly.buildroot.org/#_config_files)

Applied to master with that fixed, thanks.

Regards,
Yann E. MORIN.

>  	help
>  	  This is LVM2, the rewrite of The Linux Logical Volume Manager.
>  	  LVM supports enterprise level volume management of disk and
> @@ -26,6 +25,7 @@ if BR2_PACKAGE_LVM2
>  
>  config BR2_PACKAGE_LVM2_STANDARD_INSTALL
>  	bool "standard install instead of only dmsetup"
> +	select BR2_PACKAGE_LIBAIO
>  	default y
>  	help
>  	  Install the standard suite of lvm2 programs. When this option
> diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
> index 9caf99eb9b..474ea30bdc 100644
> --- a/package/lvm2/lvm2.mk
> +++ b/package/lvm2/lvm2.mk
> @@ -25,7 +25,7 @@ LVM2_CONF_OPTS += \
>  	--disable-nls \
>  	--with-symvers=no
>  
> -LVM2_DEPENDENCIES += host-pkgconf libaio
> +LVM2_DEPENDENCIES += host-pkgconf
>  
>  # LVM2 uses autoconf, but not automake, and the build system does not
>  # take into account the toolchain passed at configure time.
> @@ -49,6 +49,7 @@ LVM2_CONF_OPTS += --disable-selinux
>  endif
>  
>  ifeq ($(BR2_PACKAGE_LVM2_STANDARD_INSTALL),y)
> +LVM2_DEPENDENCIES += libaio
>  LVM2_INSTALL_STAGING_OPTS += install
>  LVM2_INSTALL_TARGET_OPTS += install
>  ifeq ($(BR2_INIT_SYSTEMD),y)
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/lvm2: fix libaio handling

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > libaio is only needed for standard install
 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2023.02.x and 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot