[Buildroot] [PATCH 1/1] package/php: force arm mode instead of Thumb mode

[Buildroot] [PATCH 1/1] package/php: force arm mode instead of Thumb mode

[Bernd Kuhls]

Fix the following build failure:
/tmp/ccqcLrVb.s:4053: Error: selected processor does not support `umlal r2,r1,r0,r3' in Thumb mode
/tmp/ccqcLrVb.s:4076: Error: selected processor does not support `umlal r0,r3,r1,r2' in Thumb mode
/tmp/ccqcLrVb.s:8644: Error: selected processor does not support `umlal r0,r3,r2,r4' in Thumb mode

Fixes:
http://autobuild.buildroot.net/results/1d09a0a58cbc1712416de746d57d4532df580673/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/php/php.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/php/php.mk b/package/php/php.mk
index 6a2a6ae71b..68aeceb33e 100644
--- a/package/php/php.mk
+++ b/package/php/php.mk
@@ -84,6 +84,13 @@ else
 PHP_CONF_ENV += ac_cv_func_dlopen=no ac_cv_lib_dl_dlopen=no
 endif
 
+# php has some assembly function that is not present in Thumb mode:
+# Error: selected processor does not support `umlal r2,r1,r0,r3' in Thumb mode
+# so, we desactivate Thumb mode
+ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB),y)
+PHP_CFLAGS += -marm
+endif
+
 PHP_CONF_OPTS += $(if $(BR2_PACKAGE_PHP_SAPI_CLI),--enable-cli,--disable-cli)
 PHP_CONF_OPTS += $(if $(BR2_PACKAGE_PHP_SAPI_CGI),--enable-cgi,--disable-cgi)
 PHP_CONF_OPTS += $(if $(BR2_PACKAGE_PHP_SAPI_FPM),--enable-fpm,--disable-fpm)
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/php: force arm mode instead of Thumb mode

[Thomas Petazzoni via buildroot]

On Fri, 28 Jul 2023 19:20:26 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Fix the following build failure:
> /tmp/ccqcLrVb.s:4053: Error: selected processor does not support `umlal r2,r1,r0,r3' in Thumb mode
> /tmp/ccqcLrVb.s:4076: Error: selected processor does not support `umlal r0,r3,r1,r2' in Thumb mode
> /tmp/ccqcLrVb.s:8644: Error: selected processor does not support `umlal r0,r3,r2,r4' in Thumb mode
> 
> Fixes:
> http://autobuild.buildroot.net/results/1d09a0a58cbc1712416de746d57d4532df580673/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/php/php.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/php: force arm mode instead of Thumb mode

[Peter Korsgaard]

>>>>> "Bernd" == Bernd Kuhls <bernd@kuhls.net> writes:

 > Fix the following build failure:
 > /tmp/ccqcLrVb.s:4053: Error: selected processor does not support `umlal r2,r1,r0,r3' in Thumb mode
 > /tmp/ccqcLrVb.s:4076: Error: selected processor does not support `umlal r0,r3,r1,r2' in Thumb mode
 > /tmp/ccqcLrVb.s:8644: Error: selected processor does not support `umlal r0,r3,r2,r4' in Thumb mode

 > Fixes:
 > http://autobuild.buildroot.net/results/1d09a0a58cbc1712416de746d57d4532df580673/

 > Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Committed to 2023.02.x and 2023.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/php: force arm mode instead of Thumb mode

[Baruch Siach via buildroot]

Hi Peter,

On Wed, Aug 30 2023, Peter Korsgaard wrote:

>>>>>> "Bernd" == Bernd Kuhls <bernd@kuhls.net> writes:
>
>  > Fix the following build failure:
>  > /tmp/ccqcLrVb.s:4053: Error: selected processor does not support `umlal r2,r1,r0,r3' in Thumb mode
>  > /tmp/ccqcLrVb.s:4076: Error: selected processor does not support `umlal r0,r3,r1,r2' in Thumb mode
>  > /tmp/ccqcLrVb.s:8644: Error: selected processor does not support `umlal r0,r3,r2,r4' in Thumb mode
>
>  > Fixes:
>  > http://autobuild.buildroot.net/results/1d09a0a58cbc1712416de746d57d4532df580673/
>
>  > Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
>
> Committed to 2023.02.x and 2023.05.x, thanks.

Not in the 2023.02.x branch as of commit 34dde405262f.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/php: force arm mode instead of Thumb mode

[Peter Korsgaard]

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > Hi Peter,
 > On Wed, Aug 30 2023, Peter Korsgaard wrote:

 >>>>>>> "Bernd" == Bernd Kuhls <bernd@kuhls.net> writes:
 >> 
 >> > Fix the following build failure:
 >> > /tmp/ccqcLrVb.s:4053: Error: selected processor does not support `umlal r2,r1,r0,r3' in Thumb mode
 >> > /tmp/ccqcLrVb.s:4076: Error: selected processor does not support `umlal r0,r3,r1,r2' in Thumb mode
 >> > /tmp/ccqcLrVb.s:8644: Error: selected processor does not support `umlal r0,r3,r2,r4' in Thumb mode
 >> 
 >> > Fixes:
 >> > http://autobuild.buildroot.net/results/1d09a0a58cbc1712416de746d57d4532df580673/
 >> 
 >> > Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
 >> 
 >> Committed to 2023.02.x and 2023.05.x, thanks.

 > Not in the 2023.02.x branch as of commit 34dde405262f.

Argh, I'm clearly trying to do too many different things at once, I'll
stop.

Thanks!

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot